chore: sonar issues

Author: fugerit79

fj-core/src/main/java/org/fugerit/java/core/db/daogen/BasicDAOHelper.java

@@ -86,7 +86,7 @@ public void loadAllHelper( List<T> l, SelectHelper query, RSExtractor<T> re ) th
 		this.loadAllHelper( l, query.getQueryContent(), query.getFields(), re );
 	}
 
-	private PreparedStatement prepareStatement( PreparedStatement ps, DAOContext context ) throws SQLException {
+	private PreparedStatement prepareStatement( PreparedStatement ps, DAOContext context ) {
 		return this.statementHelper.apply( ps, context );
 	}
 

fj-core/src/test/java/test/org/fugerit/java/core/db/dao/TestDAORuntimeException.java

@@ -1,11 +1,23 @@
 package test.org.fugerit.java.core.db.dao;
 
 import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.List;
 
+import lombok.extern.slf4j.Slf4j;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.core.LogEvent;
+import org.apache.logging.log4j.core.Logger;
+import org.apache.logging.log4j.core.appender.AbstractAppender;
+import org.apache.logging.log4j.core.config.Property;
 import org.fugerit.java.core.db.dao.DAORuntimeException;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
+import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+@Slf4j
 class TestDAORuntimeException {
 
 	@Test
@@ -15,7 +27,52 @@ void testApply() {
 
 	@Test
 	void testApplySilent() {
-		DAORuntimeException.applySilent( () -> { throw new SQLException( "junit test scenario apply silent" ); });
+		// Create a custom appender to capture log events
+		List<LogEvent> logEvents = new ArrayList<>();
+
+		AbstractAppender testAppender = new AbstractAppender("TestAppender", null, null, true, Property.EMPTY_ARRAY) {
+			@Override
+			public void append(LogEvent event) {
+				logEvents.add(event.toImmutable());
+			}
+		};
+		testAppender.start();
+
+		// Get the logger and add our appender
+		Logger logger = (Logger) LogManager.getLogger(DAORuntimeException.class);
+		logger.addAppender(testAppender);
+		logger.setAdditive(true);
+
+		String errorMessage = "junit test scenario apply silent";
+
+		try {
+			// Execute the method under test
+			DAORuntimeException.applySilent(() -> {
+				throw new SQLException(errorMessage);
+			});
+
+			// Verify log event was captured
+			assertEquals(1, logEvents.size());
+
+			LogEvent logEvent = logEvents.get(0);
+
+			// Verify it's a WARN level
+			assertEquals(org.apache.logging.log4j.Level.WARN, logEvent.getLevel());
+
+			// Verify the message
+			String message = logEvent.getMessage().getFormattedMessage();
+			assertTrue(message.contains("Exception on DAORuntimeException.applySilent()"));
+			assertTrue(message.contains(errorMessage));
+
+			// Verify the throwable
+			assertNotNull(logEvent.getThrown());
+			assertTrue(logEvent.getThrown() instanceof SQLException);
+
+		} finally {
+			// Clean up
+			logger.removeAppender(testAppender);
+			testAppender.stop();
+		}
 	}
 
 	@Test