Skip to content

Conversation

@TheAngryByrd
Copy link
Collaborator

Modified your already available WhileAsync from TaskSeq builder. I think this is statically compiling.

@abelbraaksma
Copy link
Member

abelbraaksma commented Nov 22, 2022

Thanks for this! Awesome stuff :)

Will need some more tests, though, specifically as well with the "mutual" test sets and some that mutate state in + outside the while, to ensure all runs in good order.

Strange that the test reports won't run. The test results are fine. Maybe it is similar to what you had locally, where it gave you access denied to the files in a branch.

Creating test report Report debug tests
  Processing test results from ./src/FSharp.Control.TaskSeq.Test/TestResults/test-results-debug.trx
  Creating check run Report debug tests
Error: HttpError: Resource not accessible by integration

@TheAngryByrd
Copy link
Collaborator Author

Strange 🤷

Yeah definitely should add more tests, I'm unsure of all the scenarios and I just kind of rage coded this out until I was sleepy 😄

@abelbraaksma abelbraaksma force-pushed the forloop-with-iasyncenumerable-with-task-and-async-2 branch 2 times, most recently from be5b3b7 to 89dd0ec Compare November 24, 2022 18:02
@abelbraaksma abelbraaksma force-pushed the forloop-with-iasyncenumerable-with-task-and-async branch from 9190789 to ef2de06 Compare November 24, 2022 18:05
@abelbraaksma abelbraaksma force-pushed the forloop-with-iasyncenumerable-with-task-and-async branch from ef2de06 to 16df03d Compare November 24, 2022 18:09
@abelbraaksma abelbraaksma force-pushed the forloop-with-iasyncenumerable-with-task-and-async-2 branch from 94a0704 to c2d117c Compare November 24, 2022 23:53
… forloop-with-iasyncenumerable-with-task-and-async-2
@abelbraaksma abelbraaksma added enhancement New feature or request topic: ce extensions Extensions to other CE's like task or async labels Nov 25, 2022
@abelbraaksma abelbraaksma force-pushed the forloop-with-iasyncenumerable-with-task-and-async branch from 16df03d to 6eac005 Compare November 25, 2022 00:35
@abelbraaksma abelbraaksma force-pushed the forloop-with-iasyncenumerable-with-task-and-async branch from 9557a86 to 785af2a Compare November 25, 2022 15:05
@abelbraaksma abelbraaksma deleted the branch fsprojects:forloop-with-iasyncenumerable-with-task-and-async November 26, 2022 20:00
@abelbraaksma
Copy link
Member

abelbraaksma commented Nov 26, 2022

This code is now part of #93. which in turn closed this issue. Thanks again! It'll be part of v0.3.0, probably later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request topic: ce extensions Extensions to other CE's like task or async

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants