chore: lint, format, and ensure app runs in Docker

Author: frckbrice

.github/workflows/ci-cd.yml

@@ -42,7 +42,7 @@ jobs:
         run: yarn test
 
       - name: Build Docker image
-        run: docker build -t maebrie2017/clean-code-arch-rest-api:latest .
+        run: docker build -t maebrie2017/clean-arch-app:latest .
 
       - name: Log in to Docker Hub
         uses: docker/login-action@v3
@@ -52,7 +52,7 @@ jobs:
 
       - name: Push Docker image
         run: |
-          IMAGE=maebrie2017/clean-code-arch-rest-api
+          IMAGE=maebrie2017/clean-arch-app
           docker tag $IMAGE:latest $IMAGE:${{ github.sha }}
           docker push $IMAGE:latest
           docker push $IMAGE:${{ github.sha }}

docker-compose.yml

@@ -4,14 +4,15 @@ services:
     build: .
     container_name: clean-arch-app
     ports:
-      - '5000:5000'
+      - '5001:5000' # Change 5001 to any free port
     environment:
       - PORT=5000
-      - MONGODB_URI=mongodb://mongo:27017/cleanarchdb
-      - JWT_SECRET=your_jwt_secret
+      - MONGODB_URI=${MONGODB_URI}
+      - JWT_SECRET=${JWT_SECRET}
     depends_on:
       - mongo
     restart: unless-stopped
+
   mongo:
     image: mongo:6.0
     container_name: clean-arch-mongo

enterprise-business-rules/validate-models/product-validation-fcts.js

@@ -72,28 +72,28 @@ function validateColors(colors, InvalidPropertyError) {
 }
 
 // constructs an enumeration of brands
-function validateBrands(brands, InvalidPropertyError) {
-  console.log('brand: ', brands);
-  if (!Array.isArray(brands)) {
-    return [brands];
-  }
-
-  const validbrands = new Set([
-    'Apple',
-    'Samsung',
-    'Microsoft',
-    'Lenovo',
-    'Acer',
-    'Asus',
-    'HP',
-    'Dell',
-  ]);
-  if (brands.length === 0 || !brands.some((color) => validbrands.has(color))) {
-    throw new InvalidPropertyError(`A product must have at least one color.`);
-  }
-
-  return [...new Set(brands)];
-}
+// function validateBrands(brands, InvalidPropertyError) {
+//   console.log('brand: ', brands);
+//   if (!Array.isArray(brands)) {
+//     return [brands];
+//   }
+
+//   const validbrands = new Set([
+//     'Apple',
+//     'Samsung',
+//     'Microsoft',
+//     'Lenovo',
+//     'Acer',
+//     'Asus',
+//     'HP',
+//     'Dell',
+//   ]);
+//   if (brands.length === 0 || !brands.some((color) => validbrands.has(color))) {
+//     throw new InvalidPropertyError(`A product must have at least one color.`);
+//   }
+
+//   return [...new Set(brands)];
+// }
 
 //validate and normalize product rating: rating is an array of refences to users in the users collection
 // function validateRating(rating, InvalidPropertyError) {

enterprise-business-rules/validate-models/user-validation-functions.js

@@ -5,7 +5,7 @@ const {
 
 // TODO: remove this external data storage and package here  and from here.
 // We don't respect the clean code architecture with this
-const bcrypt = require('bcrypt');
+const bcrypt = require('bcryptjs');
 const { ObjectId } = require('mongodb');
 
 /**

interface-adapters/controllers/users/index.js

@@ -3,7 +3,7 @@ const userUseCaseHandlers = require('../../../application-business-rules/use-cas
 
 const { makeHttpError } = require('../../validators-errors/http-error');
 const { logEvents } = require('../../middlewares/loggers/logger');
-const bcrypt = require('bcrypt');
+const bcrypt = require('bcryptjs');
 const jwt = require('jsonwebtoken');
 const sendEmail = require('../../adapter/email-sending');
 

interface-adapters/database-access/db-connection.js

@@ -10,7 +10,7 @@ module.exports = {
   dbconnection: async () => {
     // The MongoClient is the object that references the connection to our
     // datastore (Atlas, for example)
-    const client = new MongoClient(process.env.DB_URI);
+    const client = new MongoClient(process.env.MONGODB_URI);
 
     // The connect() method does not attempt a connection; instead it instructs
     // the driver to connect using the settings provided when a connection

interface-adapters/database-access/db-indexes.js

@@ -6,10 +6,21 @@ module.exports = async function setupDb() {
   console.log('Setting up database indexes...');
   const db = await dbconnection();
 
-  const allProductsIndexName = await db.collection('products').listIndexes().toArray();
+  // PRODUCTS
+  let allProductsIndexName = [];
+  try {
+    allProductsIndexName = await db.collection('products').listIndexes().toArray();
+  } catch (err) {
+    if (err.codeName === 'NamespaceNotFound') {
+      await db.collection('products').insertOne({ __seed: true });
+      await db.collection('products').deleteOne({ __seed: true });
+      allProductsIndexName = [];
+    } else {
+      throw err;
+    }
+  }
 
   let indexArr = [];
-  // create indexes only if not exist
   allProductsIndexName.forEach((element) => {
     if (element.name === 'productTextIndex' || element.name === 'productUniqueIndex') {
       return;
@@ -37,7 +48,19 @@ module.exports = async function setupDb() {
     ];
   });
 
-  const allUsersIndexName = await db.collection('users').listIndexes().toArray();
+  // USERS
+  let allUsersIndexName = [];
+  try {
+    allUsersIndexName = await db.collection('users').listIndexes().toArray();
+  } catch (err) {
+    if (err.codeName === 'NamespaceNotFound') {
+      await db.collection('users').insertOne({ __seed: true });
+      await db.collection('users').deleteOne({ __seed: true });
+      allUsersIndexName = [];
+    } else {
+      throw err;
+    }
+  }
   allUsersIndexName.forEach((element) => {
     if (element.name === 'userUniqueIndex') {
       return;
@@ -50,7 +73,19 @@ module.exports = async function setupDb() {
     ];
   });
 
-  const allRatingsIndexName = await db.collection('ratings').listIndexes().toArray();
+  // RATINGS
+  let allRatingsIndexName = [];
+  try {
+    allRatingsIndexName = await db.collection('ratings').listIndexes().toArray();
+  } catch (err) {
+    if (err.codeName === 'NamespaceNotFound') {
+      await db.collection('ratings').insertOne({ __seed: true });
+      await db.collection('ratings').deleteOne({ __seed: true });
+      allRatingsIndexName = [];
+    } else {
+      throw err;
+    }
+  }
   allRatingsIndexName.forEach((element) => {
     if (element.name === 'ratingsUniqueIndex') {
       // db.collection('ratings').dropIndex('ratingsUniqueIndex');

interface-adapters/database-access/store-product.js

@@ -196,10 +196,11 @@ const updatedProduct = async ({ productId, dbconnection, logEvents, ...productDa
   }
 };
 
-// create a raiting document and update product document alongside
+// create a rating document and update product document alongside
+// we are creating transaction session to ensure data consistency
 
 const rateProduct = async ({ logEvents, ...ratingModel }) => {
-  const client = new MongoClient(process.env.DB_URI);
+  const client = new MongoClient(process.env.MONGODB_URI);
   const session = client.startSession();
 
   /* start a transaction session */

package.json

@@ -7,18 +7,20 @@
   "author": {
     "name": "avom brice ",
     "address": "frckbrice <bricefrkc@gmail,com> (https://maebrie.vercel.app)",
-    "date": "jun 12 2024"
+    "date": "jun 12 2024",
+    "update": "jul 22 2025"
   },
   "scripts": {
     "start": "node index.js",
     "dev": "nodemon index.js",
     "lint": "eslint . --ext .js",
     "format": "prettier --write .",
     "prepare": "husky install",
-    "test": "jest --runInBand"
+    "test": "jest --runInBand",
+    "build": "tsc --noEmitOnError"
   },
   "dependencies": {
-    "bcrypt": "^5.1.1",
+    "bcryptjs": "^3.0.2",
     "cors": "^2.8.5",
     "cuid": "^3.0.0",
     "date-fns": "^3.6.0",