Skip to content

Commit 49f4eef

Browse files
committed
fix: align product routes and controllers, ready for DB integration tests
1 parent 3eefee8 commit 49f4eef

File tree

2 files changed

+19
-13
lines changed

2 files changed

+19
-13
lines changed

.github/workflows/ci-cd.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
run: yarn test
4343

4444
- name: Build Docker image
45-
run: docker build -t your-dockerhub-username/your-repo-name:latest .
45+
run: docker build -t maebrie2017/clean-code-arch-rest-api:latest .
4646

4747
- name: Log in to Docker Hub
4848
uses: docker/login-action@v3
@@ -52,7 +52,7 @@ jobs:
5252

5353
- name: Push Docker image
5454
run: |
55-
IMAGE=your-dockerhub-username/your-repo-name
55+
IMAGE=maebrie2017/clean-code-arch-rest-api
5656
docker tag $IMAGE:latest $IMAGE:${{ github.sha }}
5757
docker push $IMAGE:latest
5858
docker push $IMAGE:${{ github.sha }}

routes/product.routes.js

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,37 +2,43 @@ const router = require('express').Router();
22
const requestResponseAdapter = require('../interface-adapters/adapter/request-response-adapter');
33
const productControllerHamdlers = require('../interface-adapters/controllers/products');
44

5-
// POST /products - Create product
5+
const {
6+
createProductControllerHandler,
7+
findAllProductControllerHandler,
8+
findOneProductControllerHandler,
9+
updateProductControllerHandler,
10+
deleteProductControllerHandler,
11+
rateProductControllerHandler,
12+
} = productControllerHamdlers;
13+
14+
// GET /products - Get all products
615
router
716
.route('/')
817
.post(async (req, res) =>
9-
requestResponseAdapter(productControllerHamdlers.createProductControllerHandler)(req, res)
10-
)
11-
// GET /products - Get all products
18+
requestResponseAdapter(createProductControllerHandler)(req, res)
19+
)
1220
.get(async (req, res) =>
13-
requestResponseAdapter(productControllerHamdlers.findAllProductControllerHandler)(req, res)
21+
requestResponseAdapter(findAllProductControllerHandler)(req, res)
1422
);
1523

1624
// GET /products/:productId - Get one product
17-
// PUT /products/:productId - Update product
18-
// DELETE /products/:productId - Delete product
1925
router
2026
.route('/:productId')
2127
.get(async (req, res) =>
22-
requestResponseAdapter(productControllerHamdlers.findOneProductControllerHandler)(req, res)
28+
requestResponseAdapter(findOneProductControllerHandler)(req, res)
2329
)
2430
.put(async (req, res) =>
25-
requestResponseAdapter(productControllerHamdlers.updateProductControllerHandler)(req, res)
31+
requestResponseAdapter(updateProductControllerHandler)(req, res)
2632
)
2733
.delete(async (req, res) =>
28-
requestResponseAdapter(productControllerHamdlers.deleteProductControllerHandler)(req, res)
34+
requestResponseAdapter(deleteProductControllerHandler)(req, res)
2935
);
3036

3137
// POST /products/:productId/:userId/rating - Rate product
3238
router
3339
.route('/:productId/:userId/rating')
3440
.post(async (req, res) =>
35-
requestResponseAdapter(productControllerHamdlers.rateProductControllerHandler)(req, res)
41+
requestResponseAdapter(rateProductControllerHandler)(req, res)
3642
);
3743

3844
module.exports = router;

0 commit comments

Comments
 (0)