Skip to content

Commit b1fd746

Browse files
authored
Add php8.5 to the matrix (#280)
1 parent 30ee9fa commit b1fd746

File tree

2 files changed

+20
-13
lines changed

2 files changed

+20
-13
lines changed

.github/workflows/test.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,13 @@ jobs:
1515
runs-on: ubuntu-latest
1616
strategy:
1717
matrix:
18-
php-version: [ '8.1', '8.2', '8.3', '8.4' ]
18+
php-version: [ '8.1', '8.2', '8.3', '8.4', '8.5' ]
1919
composer-flags: [ '', '--prefer-lowest' ]
2020
exclude:
2121
- php-version: '8.4'
2222
composer-flags: '--prefer-lowest'
23+
- php-version: '8.5'
24+
composer-flags: '--prefer-lowest'
2325
steps:
2426
- uses: actions/checkout@v6
2527

@@ -39,15 +41,15 @@ jobs:
3941
run: composer test
4042

4143
coverage:
42-
name: PHP 8.4 - Test with coverage
44+
name: PHP 8.5 - Test with coverage
4345
runs-on: ubuntu-latest
4446
steps:
4547
- uses: actions/checkout@v6
4648

4749
- name: Setup PHP
4850
uses: shivammathur/setup-php@v2
4951
with:
50-
php-version: 8.4
52+
php-version: 8.5
5153
coverage: pcov
5254

5355
- name: Install dependencies
@@ -74,7 +76,7 @@ jobs:
7476
- name: Setup PHP
7577
uses: shivammathur/setup-php@v2
7678
with:
77-
php-version: 8.1
79+
php-version: 8.5
7880
coverage: none
7981

8082
- name: Install dependencies

src/DependencyInjection/Configuration.php

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
use Closure;
88
use FD\LogViewer\Service\File\Monolog\MonologLineParser;
99
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
10-
use Symfony\Component\Config\Definition\Builder\NodeDefinition;
1110
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
1211
use Symfony\Component\Config\Definition\ConfigurationInterface;
1312

@@ -16,10 +15,12 @@
1615
*/
1716
final class Configuration implements ConfigurationInterface
1817
{
18+
/**
19+
* @return TreeBuilder<'array'>
20+
*/
1921
public function getConfigTreeBuilder(): TreeBuilder
2022
{
21-
$tree = new TreeBuilder('fd_log_viewer');
22-
/** @var ArrayNodeDefinition $rootNode */
23+
$tree = new TreeBuilder('fd_log_viewer');
2324
$rootNode = $tree->getRootNode();
2425

2526
$rootNode
@@ -31,10 +32,12 @@ public function getConfigTreeBuilder(): TreeBuilder
3132
return $tree;
3233
}
3334

34-
private function configureLogFiles(): NodeDefinition
35+
/**
36+
* @return ArrayNodeDefinition<null>
37+
*/
38+
private function configureLogFiles(): ArrayNodeDefinition
3539
{
36-
$tree = new TreeBuilder('log_files');
37-
/** @var ArrayNodeDefinition $rootNode */
40+
$tree = new TreeBuilder('log_files');
3841
$rootNode = $tree->getRootNode();
3942

4043
return $rootNode
@@ -113,10 +116,12 @@ private function configureLogFiles(): NodeDefinition
113116
->end();
114117
}
115118

116-
private function configureHosts(): NodeDefinition
119+
/**
120+
* @return ArrayNodeDefinition<null>
121+
*/
122+
private function configureHosts(): ArrayNodeDefinition
117123
{
118-
$tree = new TreeBuilder('hosts');
119-
/** @var ArrayNodeDefinition $rootNode */
124+
$tree = new TreeBuilder('hosts');
120125
$rootNode = $tree->getRootNode();
121126

122127
return $rootNode

0 commit comments

Comments
 (0)