ci: no bundling (#1610)

Author: mshanemc

.github/workflows/onRelease.yml

@@ -29,11 +29,3 @@ jobs:
       githubTag: ${{ github.event.release.tag_name || inputs.tag }}
 
     secrets: inherit
-
-  publish-bundle:
-    if: ${{ success() && needs.getDistTag.outputs.tag == '' }}
-    uses: ./.github/workflows/releaseWithCoreBundle.yml
-    needs: [getDistTag, npm]
-    with:
-      branch: 'main'
-    secrets: inherit

.github/workflows/releaseWithCoreBundle.yml

@@ -16,19 +16,6 @@ jobs:
   windows-unit-tests:
     needs: linux-unit-tests
     uses: salesforcecli/github-workflows/.github/workflows/unitTestsWindows.yml@main
-  test-bundle:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        with:
-          node-version: lts/*
-          cache: yarn
-      - uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
-      - name: Build the project
-        run: yarn build
-      - name: check if bundling runs into failures
-        run: node scripts/testEsbuild.js
 
   nuts:
     needs: linux-unit-tests

.github/workflows/test.yml

@@ -1,5 +1,4 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-yarn lint && yarn pretty-quick --staged
-node ./scripts/scanTs.js
+yarn lint && yarn pretty-quick --staged

.github/workflows/testWithCoreBundle.yml

@@ -55,7 +55,6 @@
     "mocha": "^11.7.1",
     "mocha-junit-reporter": "^1.23.3",
     "mocha-snap": "^5.0.0",
-    "ts-morph": "^24.0.0",
     "ts-node": "^10.9.2",
     "ts-patch": "^3.3.0",
     "typescript": "^5.5.4"
@@ -141,6 +140,19 @@
       ],
       "output": []
     },
+    "test:bundle": {
+      "dependencies": [
+        "compile"
+      ],
+      "command": "node scripts/esbuild.config.mjs",
+      "files": [
+        "lib/src",
+        "scripts/esbuild.config.mjs"
+      ],
+      "output": [
+        "dist"
+      ]
+    },
     "test:compile": {
       "command": "tsc -p \"./test\" --pretty",
       "files": [
@@ -154,7 +166,8 @@
         "test:only",
         "test:compile",
         "test:registry-validation",
-        "test:snapshot"
+        "test:snapshot",
+        "test:bundle"
       ]
     },
     "test:registry-validation": {

.husky/pre-commit

@@ -3,27 +3,19 @@
  * sdr is bundled directly in salesforcedx-vscode
  * The file is only used to detect any potential risks to esbuild.
  **/
-const { build } = require('esbuild');
+import { build } from 'esbuild';
 
-const sharedConfig = {
+await build({
   bundle: true,
   format: 'cjs',
   platform: 'node',
-  external: [], // The allowlist of dependencies that are not bundle-able
   keepNames: true,
-  plugins: [],
   supported: {
     'dynamic-import': false,
   },
   logOverride: {
     'unsupported-dynamic-import': 'error',
   },
-};
-
-(async () => {
-  await build({
-    ...sharedConfig,
-    entryPoints: ['./lib/src/index.js'],
-    outdir: 'dist',
-  });
-})();
+  entryPoints: ['./lib/src/index.js'],
+  outdir: 'dist',
+});