Skip to content

Commit adb39cb

Browse files
committed
feat: feedback on RunRelevantTests implementation @W-20152151@
1 parent 7297c18 commit adb39cb

File tree

3 files changed

+1
-9
lines changed

3 files changed

+1
-9
lines changed

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
"@salesforce/kit": "^3.2.4",
3030
"@salesforce/ts-types": "^2.0.12",
3131
"@salesforce/types": "^1.5.0",
32-
"@types/semver": "^7.7.1",
3332
"fast-levenshtein": "^3.0.0",
3433
"fast-xml-parser": "^4.5.3",
3534
"got": "^11.8.6",
@@ -39,7 +38,6 @@
3938
"mime": "2.6.0",
4039
"minimatch": "^9.0.5",
4140
"proxy-agent": "^6.4.0",
42-
"semver": "^7.7.3",
4341
"yaml": "^2.8.1"
4442
},
4543
"devDependencies": {

src/client/metadataApiDeploy.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import { format } from 'node:util';
1818
import { isString } from '@salesforce/ts-types';
1919
import JSZip from 'jszip';
2020
import fs from 'graceful-fs';
21-
import semver from 'semver';
2221
import { Lifecycle } from '@salesforce/core/lifecycle';
2322
import { Messages } from '@salesforce/core/messages';
2423
import { SfError } from '@salesforce/core/sfError';
@@ -529,7 +528,7 @@ const buildFileResponsesFromComponentSet =
529528

530529
const validateOptions = (options: MetadataApiDeployOptions): void => {
531530
const runningRelevantTestsOnly = options.apiOptions?.testLevel === 'RunRelevantTests';
532-
const beforeApiV66 = options.apiVersion && semver.lt(semver.coerce(options.apiVersion)!, '66.0.0');
531+
const beforeApiV66 = options.apiVersion && Number(options.apiVersion) < 66.0;
533532
if (runningRelevantTestsOnly && beforeApiV66) {
534533
throw new SfError(
535534
messages.getMessage('error_invalid_test_level', ['RunRelevantTests', '66.0']),

yarn.lock

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1039,11 +1039,6 @@
10391039
resolved "https://registry.yarnpkg.com/@types/semver/-/semver-7.5.8.tgz#8268a8c57a3e4abd25c165ecd36237db7948a55e"
10401040
integrity sha512-I8EUhyrgfLrcTkzV3TSsGyl1tSuPrEDzr0yd5m90UgNxQkyDXULk3b6MlQqTCpZpNtWe1K0hzclnZkTcLBe2UQ==
10411041

1042-
"@types/semver@^7.7.1":
1043-
version "7.7.1"
1044-
resolved "https://registry.yarnpkg.com/@types/semver/-/semver-7.7.1.tgz#3ce3af1a5524ef327d2da9e4fd8b6d95c8d70528"
1045-
integrity sha512-FmgJfu+MOcQ370SD0ev7EI8TlCAfKYU+B4m5T3yXc1CiRN94g/SZPtsCkk506aUDtlMnFZvasDwHHUcZUEaYuA==
1046-
10471042
"@types/shelljs@^0.8.15":
10481043
version "0.8.15"
10491044
resolved "https://registry.yarnpkg.com/@types/shelljs/-/shelljs-0.8.15.tgz#22c6ab9dfe05cec57d8e6cb1a95ea173aee9fcac"

0 commit comments

Comments
 (0)