Skip to content

Commit 0127cb8

Browse files
committed
format on_enter_test.dart, update CHANGELOG.md
1 parent a38fbe1 commit 0127cb8

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

packages/go_router/CHANGELOG.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
1-
## NEXT
2-
3-
* Updates minimum supported SDK version to Flutter 3.32/Dart 3.8.
4-
51
## 17.0.1
62

73
- Fixes an issue where `onEnter` blocking causes navigation stack loss (stale state restoration).
4+
- Updates minimum supported SDK version to Flutter 3.32/Dart 3.8.
85

96
## 17.0.0
107

@@ -431,7 +428,7 @@
431428

432429
## 7.0.1
433430

434-
- Adds a workaround for the `dart fix --apply` issue, https://github.com/dart-lang/sdk/issues/52233.
431+
- Adds a workaround for the `dart fix --apply` issue, <https://github.com/dart-lang/sdk/issues/52233>.
435432

436433
## 7.0.0
437434

@@ -914,7 +911,7 @@
914911
## 2.2.8
915912

916913
- reformatted CHANGELOG file; lets see if pub.dev is still ok with it...
917-
- staged an in-progress doc site at https://docs.page/csells/go_router
914+
- staged an in-progress doc site at <https://docs.page/csells/go_router>
918915
- tightened up a test that was silently failing
919916
- fixed a bug that dropped parent params in sub-route redirects
920917

@@ -1247,4 +1244,3 @@
12471244
## 0.1.0
12481245

12491246
- squatting on the package name (I'm not too proud to admit it)
1250-

packages/go_router/test/on_enter_test.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1539,7 +1539,7 @@ void main() {
15391539

15401540
router = GoRouter(
15411541
initialLocation: '/home',
1542-
onEnter: (_, __, next, ___) =>
1542+
onEnter: (_, __, GoRouterState next, ___) =>
15431543
next.uri.path == '/blocked' ? const Block.stop() : const Allow(),
15441544
routes: <RouteBase>[
15451545
GoRoute(
@@ -1567,7 +1567,9 @@ void main() {
15671567
expect(find.text('Allowed'), findsOneWidget);
15681568

15691569
// 2. Pop (simulating system back / imperative pop)
1570-
final NavigatorState navigator = tester.state(find.byType(Navigator).last);
1570+
final NavigatorState navigator = tester.state(
1571+
find.byType(Navigator).last,
1572+
);
15711573
navigator.pop();
15721574
await tester.pumpAndSettle();
15731575
expect(find.text('Home'), findsOneWidget);

0 commit comments

Comments
 (0)