Skip to content

feat(api): make country and language models read-only #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

feat(api): make country and language models read-only #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions lib/src/registry/model_registry.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,9 @@ final modelRegistry = <String, ModelConfig<dynamic>>{
'country': ModelConfig<Country>(
fromJson: Country.fromJson,
getId: (c) => c.id,
// Countries: Admin-owned, read allowed by standard/guest users
// Countries: Static data, read-only for all authenticated users.
// Modification is not allowed via the API as this is real-world data
// managed by database seeding.
getCollectionPermission: const ModelActionPermission(
type: RequiredPermissionType.specificPermission,
permission: Permissions.countryRead,
Expand All @@ -197,14 +199,32 @@ final modelRegistry = <String, ModelConfig<dynamic>>{
type: RequiredPermissionType.specificPermission,
permission: Permissions.countryRead,
),
postPermission: const ModelActionPermission(type: RequiredPermissionType.unsupported),
putPermission: const ModelActionPermission(type: RequiredPermissionType.unsupported),
deletePermission: const ModelActionPermission(type: RequiredPermissionType.unsupported),
),
'language': ModelConfig<Language>(
fromJson: Language.fromJson,
getId: (l) => l.id,
// Languages: Static data, read-only for all authenticated users.
// Modification is not allowed via the API as this is real-world data
// managed by database seeding.
getCollectionPermission: const ModelActionPermission(
type: RequiredPermissionType.specificPermission,
permission: Permissions.languageRead,
),
getItemPermission: const ModelActionPermission(
type: RequiredPermissionType.specificPermission,
permission: Permissions.languageRead,
),
postPermission: const ModelActionPermission(
type: RequiredPermissionType.adminOnly,
type: RequiredPermissionType.unsupported,
),
putPermission: const ModelActionPermission(
type: RequiredPermissionType.adminOnly,
type: RequiredPermissionType.unsupported,
),
deletePermission: const ModelActionPermission(
type: RequiredPermissionType.adminOnly,
type: RequiredPermissionType.unsupported,
),
),
'user': ModelConfig<User>(
Expand Down
20 changes: 20 additions & 0 deletions routes/api/v1/data/[id]/index.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ Future<Response> _handleGet(
case 'country':
final repo = context.read<DataRepository<Country>>();
item = await repo.read(id: id, userId: userIdForRepoCall);
case 'language':
final repo = context.read<DataRepository<Language>>();
item = await repo.read(id: id, userId: userIdForRepoCall);
case 'user': // Handle User model specifically if needed, or rely on generic
final repo = context.read<DataRepository<User>>();
item = await repo.read(id: id, userId: userIdForRepoCall);
Expand Down Expand Up @@ -309,6 +312,15 @@ Future<Response> _handlePut(
userId: userIdForRepoCall,
);
}
case 'language':
{
final repo = context.read<DataRepository<Language>>();
updatedItem = await repo.update(
id: id,
item: itemToUpdate as Language,
userId: userIdForRepoCall,
);
}
case 'user':
{
final repo = context.read<DataRepository<User>>();
Expand Down Expand Up @@ -454,6 +466,9 @@ Future<Response> _handleDelete(
case 'country':
final repo = context.read<DataRepository<Country>>();
itemToDelete = await repo.read(id: id, userId: userIdForRepoCall);
case 'language':
final repo = context.read<DataRepository<Language>>();
itemToDelete = await repo.read(id: id, userId: userIdForRepoCall);
case 'user':
final repo = context.read<DataRepository<User>>();
itemToDelete = await repo.read(id: id, userId: userIdForRepoCall);
Expand Down Expand Up @@ -517,6 +532,11 @@ Future<Response> _handleDelete(
id: id,
userId: userIdForRepoCall,
);
case 'language':
await context.read<DataRepository<Language>>().delete(
id: id,
userId: userIdForRepoCall,
);
case 'user':
await context.read<DataRepository<User>>().delete(
id: id,
Expand Down
Loading