Skip to content

Commit c0c41c0

Browse files
authored
Merge pull request #84 from flutter-news-app-full-source-code/refactor/sync-data-with-the-new-app-aggregator-identity-pivot
Refactor/sync data with the new app aggregator identity pivot
2 parents 643aa38 + 70c7c3a commit c0c41c0

File tree

88 files changed

+1924
-1829
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

88 files changed

+1924
-1829
lines changed

lib/src/enums/enums.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ export 'dashboard_user_role.dart';
1212
export 'device_platform.dart';
1313
export 'feed_decorator_category.dart';
1414
export 'feed_decorator_type.dart';
15-
export 'headline_density.dart';
16-
export 'headline_image_style.dart';
17-
export 'in_article_ad_slot_type.dart';
15+
export 'feed_item_click_behavior.dart';
16+
export 'feed_item_density.dart';
17+
export 'feed_item_image_style.dart';
1818
export 'push_notification_provider.dart';
1919
export 'push_notification_subscription_delivery_type.dart';
2020
export 'sort_order.dart';
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
import 'package:json_annotation/json_annotation.dart';
2+
3+
/// {@template feed_item_click_behavior}
4+
/// Defines how a feed item click should be handled.
5+
/// {@endtemplate}
6+
@JsonEnum()
7+
enum FeedItemClickBehavior {
8+
/// Adhere to the behavior defined by the admin in the remote config.
9+
@JsonValue('default')
10+
defaultBehavior,
11+
12+
@JsonValue('internalNavigation')
13+
internalNavigation,
14+
15+
@JsonValue('externalNavigation')
16+
externalNavigation,
17+
}

lib/src/enums/headline_density.dart renamed to lib/src/enums/feed_item_density.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
/// Defines how densely headline information should be presented.
2-
enum HeadlineDensity {
1+
/// Defines how densely feed item information should be presented.
2+
enum FeedItemDensity {
33
/// Minimal spacing, smaller title font.
44
compact,
55

lib/src/enums/headline_image_style.dart renamed to lib/src/enums/feed_item_image_style.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
/// Defines how images should be displayed in the headline feed.
2-
enum HeadlineImageStyle {
1+
/// Defines how a feed item image should be displayed.
2+
enum FeedItemImageStyle {
33
/// No image shown in the feed.
44
hidden,
55

lib/src/enums/in_article_ad_slot_type.dart

Lines changed: 0 additions & 10 deletions
This file was deleted.

lib/src/fixtures/user_app_settings.dart renamed to lib/src/fixtures/app_settings.dart

Lines changed: 22 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import 'package:core/core.dart';
22

3-
/// User App Settings Demo Data
4-
final List<UserAppSettings> userAppSettingsFixturesData = [
5-
UserAppSettings(
3+
/// App Settings Demo Data
4+
final List<AppSettings> appSettingsFixturesData = [
5+
AppSettings(
66
id: kAdminUserId,
77
displaySettings: const DisplaySettings(
88
baseTheme: AppBaseTheme.system,
@@ -20,14 +20,13 @@ final List<UserAppSettings> userAppSettingsFixturesData = [
2020
updatedAt: DateTime.now(),
2121
status: ContentStatus.active,
2222
),
23-
feedPreferences: const FeedDisplayPreferences(
24-
headlineDensity: HeadlineDensity.standard,
25-
headlineImageStyle: HeadlineImageStyle.smallThumbnail,
26-
showSourceInHeadlineFeed: true,
27-
showPublishDateInHeadlineFeed: true,
23+
feedSettings: const FeedSettings(
24+
feedItemDensity: FeedItemDensity.standard,
25+
feedItemImageStyle: FeedItemImageStyle.smallThumbnail,
26+
feedItemClickBehavior: FeedItemClickBehavior.defaultBehavior,
2827
),
2928
),
30-
UserAppSettings(
29+
AppSettings(
3130
id: kUser1Id,
3231
displaySettings: const DisplaySettings(
3332
baseTheme: AppBaseTheme.system,
@@ -45,14 +44,13 @@ final List<UserAppSettings> userAppSettingsFixturesData = [
4544
updatedAt: DateTime.now(),
4645
status: ContentStatus.active,
4746
),
48-
feedPreferences: const FeedDisplayPreferences(
49-
headlineDensity: HeadlineDensity.standard,
50-
headlineImageStyle: HeadlineImageStyle.smallThumbnail,
51-
showSourceInHeadlineFeed: true,
52-
showPublishDateInHeadlineFeed: true,
47+
feedSettings: const FeedSettings(
48+
feedItemDensity: FeedItemDensity.standard,
49+
feedItemImageStyle: FeedItemImageStyle.smallThumbnail,
50+
feedItemClickBehavior: FeedItemClickBehavior.defaultBehavior,
5351
),
5452
),
55-
UserAppSettings(
53+
AppSettings(
5654
id: kUser2Id,
5755
displaySettings: const DisplaySettings(
5856
baseTheme: AppBaseTheme.dark,
@@ -70,17 +68,16 @@ final List<UserAppSettings> userAppSettingsFixturesData = [
7068
updatedAt: DateTime.now(),
7169
status: ContentStatus.active,
7270
),
73-
feedPreferences: const FeedDisplayPreferences(
74-
headlineDensity: HeadlineDensity.compact,
75-
headlineImageStyle: HeadlineImageStyle.largeThumbnail,
76-
showSourceInHeadlineFeed: true,
77-
showPublishDateInHeadlineFeed: true,
71+
feedSettings: const FeedSettings(
72+
feedItemDensity: FeedItemDensity.compact,
73+
feedItemImageStyle: FeedItemImageStyle.largeThumbnail,
74+
feedItemClickBehavior: FeedItemClickBehavior.defaultBehavior,
7875
),
7976
),
8077
// Add settings for users 3-10, copying the admin's settings for simplicity
8178
...List.generate(
8279
8,
83-
(index) => UserAppSettings(
80+
(index) => AppSettings(
8481
id: [
8582
kUser3Id,
8683
kUser4Id,
@@ -107,11 +104,10 @@ final List<UserAppSettings> userAppSettingsFixturesData = [
107104
updatedAt: DateTime.now(),
108105
status: ContentStatus.active,
109106
),
110-
feedPreferences: const FeedDisplayPreferences(
111-
headlineDensity: HeadlineDensity.standard,
112-
headlineImageStyle: HeadlineImageStyle.smallThumbnail,
113-
showSourceInHeadlineFeed: true,
114-
showPublishDateInHeadlineFeed: true,
107+
feedSettings: const FeedSettings(
108+
feedItemDensity: FeedItemDensity.standard,
109+
feedItemImageStyle: FeedItemImageStyle.smallThumbnail,
110+
feedItemClickBehavior: FeedItemClickBehavior.defaultBehavior,
115111
),
116112
),
117113
),

lib/src/fixtures/fixtures.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
export 'app_settings.dart';
12
export 'countries.dart';
23
export 'dashboard_summary.dart';
34
export 'fixture_ids.dart';
@@ -9,6 +10,5 @@ export 'saved_headline_filters.dart';
910
export 'saved_source_filters.dart';
1011
export 'sources.dart';
1112
export 'topics.dart';
12-
export 'user_app_settings.dart';
1313
export 'user_content_preferences.dart';
1414
export 'users.dart';

0 commit comments

Comments
 (0)