refactor(user): use Role model for user role

- Updated User model to use Role
- Updated tests to use Role model

Author: fulleni

lib/src/models/user.dart

@@ -1,4 +1,5 @@
 import 'package:equatable/equatable.dart';
+import 'package:ht_shared/src/models/role.dart';
 import 'package:json_annotation/json_annotation.dart';
 
 part 'user.g.dart';
@@ -27,8 +28,8 @@ class User extends Equatable {
   /// This will be `null` for users who haven't associated an email yet.
   final String? email;
 
-  /// The role of the user (e.g., 'admin', 'standard_user', 'guest_user').
-  final String role;
+  /// The role of the user.
+  final Role role;
 
   /// Converts this User instance to JSON data.
   Map<String, dynamic> toJson() => _$UserToJson(this);

lib/src/models/user.g.dart

@@ -7,7 +7,7 @@ void main() {
     const testUser = User(
       id: 'user-123',
       email: 'test@example.com',
-      role: 'standard_user',
+      role: Role(name: 'standard_user'),
     );
     const testToken = 'sample-jwt-token';
 
@@ -94,7 +94,7 @@ void main() {
         const updatedUser = User(
           id: 'user-456',
           email: 'updated@example.com',
-          role: 'guest_user',
+          role: Role(name: 'guest_user'), // Use Role object
         );
         final copiedResponse = authSuccessResponse.copyWith(user: updatedUser);
 
@@ -115,7 +115,7 @@ void main() {
       });
 
       test('should create a copy with both user and token updated', () {
-        const updatedUser = User(id: 'user-789', role: 'guest_user');
+        const updatedUser = User(id: 'user-789', role: Role(name: 'guest_user')); // Use Role object
         const updatedToken = 'another-token-xyz';
         final copiedResponse = authSuccessResponse.copyWith(
           user: updatedUser,
@@ -137,7 +137,7 @@ void main() {
       });
 
       test('should not equate instances with different users', () {
-        const differentUser = User(id: 'diff-user', role: 'admin');
+        const differentUser = User(id: 'diff-user', role: Role(name: 'admin')); // Use Role object
         const response1 = AuthSuccessResponse(user: testUser, token: testToken);
         const response2 = AuthSuccessResponse(
           user: differentUser,

test/src/models/auth_success_response_test.dart

@@ -1,74 +1,78 @@
+import 'package:ht_shared/src/models/role.dart';
 import 'package:ht_shared/src/models/user.dart';
 import 'package:test/test.dart';
 
 void main() {
   group('User Model', () {
     const id = 'test-id';
     const email = 'test@example.com';
+    const standardRole = Role(name: 'standard_user');
+    const guestRole = Role(name: 'guest_user');
+    const adminRole = Role(name: 'admin');
 
     test('supports value equality', () {
       expect(
-        const User(id: id, email: email, role: 'standard_user'),
-        equals(const User(id: id, email: email, role: 'standard_user')),
+        const User(id: id, email: email, role: standardRole),
+        equals(const User(id: id, email: email, role: standardRole)),
       );
       expect(
-        const User(id: id, email: email, role: 'standard_user'),
+        const User(id: id, email: email, role: standardRole),
         isNot(
           equals(
-            const User(id: 'other-id', email: email, role: 'standard_user'),
+            const User(id: 'other-id', email: email, role: standardRole),
           ),
         ),
       );
       expect(
-        const User(id: id, email: email, role: 'standard_user'),
+        const User(id: id, email: email, role: standardRole),
         isNot(
           equals(
             const User(
               id: id,
               email: 'other@example.com',
-              role: 'standard_user',
+              role: standardRole,
             ),
           ),
         ),
       );
       expect(
-        const User(id: id, email: email, role: 'standard_user'),
-        isNot(equals(const User(id: id, email: email, role: 'guest_user'))),
+        const User(id: id, email: email, role: standardRole),
+        isNot(equals(const User(id: id, email: email, role: guestRole))),
       );
       expect(
-        const User(id: id, email: email, role: 'standard_user'),
-        isNot(equals(const User(id: id, email: email, role: 'admin'))),
+        const User(id: id, email: email, role: standardRole),
+        isNot(equals(const User(id: id, email: email, role: adminRole))),
       );
     });
 
     test('has correct toString', () {
       expect(
-        const User(id: id, email: email, role: 'standard_user').toString(),
-        equals('User(id: $id, email: $email, role: standard_user)'),
+        const User(id: id, email: email, role: standardRole).toString(),
+        equals('User(id: $id, email: $email, role: ${standardRole.toString()})'),
       );
       expect(
-        const User(id: id, role: 'guest_user').toString(),
-        equals('User(id: $id, email: null, role: guest_user)'),
+        const User(id: id, role: guestRole).toString(),
+        equals('User(id: $id, email: null, role: ${guestRole.toString()})'),
       );
       expect(
-        const User(id: id, role: 'admin').toString(),
-        equals('User(id: $id, email: null, role: admin)'),
+        const User(id: id, role: adminRole).toString(),
+        equals('User(id: $id, email: null, role: ${adminRole.toString()})'),
       );
     });
 
     // Basic test for JSON serialization - assumes build_runner generated correctly
     test('can be serialized and deserialized', () {
-      const user = User(id: id, email: email, role: 'standard_user');
+      const user = User(id: id, email: email, role: standardRole);
       final json = user.toJson();
       final deserializedUser = User.fromJson(json);
       expect(deserializedUser, equals(user));
 
-      const anonUser = User(id: id, role: 'guest_user');
+      const anonUser = User(id: id, role: guestRole);
       final anonJson = anonUser.toJson();
       final deserializedAnonUser = User.fromJson(anonJson);
       expect(deserializedAnonUser, equals(anonUser));
 
-      const adminUser = User(id: id, email: email, role: 'admin');
+      const adminUser = User(id: id, email: email, role: adminRole);
       final adminJson = adminUser.toJson();
       final deserializedAdminUser = User.fromJson(adminJson);
       expect(deserializedAdminUser, equals(adminUser));