Skip to content

Commit fdfff95

Browse files
Wrapped --codesign-identity & --add-binary for flet pack (#1789)
Wrapping --codesign-identity & --add-binary for flet pack allows end to end code signing on macOS. This avoids having to use pyinstaller directly which leads to app naming issues.
1 parent 6155b3a commit fdfff95

File tree

1 file changed

+18
-0
lines changed
  • sdk/python/packages/flet/src/flet/cli/commands

1 file changed

+18
-0
lines changed

sdk/python/packages/flet/src/flet/cli/commands/pack.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,13 @@ def add_arguments(self, parser: argparse.ArgumentParser) -> None:
4848
nargs="*",
4949
help="additional non-binary files or folders to be added to the executable",
5050
)
51+
parser.add_argument(
52+
"--add-binary",
53+
dest="add_binary",
54+
action="append",
55+
nargs="*",
56+
help="additional binary files to be added to the executable",
57+
)
5158
parser.add_argument(
5259
"--hidden-import",
5360
dest="hidden_import",
@@ -85,6 +92,11 @@ def add_arguments(self, parser: argparse.ArgumentParser) -> None:
8592
dest="copyright",
8693
help="executable (Windows) or bundle (macOS) copyright",
8794
)
95+
parser.add_argument(
96+
"--codesign-identity",
97+
dest="codesign_identity",
98+
help="Code signing identity (macOS)",
99+
)
88100
parser.add_argument(
89101
"--bundle-id",
90102
dest="bundle_id",
@@ -117,10 +129,16 @@ def handle(self, options: argparse.Namespace) -> None:
117129
for add_data_arr in options.add_data:
118130
for add_data_item in add_data_arr:
119131
pyi_args.extend(["--add-data", add_data_item])
132+
if options.add_binary:
133+
for add_binary_arr in options.add_binary:
134+
for add_binary_item in add_binary_arr:
135+
pyi_args.extend(["--add-binary", add_binary_item])
120136
if options.hidden_import:
121137
for hidden_import_arr in options.hidden_import:
122138
for hidden_import_item in hidden_import_arr:
123139
pyi_args.extend(["--hidden-import", hidden_import_item])
140+
if options.codesign_identity:
141+
pyi_args.extend(["--codesign-identity", options.codesign_identity])
124142
if options.bundle_id:
125143
pyi_args.extend(["--osx-bundle-identifier", options.bundle_id])
126144
if options.onedir:

0 commit comments

Comments
 (0)