[Deploy] testing mobile UI stuff #5523
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On small screens, the top bar was overflowing to the right, making the entire document scrollable, which lead to unintended dark blue areas appearing. As a quick fix, make the bar itself scrollable. Also put a minimum size on the profile name button and make sure its edit icon isn't squished. And prevent scrolling the contents of .Details, for example from a single overflowing pixel.
Small fix for the following issue: 1. Open the profiler UI on a small screen. 2. Select the call tree tab (which has a sidebar toggle button), and close the sidebar if its open. 3. Scroll the tab bar to the right so that you can see the Network tab. 4. Select the Marker Chart tab. Before this fix, step 4 would remove the sidebar button and make the tapped tab change positions, causing an odd visual jump.
mstange
force-pushed
the
push-qnkssuxkvpxr
branch
2 times, most recently
from
45e7a0f to
80e4d6f
Compare
mstange
force-pushed
the
push-qnkssuxkvpxr
branch
from
80e4d6f to
e56460a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.