[WIP] Migrate from CirleCI to GitHub Actions #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Huh weird, it didn't happen in the profiler repo, but I had to create a PR from this repo and not from my fork to be able to trigger the CI. Internet mentions that this is a security feature, but it should've work since I'm a maintainer. |
canova
force-pushed
the
github-actions-migration
branch
from
9936d9d to
6b0b15b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the attempt to migrate from CircleCI to GitHub Actions.
The most important thing is the docker publish flow. We should be very careful not to break it. One change I made was to change the image version tag.
Previously it was
IMAGE_VERSION_TAG="0.0.${CIRCLE_BUILD_NUM}". but I've bumped the tag toIMAGE_VERSION_TAG="0.1.${{ github.run_number }}"to make sure they don't overlap.It needs more testing related to how we generate docker images.