From d7e966ad4dba63b6f664b8717d767776de3019a3 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 15 Dec 2025 10:54:00 -0500 Subject: [PATCH 01/36] fix: Address flaky dispatch --- Crashlytics/Crashlytics/Models/FIRCLSSettings.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m index 758772e5b8d..54d11a82e14 100644 --- a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m +++ b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m @@ -190,7 +190,7 @@ - (NSDictionary *)loadCacheKey { - (void)deleteCachedSettings { __weak FIRCLSSettings *weakSelf = self; - dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{ +// dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{ __strong FIRCLSSettings *strongSelf = weakSelf; if ([strongSelf.fileManager fileExistsAtPath:strongSelf.fileManager.settingsFilePath]) { [strongSelf.fileManager removeItemAtPath:strongSelf.fileManager.settingsFilePath]; @@ -198,7 +198,7 @@ - (void)deleteCachedSettings { if ([strongSelf.fileManager fileExistsAtPath:strongSelf.fileManager.settingsCacheKeyPath]) { [strongSelf.fileManager removeItemAtPath:strongSelf.fileManager.settingsCacheKeyPath]; } - }); +// }); @synchronized(self) { self.isCacheKeyExpired = YES; From a4ec6e536c27611b036c5ae1f4bccefa40b27d3e Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 15 Dec 2025 13:57:43 -0500 Subject: [PATCH 02/36] Wrap it --- Crashlytics/Crashlytics/Models/FIRCLSSettings.m | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m index 54d11a82e14..96f73e1cb86 100644 --- a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m +++ b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m @@ -190,7 +190,9 @@ - (NSDictionary *)loadCacheKey { - (void)deleteCachedSettings { __weak FIRCLSSettings *weakSelf = self; -// dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{ +#if FIREBASE_CRASHYLTICS_TESTING + dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{ +#endif __strong FIRCLSSettings *strongSelf = weakSelf; if ([strongSelf.fileManager fileExistsAtPath:strongSelf.fileManager.settingsFilePath]) { [strongSelf.fileManager removeItemAtPath:strongSelf.fileManager.settingsFilePath]; @@ -198,7 +200,9 @@ - (void)deleteCachedSettings { if ([strongSelf.fileManager fileExistsAtPath:strongSelf.fileManager.settingsCacheKeyPath]) { [strongSelf.fileManager removeItemAtPath:strongSelf.fileManager.settingsCacheKeyPath]; } -// }); +#if FIREBASE_CRASHYLTICS_TESTING + }); +#endif @synchronized(self) { self.isCacheKeyExpired = YES; From ab1c16a0472a551ac1d69e70cace875264e748a7 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 15 Dec 2025 13:58:45 -0500 Subject: [PATCH 03/36] add error checks. will revert --- Crashlytics/Crashlytics/Models/FIRCLSSettings.m | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m index 96f73e1cb86..331119655ef 100644 --- a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m +++ b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m @@ -191,6 +191,7 @@ - (NSDictionary *)loadCacheKey { - (void)deleteCachedSettings { __weak FIRCLSSettings *weakSelf = self; #if FIREBASE_CRASHYLTICS_TESTING +#error "Mango: Check one." dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{ #endif __strong FIRCLSSettings *strongSelf = weakSelf; @@ -201,6 +202,7 @@ - (void)deleteCachedSettings { [strongSelf.fileManager removeItemAtPath:strongSelf.fileManager.settingsCacheKeyPath]; } #if FIREBASE_CRASHYLTICS_TESTING +#error "Mango: Check two." }); #endif From a2bac893351519931b4c0f917091cfcd70d0bd9f Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 15 Dec 2025 14:01:23 -0500 Subject: [PATCH 04/36] fix logic --- Crashlytics/Crashlytics/Models/FIRCLSSettings.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m index 331119655ef..22b0e43356b 100644 --- a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m +++ b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m @@ -190,7 +190,7 @@ - (NSDictionary *)loadCacheKey { - (void)deleteCachedSettings { __weak FIRCLSSettings *weakSelf = self; -#if FIREBASE_CRASHYLTICS_TESTING +#ifndef FIREBASE_CRASHYLTICS_TESTING #error "Mango: Check one." dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{ #endif @@ -201,7 +201,7 @@ - (void)deleteCachedSettings { if ([strongSelf.fileManager fileExistsAtPath:strongSelf.fileManager.settingsCacheKeyPath]) { [strongSelf.fileManager removeItemAtPath:strongSelf.fileManager.settingsCacheKeyPath]; } -#if FIREBASE_CRASHYLTICS_TESTING +#ifndef FIREBASE_CRASHYLTICS_TESTING #error "Mango: Check two." }); #endif From 49fcbc67b364359709ed60091e5b9bd62a9b7b19 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 15 Dec 2025 14:06:33 -0500 Subject: [PATCH 05/36] pass --- .github/workflows/common.yml | 8 ++++++++ .github/workflows/crashlytics.yml | 1 + scripts/build.sh | 5 +++++ 3 files changed, 14 insertions(+) diff --git a/.github/workflows/common.yml b/.github/workflows/common.yml index 4af29b0f68b..56d73084dff 100644 --- a/.github/workflows/common.yml +++ b/.github/workflows/common.yml @@ -52,6 +52,12 @@ on: required: false default: "" + # Additional flags to pass to xcodebuild. + xcodebuild_flags: + type: string + required: false + default: "" + outputs: cache_key: description: "The cache key for the Swift package resolution." @@ -114,6 +120,8 @@ jobs: run: scripts/setup_spm_tests.sh - uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3 if: contains(join(inputs.platforms), matrix.platform) || matrix.os == 'macos-14' + env: + XCODEBUILD_FLAGS: ${{ inputs.xcodebuild_flags }} with: timeout_minutes: 15 max_attempts: 3 diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index 3969c1eb223..7755185f3a1 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -30,6 +30,7 @@ jobs: uses: ./.github/workflows/common.yml with: target: FirebaseCrashlyticsUnit + xcodebuild_flags: "GCC_PREPROCESSOR_DEFINITIONS='$(inherited) FIREBASE_CRASHYLTICS_TESTING=1'" catalyst: uses: ./.github/workflows/common_catalyst.yml diff --git a/scripts/build.sh b/scripts/build.sh index 20284c8bcfb..90394d6b934 100755 --- a/scripts/build.sh +++ b/scripts/build.sh @@ -255,6 +255,11 @@ xcb_flags+=( COMPILER_INDEX_STORE_ENABLE=NO ) +if [[ -n "${XCODEBUILD_FLAGS:-}" ]]; then + echo "Appending XCODEBUILD_FLAGS: ${XCODEBUILD_FLAGS}" + xcb_flags+=("${XCODEBUILD_FLAGS}") +fi + source scripts/buildcache.sh xcb_flags=("${xcb_flags[@]}" "${buildcache_xcb_flags[@]}") From 18dce0ef174a45e1645539344967e8ebdd7ef49c Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 15:44:12 -0500 Subject: [PATCH 06/36] Apply suggestion from @ncooke3 --- .github/workflows/crashlytics.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index 7755185f3a1..02a08e4b117 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -30,7 +30,7 @@ jobs: uses: ./.github/workflows/common.yml with: target: FirebaseCrashlyticsUnit - xcodebuild_flags: "GCC_PREPROCESSOR_DEFINITIONS='$(inherited) FIREBASE_CRASHYLTICS_TESTING=1'" + xcodebuild_flags: "GCC_PREPROCESSOR_DEFINITIONS='$GCC_PREPROCESSOR_DEFINITIONS FIREBASE_CRASHYLTICS_TESTING=1'" catalyst: uses: ./.github/workflows/common_catalyst.yml From 8d7e4b4161c1dbbc4e94575951956f54211ca2fe Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 15 Dec 2025 16:46:21 -0500 Subject: [PATCH 07/36] fix --- scripts/build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/build.sh b/scripts/build.sh index bc8a797b4df..360e0493f6a 100755 --- a/scripts/build.sh +++ b/scripts/build.sh @@ -258,6 +258,7 @@ xcb_flags+=( if [[ -n "${XCODEBUILD_FLAGS:-}" ]]; then echo "Appending XCODEBUILD_FLAGS: ${XCODEBUILD_FLAGS}" xcb_flags+=("${XCODEBUILD_FLAGS}") +fi # If running in Gemini CLI, pass -quiet to xcodebuild. # This reduces chance of exceeding the request token count. From 2a32ccc6127ff7ecb7daa37ca5ce947674198318 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:19:30 -0500 Subject: [PATCH 08/36] Update .github/workflows/common.yml --- .github/workflows/common.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/common.yml b/.github/workflows/common.yml index 56d73084dff..232782946ca 100644 --- a/.github/workflows/common.yml +++ b/.github/workflows/common.yml @@ -121,7 +121,7 @@ jobs: - uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3 if: contains(join(inputs.platforms), matrix.platform) || matrix.os == 'macos-14' env: - XCODEBUILD_FLAGS: ${{ inputs.xcodebuild_flags }} + is_nightly: ${{ inputs.is_nightly }} with: timeout_minutes: 15 max_attempts: 3 From 226f1be83fec4a1cc599ca2a34ba6fadd4872434 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:19:41 -0500 Subject: [PATCH 09/36] Update .github/workflows/common.yml --- .github/workflows/common.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/common.yml b/.github/workflows/common.yml index 232782946ca..59f95b8837a 100644 --- a/.github/workflows/common.yml +++ b/.github/workflows/common.yml @@ -52,11 +52,11 @@ on: required: false default: "" - # Additional flags to pass to xcodebuild. - xcodebuild_flags: - type: string + # Whether the job is scheduled. Defaults to false. + is_nightly: + type: boolean required: false - default: "" + default: false outputs: cache_key: From 47842c39e2e10dacf19899ef59cd35a42e8bef13 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:19:48 -0500 Subject: [PATCH 10/36] Update .github/workflows/crashlytics.yml --- .github/workflows/crashlytics.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index 02a08e4b117..4f63e2ba3a6 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -30,7 +30,7 @@ jobs: uses: ./.github/workflows/common.yml with: target: FirebaseCrashlyticsUnit - xcodebuild_flags: "GCC_PREPROCESSOR_DEFINITIONS='$GCC_PREPROCESSOR_DEFINITIONS FIREBASE_CRASHYLTICS_TESTING=1'" + is_nightly: github.event_name == 'schedule' catalyst: uses: ./.github/workflows/common_catalyst.yml From 540d7dfe7ad07dd73c5d31668d4dd85ff61ece28 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:19:54 -0500 Subject: [PATCH 11/36] Update Crashlytics/Crashlytics/Models/FIRCLSSettings.m --- Crashlytics/Crashlytics/Models/FIRCLSSettings.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m index 22b0e43356b..165cb0a44da 100644 --- a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m +++ b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m @@ -190,7 +190,7 @@ - (NSDictionary *)loadCacheKey { - (void)deleteCachedSettings { __weak FIRCLSSettings *weakSelf = self; -#ifndef FIREBASE_CRASHYLTICS_TESTING +#ifndef FIREBASE_IS_NIGHTLY_TESTING #error "Mango: Check one." dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{ #endif From f3c0fc15683b78685e979b2cfc97a6e814b1c17d Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:22:06 -0500 Subject: [PATCH 12/36] Update Crashlytics/Crashlytics/Models/FIRCLSSettings.m --- Crashlytics/Crashlytics/Models/FIRCLSSettings.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m index 165cb0a44da..bf752cecfae 100644 --- a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m +++ b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m @@ -201,7 +201,7 @@ - (void)deleteCachedSettings { if ([strongSelf.fileManager fileExistsAtPath:strongSelf.fileManager.settingsCacheKeyPath]) { [strongSelf.fileManager removeItemAtPath:strongSelf.fileManager.settingsCacheKeyPath]; } -#ifndef FIREBASE_CRASHYLTICS_TESTING +#ifndef FIREBASE_IS_NIGHTLY_TESTING #error "Mango: Check two." }); #endif From b88fc765ed36aa4604acaf7f33f1bde7269fda12 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:22:14 -0500 Subject: [PATCH 13/36] Update scripts/build.sh --- scripts/build.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/scripts/build.sh b/scripts/build.sh index 360e0493f6a..11996d6ad45 100755 --- a/scripts/build.sh +++ b/scripts/build.sh @@ -255,11 +255,6 @@ xcb_flags+=( COMPILER_INDEX_STORE_ENABLE=NO ) -if [[ -n "${XCODEBUILD_FLAGS:-}" ]]; then - echo "Appending XCODEBUILD_FLAGS: ${XCODEBUILD_FLAGS}" - xcb_flags+=("${XCODEBUILD_FLAGS}") -fi - # If running in Gemini CLI, pass -quiet to xcodebuild. # This reduces chance of exceeding the request token count. if [[ -n "${GEMINI_CLI:-}" ]]; then From b8b0871d0b8d350c583b8a0f9c7373044adcf5d0 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:24:50 -0500 Subject: [PATCH 14/36] wire up package.swift --- Package.swift | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Package.swift b/Package.swift index 4e2502a8586..db9b2ccc74f 100644 --- a/Package.swift +++ b/Package.swift @@ -636,6 +636,10 @@ let package = Package( ], cSettings: [ .headerSearchPath("../.."), + .define( + "FIREBASE_IS_NIGHTLY_TESTING", + to: Context.environment["FIREBASE_IS_NIGHTLY_TESTING", default: false] + ), .define("DISPLAY_VERSION", to: firebaseVersion), .define("CLS_SDK_NAME", to: "Crashlytics iOS SDK", .when(platforms: [.iOS])), .define( From 005687b245baa769a99da2dac09cbe00c0600cde Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:27:02 -0500 Subject: [PATCH 15/36] done --- .github/workflows/common.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/common.yml b/.github/workflows/common.yml index 59f95b8837a..de7d6f0c086 100644 --- a/.github/workflows/common.yml +++ b/.github/workflows/common.yml @@ -121,7 +121,7 @@ jobs: - uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3 if: contains(join(inputs.platforms), matrix.platform) || matrix.os == 'macos-14' env: - is_nightly: ${{ inputs.is_nightly }} + FIREBASE_IS_NIGHTLY_TESTING: ${{ inputs.is_nightly && '1' || '' }} with: timeout_minutes: 15 max_attempts: 3 From 67e327a5736047d6d1da1fad4ad7d9a5a9b72b94 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:30:58 -0500 Subject: [PATCH 16/36] Apply suggestion from @ncooke3 --- Package.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Package.swift b/Package.swift index db9b2ccc74f..c21cfc42eee 100644 --- a/Package.swift +++ b/Package.swift @@ -638,7 +638,7 @@ let package = Package( .headerSearchPath("../.."), .define( "FIREBASE_IS_NIGHTLY_TESTING", - to: Context.environment["FIREBASE_IS_NIGHTLY_TESTING", default: false] + to: Context.environment["FIREBASE_IS_NIGHTLY_TESTING", default: ""] ), .define("DISPLAY_VERSION", to: firebaseVersion), .define("CLS_SDK_NAME", to: "Crashlytics iOS SDK", .when(platforms: [.iOS])), From 440517686dfb1bf486674b3c98713c0b5ea72826 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:42:10 -0500 Subject: [PATCH 17/36] Apply suggestion from @ncooke3 --- Crashlytics/Crashlytics/Models/FIRCLSSettings.m | 1 - 1 file changed, 1 deletion(-) diff --git a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m index bf752cecfae..026896ca490 100644 --- a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m +++ b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m @@ -202,7 +202,6 @@ - (void)deleteCachedSettings { [strongSelf.fileManager removeItemAtPath:strongSelf.fileManager.settingsCacheKeyPath]; } #ifndef FIREBASE_IS_NIGHTLY_TESTING -#error "Mango: Check two." }); #endif From 62ceb78252fe047a4eaed2d780dcaa6504042c72 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:42:18 -0500 Subject: [PATCH 18/36] Apply suggestion from @ncooke3 --- Crashlytics/Crashlytics/Models/FIRCLSSettings.m | 1 - 1 file changed, 1 deletion(-) diff --git a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m index 026896ca490..80c70a48953 100644 --- a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m +++ b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m @@ -191,7 +191,6 @@ - (NSDictionary *)loadCacheKey { - (void)deleteCachedSettings { __weak FIRCLSSettings *weakSelf = self; #ifndef FIREBASE_IS_NIGHTLY_TESTING -#error "Mango: Check one." dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{ #endif __strong FIRCLSSettings *strongSelf = weakSelf; From da9fc93b3b691a296fba617e46130635add1c1e8 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:43:03 -0500 Subject: [PATCH 19/36] Update crashlytics.yml --- .github/workflows/crashlytics.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index 4f63e2ba3a6..983005c25dd 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -30,7 +30,8 @@ jobs: uses: ./.github/workflows/common.yml with: target: FirebaseCrashlyticsUnit - is_nightly: github.event_name == 'schedule' +# is_nightly: github.event_name == 'schedule' + is_nightly: github.event_name == 'pull_request' catalyst: uses: ./.github/workflows/common_catalyst.yml From a4ba4a1d8634d1e786b2a28e2d9f580417ef9b1e Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:43:49 -0500 Subject: [PATCH 20/36] Apply suggestion from @ncooke3 --- Crashlytics/Crashlytics/Models/FIRCLSSettings.m | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m index 80c70a48953..87beb3c744b 100644 --- a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m +++ b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m @@ -192,6 +192,8 @@ - (void)deleteCachedSettings { __weak FIRCLSSettings *weakSelf = self; #ifndef FIREBASE_IS_NIGHTLY_TESTING dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{ +#else +#error "Mango" #endif __strong FIRCLSSettings *strongSelf = weakSelf; if ([strongSelf.fileManager fileExistsAtPath:strongSelf.fileManager.settingsFilePath]) { From 06e42f0f20dacc22226cadb622ad6d099bf16884 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 15 Dec 2025 17:46:22 -0500 Subject: [PATCH 21/36] will revert: disable triggers --- .github/workflows/abtesting.yml | 2 +- .github/workflows/appdistribution.yml | 2 +- .github/workflows/auth.yml | 2 +- .github/workflows/core.yml | 2 +- .github/workflows/core_extension.yml | 2 +- .github/workflows/core_internal.yml | 2 +- .github/workflows/crashlytics.yml | 2 +- .github/workflows/database.yml | 2 +- .github/workflows/firebase_app_check.yml | 2 +- .github/workflows/firebaseai.yml | 2 +- .github/workflows/firestore.yml | 2 +- .github/workflows/functions.yml | 2 +- .github/workflows/inappmessaging.yml | 2 +- .github/workflows/installations.yml | 2 +- .github/workflows/messaging.yml | 2 +- .github/workflows/mlmodeldownloader.yml | 2 +- .github/workflows/performance.yml | 2 +- .github/workflows/remoteconfig.yml | 2 +- .github/workflows/sessions.yml | 2 +- .github/workflows/shared-swift.yml | 2 +- .github/workflows/storage.yml | 2 +- 21 files changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/workflows/abtesting.yml b/.github/workflows/abtesting.yml index ab2b77aa8d6..0c55b0cdc88 100644 --- a/.github/workflows/abtesting.yml +++ b/.github/workflows/abtesting.yml @@ -10,7 +10,7 @@ on: - 'FirebaseABTesting**' - 'Interop/Analytics/Public/*.h' - '.github/workflows/abtesting.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/appdistribution.yml b/.github/workflows/appdistribution.yml index d3a9d874d44..548384a048b 100644 --- a/.github/workflows/appdistribution.yml +++ b/.github/workflows/appdistribution.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseAppDistribution**' - '.github/workflows/appdistribution.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/auth.yml b/.github/workflows/auth.yml index fd9cce9f5be..9008ce2cbaf 100644 --- a/.github/workflows/auth.yml +++ b/.github/workflows/auth.yml @@ -10,7 +10,7 @@ on: - 'FirebaseAuth**' - 'FirebaseAuth/Interop/*.h' - '.github/workflows/auth.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index 8107ba9f21f..3f47c24bb6e 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseCore**' - '.github/workflows/core.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/core_extension.yml b/.github/workflows/core_extension.yml index e1dd78fcc21..11af0b3e6d2 100644 --- a/.github/workflows/core_extension.yml +++ b/.github/workflows/core_extension.yml @@ -10,7 +10,7 @@ on: - 'FirebaseCoreExtension.podspec' - 'FirebaseCore/Extension/**' - '.github/workflows/core_extension.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_cocoapods_cron.yml' - 'Gemfile*' diff --git a/.github/workflows/core_internal.yml b/.github/workflows/core_internal.yml index 5e186069e85..fcb64d144ae 100644 --- a/.github/workflows/core_internal.yml +++ b/.github/workflows/core_internal.yml @@ -10,7 +10,7 @@ on: - 'FirebaseCoreInternal.podspec' - 'FirebaseCore/Internal/**' - '.github/workflows/core_internal.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index 983005c25dd..4fb379da40f 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -10,7 +10,7 @@ on: - 'Crashlytics**' - 'FirebaseCrashlytics.podspec' - '.github/workflows/crashlytics.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/database.yml b/.github/workflows/database.yml index b75ecb9f8a3..4da3d36b909 100644 --- a/.github/workflows/database.yml +++ b/.github/workflows/database.yml @@ -13,7 +13,7 @@ on: - 'Example/Database/**' - 'FirebaseAuth/Interop/*.h' - '.github/workflows/database.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/firebase_app_check.yml b/.github/workflows/firebase_app_check.yml index 6ecb238e4f0..6dc5a93fa5d 100644 --- a/.github/workflows/firebase_app_check.yml +++ b/.github/workflows/firebase_app_check.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseAppCheck**' - '.github/workflows/firebase_app_check.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/firebaseai.yml b/.github/workflows/firebaseai.yml index 1f3cde4a26a..6b1656eb73d 100644 --- a/.github/workflows/firebaseai.yml +++ b/.github/workflows/firebaseai.yml @@ -5,7 +5,7 @@ on: paths: - 'FirebaseAI**' - '.github/workflows/firebaseai.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - 'scripts/build.sh' - 'scripts/quickstart_build_spm.sh' diff --git a/.github/workflows/firestore.yml b/.github/workflows/firestore.yml index 4c3e9726425..7570b80ab75 100644 --- a/.github/workflows/firestore.yml +++ b/.github/workflows/firestore.yml @@ -84,7 +84,7 @@ jobs: - '.github/workflows/firestore.yml' # Workflows this one depends on. - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' # Rebuild on Ruby infrastructure changes. diff --git a/.github/workflows/functions.yml b/.github/workflows/functions.yml index 07cafd50e4e..d73a4ae2a86 100644 --- a/.github/workflows/functions.yml +++ b/.github/workflows/functions.yml @@ -10,7 +10,7 @@ on: - 'FirebaseFunctions**' - 'FirebaseSharedSwift**' - '.github/workflows/functions.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_cocoapods_cron.yml' - 'FirebaseAuth/Interop/*.h' diff --git a/.github/workflows/inappmessaging.yml b/.github/workflows/inappmessaging.yml index b7ace6a847a..232ba026d3c 100644 --- a/.github/workflows/inappmessaging.yml +++ b/.github/workflows/inappmessaging.yml @@ -10,7 +10,7 @@ on: - 'FirebaseInAppMessaging**' - 'Interop/Analytics/Public/*.h' - '.github/workflows/inappmessaging.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_quickstart.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/installations.yml b/.github/workflows/installations.yml index 6037a762d2c..e2014e52ba9 100644 --- a/.github/workflows/installations.yml +++ b/.github/workflows/installations.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseInstallations**' - '.github/workflows/installations.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/messaging.yml b/.github/workflows/messaging.yml index 596fcb80bf9..e9dc593c3ae 100644 --- a/.github/workflows/messaging.yml +++ b/.github/workflows/messaging.yml @@ -16,7 +16,7 @@ on: # This file - '.github/workflows/messaging.yml' # Re-usable workflows being used by this file. - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index 5859a02c47e..4e88cd66b2f 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseMLModelDownloader**' - '.github/workflows/mlmodeldownloader.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml index d5b39b13b39..2e333cb0310 100644 --- a/.github/workflows/performance.yml +++ b/.github/workflows/performance.yml @@ -16,7 +16,7 @@ on: # YML configuration file - '.github/workflows/performance.yml' # Re-usable workflows depended on by this file. - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/remoteconfig.yml b/.github/workflows/remoteconfig.yml index 36ba73ed473..3fc5f81fd73 100644 --- a/.github/workflows/remoteconfig.yml +++ b/.github/workflows/remoteconfig.yml @@ -10,7 +10,7 @@ on: - 'FirebaseRemoteConfig**' - 'Interop/Analytics/Public/*.h' - '.github/workflows/remoteconfig.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/sessions.yml b/.github/workflows/sessions.yml index f0df72c44c2..095b2df2cc2 100644 --- a/.github/workflows/sessions.yml +++ b/.github/workflows/sessions.yml @@ -10,7 +10,7 @@ on: - 'FirebaseSessions**' - 'FirebaseSessions.podspec' - '.github/workflows/sessions.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'Gemfile*' diff --git a/.github/workflows/shared-swift.yml b/.github/workflows/shared-swift.yml index fa13d6e9a4c..aff4aa24632 100644 --- a/.github/workflows/shared-swift.yml +++ b/.github/workflows/shared-swift.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseSharedSwift**' - '.github/workflows/shared-swift.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/storage.yml b/.github/workflows/storage.yml index 9aae03de131..80e92b681c8 100644 --- a/.github/workflows/storage.yml +++ b/.github/workflows/storage.yml @@ -10,7 +10,7 @@ on: - 'FirebaseStorage**' - 'FirebaseAuth/Interop/*.h' - '.github/workflows/storage.yml' - - '.github/workflows/common.yml' + # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' From 18cca440015b0f623ec61e5f40ea041faa77600e Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 15 Dec 2025 17:47:31 -0500 Subject: [PATCH 22/36] will revert: disable triggers --- .github/workflows/firestore.yml | 2 +- .github/workflows/spm.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/firestore.yml b/.github/workflows/firestore.yml index 7570b80ab75..702a807c57f 100644 --- a/.github/workflows/firestore.yml +++ b/.github/workflows/firestore.yml @@ -59,7 +59,7 @@ jobs: - 'FirebaseFirestore.podspec' # Package.swift - - 'Package.swift' + # - 'Package.swift' # CMake - '**CMakeLists.txt' diff --git a/.github/workflows/spm.yml b/.github/workflows/spm.yml index eb0dba8c438..660813ca83c 100644 --- a/.github/workflows/spm.yml +++ b/.github/workflows/spm.yml @@ -5,7 +5,7 @@ on: pull_request: paths: - '.github/workflows/spm.yml' - - 'Package.swift' + # - 'Package.swift' - '.swiftpm/*' - 'scripts/build.sh' - 'SwiftPMTests/*' From 3cda91f2029d847df0cfefcc4ede897bda8b25d1 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:56:25 -0500 Subject: [PATCH 23/36] Update .github/workflows/storage.yml --- .github/workflows/storage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/storage.yml b/.github/workflows/storage.yml index 80e92b681c8..981098a6885 100644 --- a/.github/workflows/storage.yml +++ b/.github/workflows/storage.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseStorage**' - 'FirebaseAuth/Interop/*.h' - - '.github/workflows/storage.yml' + # - '.github/workflows/storage.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' From 167928a3f192b21734d9d5f1b059d1f174d14ac7 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:57:54 -0500 Subject: [PATCH 24/36] Apply suggestions from code review --- .github/workflows/abtesting.yml | 2 +- .github/workflows/appdistribution.yml | 2 +- .github/workflows/auth.yml | 2 +- .github/workflows/core.yml | 2 +- .github/workflows/core_extension.yml | 2 +- .github/workflows/core_internal.yml | 2 +- .github/workflows/database.yml | 2 +- .github/workflows/firebase_app_check.yml | 2 +- .github/workflows/firebaseai.yml | 2 +- .github/workflows/firestore.yml | 2 +- .github/workflows/functions.yml | 2 +- .github/workflows/inappmessaging.yml | 2 +- .github/workflows/installations.yml | 2 +- .github/workflows/messaging.yml | 2 +- .github/workflows/mlmodeldownloader.yml | 2 +- .github/workflows/performance.yml | 2 +- .github/workflows/remoteconfig.yml | 2 +- .github/workflows/sessions.yml | 2 +- .github/workflows/shared-swift.yml | 2 +- .github/workflows/spm.yml | 2 +- 20 files changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/workflows/abtesting.yml b/.github/workflows/abtesting.yml index 0c55b0cdc88..aa9787b90d3 100644 --- a/.github/workflows/abtesting.yml +++ b/.github/workflows/abtesting.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseABTesting**' - 'Interop/Analytics/Public/*.h' - - '.github/workflows/abtesting.yml' + # - '.github/workflows/abtesting.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' diff --git a/.github/workflows/appdistribution.yml b/.github/workflows/appdistribution.yml index 548384a048b..98b02a2ee49 100644 --- a/.github/workflows/appdistribution.yml +++ b/.github/workflows/appdistribution.yml @@ -8,7 +8,7 @@ on: pull_request: paths: - 'FirebaseAppDistribution**' - - '.github/workflows/appdistribution.yml' + # - '.github/workflows/appdistribution.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' diff --git a/.github/workflows/auth.yml b/.github/workflows/auth.yml index 9008ce2cbaf..e9c34172990 100644 --- a/.github/workflows/auth.yml +++ b/.github/workflows/auth.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseAuth**' - 'FirebaseAuth/Interop/*.h' - - '.github/workflows/auth.yml' + # - '.github/workflows/auth.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index 3f47c24bb6e..e1c4c5e045f 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -8,7 +8,7 @@ on: pull_request: paths: - 'FirebaseCore**' - - '.github/workflows/core.yml' + # - '.github/workflows/core.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' diff --git a/.github/workflows/core_extension.yml b/.github/workflows/core_extension.yml index 11af0b3e6d2..098d36c75d4 100644 --- a/.github/workflows/core_extension.yml +++ b/.github/workflows/core_extension.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseCoreExtension.podspec' - 'FirebaseCore/Extension/**' - - '.github/workflows/core_extension.yml' + # - '.github/workflows/core_extension.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/core_internal.yml b/.github/workflows/core_internal.yml index fcb64d144ae..f37209f2121 100644 --- a/.github/workflows/core_internal.yml +++ b/.github/workflows/core_internal.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseCoreInternal.podspec' - 'FirebaseCore/Internal/**' - - '.github/workflows/core_internal.yml' + # - '.github/workflows/core_internal.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' diff --git a/.github/workflows/database.yml b/.github/workflows/database.yml index 4da3d36b909..cd54c5868dc 100644 --- a/.github/workflows/database.yml +++ b/.github/workflows/database.yml @@ -12,7 +12,7 @@ on: - 'FirebaseSharedSwift**' - 'Example/Database/**' - 'FirebaseAuth/Interop/*.h' - - '.github/workflows/database.yml' + # - '.github/workflows/database.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' diff --git a/.github/workflows/firebase_app_check.yml b/.github/workflows/firebase_app_check.yml index 6dc5a93fa5d..cd36b96d1c3 100644 --- a/.github/workflows/firebase_app_check.yml +++ b/.github/workflows/firebase_app_check.yml @@ -8,7 +8,7 @@ on: pull_request: paths: - 'FirebaseAppCheck**' - - '.github/workflows/firebase_app_check.yml' + # - '.github/workflows/firebase_app_check.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' diff --git a/.github/workflows/firebaseai.yml b/.github/workflows/firebaseai.yml index 6b1656eb73d..faca2852a4d 100644 --- a/.github/workflows/firebaseai.yml +++ b/.github/workflows/firebaseai.yml @@ -4,7 +4,7 @@ on: pull_request: paths: - 'FirebaseAI**' - - '.github/workflows/firebaseai.yml' + # - '.github/workflows/firebaseai.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - 'scripts/build.sh' diff --git a/.github/workflows/firestore.yml b/.github/workflows/firestore.yml index 702a807c57f..86c9921c329 100644 --- a/.github/workflows/firestore.yml +++ b/.github/workflows/firestore.yml @@ -81,7 +81,7 @@ jobs: - 'scripts/xcresult_logs.py' # This workflow - - '.github/workflows/firestore.yml' + # - '.github/workflows/firestore.yml' # Workflows this one depends on. # - '.github/workflows/common.yml' diff --git a/.github/workflows/functions.yml b/.github/workflows/functions.yml index d73a4ae2a86..8e5d012be5d 100644 --- a/.github/workflows/functions.yml +++ b/.github/workflows/functions.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseFunctions**' - 'FirebaseSharedSwift**' - - '.github/workflows/functions.yml' + # - '.github/workflows/functions.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/inappmessaging.yml b/.github/workflows/inappmessaging.yml index 232ba026d3c..a5a6826029d 100644 --- a/.github/workflows/inappmessaging.yml +++ b/.github/workflows/inappmessaging.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseInAppMessaging**' - 'Interop/Analytics/Public/*.h' - - '.github/workflows/inappmessaging.yml' + # - '.github/workflows/inappmessaging.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/installations.yml b/.github/workflows/installations.yml index e2014e52ba9..1d705dbf64a 100644 --- a/.github/workflows/installations.yml +++ b/.github/workflows/installations.yml @@ -8,7 +8,7 @@ on: pull_request: paths: - 'FirebaseInstallations**' - - '.github/workflows/installations.yml' + # - '.github/workflows/installations.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' diff --git a/.github/workflows/messaging.yml b/.github/workflows/messaging.yml index e9dc593c3ae..1efbf6ee85a 100644 --- a/.github/workflows/messaging.yml +++ b/.github/workflows/messaging.yml @@ -14,7 +14,7 @@ on: # Podspec - 'FirebaseMessaging.podspec' # This file - - '.github/workflows/messaging.yml' + # - '.github/workflows/messaging.yml' # Re-usable workflows being used by this file. # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index 4e88cd66b2f..fc7d3a2fbd4 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -8,7 +8,7 @@ on: pull_request: paths: - 'FirebaseMLModelDownloader**' - - '.github/workflows/mlmodeldownloader.yml' + # - '.github/workflows/mlmodeldownloader.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml index 2e333cb0310..6cc8d6f05bf 100644 --- a/.github/workflows/performance.yml +++ b/.github/workflows/performance.yml @@ -14,7 +14,7 @@ on: # Podspec - 'FirebasePerformance.podspec' # YML configuration file - - '.github/workflows/performance.yml' + # - '.github/workflows/performance.yml' # Re-usable workflows depended on by this file. # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' diff --git a/.github/workflows/remoteconfig.yml b/.github/workflows/remoteconfig.yml index 3fc5f81fd73..2e57ec692c3 100644 --- a/.github/workflows/remoteconfig.yml +++ b/.github/workflows/remoteconfig.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseRemoteConfig**' - 'Interop/Analytics/Public/*.h' - - '.github/workflows/remoteconfig.yml' + # - '.github/workflows/remoteconfig.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' diff --git a/.github/workflows/sessions.yml b/.github/workflows/sessions.yml index 095b2df2cc2..0766ff94487 100644 --- a/.github/workflows/sessions.yml +++ b/.github/workflows/sessions.yml @@ -9,7 +9,7 @@ on: paths: - 'FirebaseSessions**' - 'FirebaseSessions.podspec' - - '.github/workflows/sessions.yml' + # - '.github/workflows/sessions.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' diff --git a/.github/workflows/shared-swift.yml b/.github/workflows/shared-swift.yml index aff4aa24632..399b9e2f452 100644 --- a/.github/workflows/shared-swift.yml +++ b/.github/workflows/shared-swift.yml @@ -8,7 +8,7 @@ on: pull_request: paths: - 'FirebaseSharedSwift**' - - '.github/workflows/shared-swift.yml' + # - '.github/workflows/shared-swift.yml' # - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/spm.yml b/.github/workflows/spm.yml index 660813ca83c..a023f275a04 100644 --- a/.github/workflows/spm.yml +++ b/.github/workflows/spm.yml @@ -4,7 +4,7 @@ on: workflow_dispatch: pull_request: paths: - - '.github/workflows/spm.yml' + # - '.github/workflows/spm.yml' # - 'Package.swift' - '.swiftpm/*' - 'scripts/build.sh' From 038d1d39780b4e86ebe3d3591556b6ed02c86593 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 18:09:47 -0500 Subject: [PATCH 25/36] Apply suggestion from @ncooke3 --- .github/workflows/crashlytics.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index 4fb379da40f..8dccb040f03 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -30,8 +30,8 @@ jobs: uses: ./.github/workflows/common.yml with: target: FirebaseCrashlyticsUnit -# is_nightly: github.event_name == 'schedule' - is_nightly: github.event_name == 'pull_request' + # is_nightly: ${{ github.event_name == 'schedule' }} + is_nightly: ${{ github.event_name == 'pull_request' }} catalyst: uses: ./.github/workflows/common_catalyst.yml From ff27f60625adcd2d1b790c02d78da7d387dba7c7 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 20:44:25 -0500 Subject: [PATCH 26/36] Apply suggestion from @ncooke3 --- .github/workflows/common.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/common.yml b/.github/workflows/common.yml index de7d6f0c086..052d6e8d1c3 100644 --- a/.github/workflows/common.yml +++ b/.github/workflows/common.yml @@ -92,6 +92,8 @@ jobs: # Run on the main repo's scheduled jobs or pull requests and manual workflow invocations. if: (github.repository == 'firebase/firebase-ios-sdk' && github.event_name == 'schedule') || contains(fromJSON('["pull_request", "workflow_dispatch"]'), github.event_name) needs: [spm-package-resolved] + env: + FIREBASE_IS_NIGHTLY_TESTING: ${{ inputs.is_nightly && '1' || '' }} strategy: matrix: os: [macos-15] From ec89300d76b9192d1946e1b5f89a7fbfac96d083 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 20:56:27 -0500 Subject: [PATCH 27/36] Apply suggestion from @ncooke3 --- Package.swift | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Package.swift b/Package.swift index c21cfc42eee..5925c2591d9 100644 --- a/Package.swift +++ b/Package.swift @@ -599,6 +599,10 @@ let package = Package( to: "Crashlytics macOS SDK", .when(platforms: [.macOS, .macCatalyst]) ), + .define( + "FIREBASE_IS_NIGHTLY_TESTING", + to: Context.environment["FIREBASE_IS_NIGHTLY_TESTING", default: ""] + ), .define("CLS_SDK_NAME", to: "Crashlytics tvOS SDK", .when(platforms: [.tvOS])), .define("CLS_SDK_NAME", to: "Crashlytics watchOS SDK", .when(platforms: [.watchOS])), .define("PB_FIELD_32BIT", to: "1"), From 972971a01c301e0c3709d98305d03a19efacdd50 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 20:57:22 -0500 Subject: [PATCH 28/36] Apply suggestion from @ncooke3 --- Package.swift | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Package.swift b/Package.swift index 5925c2591d9..44b12e7c09a 100644 --- a/Package.swift +++ b/Package.swift @@ -640,10 +640,6 @@ let package = Package( ], cSettings: [ .headerSearchPath("../.."), - .define( - "FIREBASE_IS_NIGHTLY_TESTING", - to: Context.environment["FIREBASE_IS_NIGHTLY_TESTING", default: ""] - ), .define("DISPLAY_VERSION", to: firebaseVersion), .define("CLS_SDK_NAME", to: "Crashlytics iOS SDK", .when(platforms: [.iOS])), .define( From 870f4e9f1101f0bcfe053f9187210e9684370510 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 21:21:24 -0500 Subject: [PATCH 29/36] Update Package.swift --- Package.swift | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Package.swift b/Package.swift index 44b12e7c09a..cd555f3a281 100644 --- a/Package.swift +++ b/Package.swift @@ -599,16 +599,13 @@ let package = Package( to: "Crashlytics macOS SDK", .when(platforms: [.macOS, .macCatalyst]) ), - .define( - "FIREBASE_IS_NIGHTLY_TESTING", - to: Context.environment["FIREBASE_IS_NIGHTLY_TESTING", default: ""] - ), .define("CLS_SDK_NAME", to: "Crashlytics tvOS SDK", .when(platforms: [.tvOS])), .define("CLS_SDK_NAME", to: "Crashlytics watchOS SDK", .when(platforms: [.watchOS])), .define("PB_FIELD_32BIT", to: "1"), .define("PB_NO_PACKED_STRUCTS", to: "1"), .define("PB_ENABLE_MALLOC", to: "1"), - ], + ] + Context.environment["FIREBASE_IS_NIGHTLY_TESTING"] != nil ? + [.define("FIREBASE_IS_NIGHTLY_TESTING", to: "1")] : [], linkerSettings: [ .linkedFramework("Security"), .linkedFramework("SystemConfiguration", .when(platforms: [.iOS, .macOS, .tvOS])), From d55cb980b10bfdab7dd31cabc8da04cb50b58280 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 21:33:02 -0500 Subject: [PATCH 30/36] fix? --- Package.swift | 120 +++++++++++++++++++++++++++----------------------- 1 file changed, 64 insertions(+), 56 deletions(-) diff --git a/Package.swift b/Package.swift index cd555f3a281..13399a18f95 100644 --- a/Package.swift +++ b/Package.swift @@ -555,62 +555,7 @@ let package = Package( ], path: "FirebaseCombineSwift/Sources/Storage" ), - .target( - name: "FirebaseCrashlytics", - dependencies: [ - "FirebaseCore", - "FirebaseInstallations", - "FirebaseSessions", - "FirebaseRemoteConfigInterop", - "FirebaseCrashlyticsSwift", - .product(name: "GoogleDataTransport", package: "GoogleDataTransport"), - .product(name: "GULEnvironment", package: "GoogleUtilities"), - .product(name: "FBLPromises", package: "Promises"), - .product(name: "nanopb", package: "nanopb"), - ], - path: "Crashlytics", - exclude: [ - "run", - "CHANGELOG.md", - "LICENSE", - "README.md", - "ProtoSupport/", - "UnitTests/", - "generate_project.sh", - "upload-symbols", - "CrashlyticsInputFiles.xcfilelist", - "third_party/libunwind/LICENSE", - "Crashlytics/Rollouts/", - ], - sources: [ - "Crashlytics/", - "Protogen/", - "Shared/", - "third_party/libunwind/dwarf.h", - ], - resources: [.process("Resources/PrivacyInfo.xcprivacy")], - publicHeadersPath: "Crashlytics/Public", - cSettings: [ - .headerSearchPath(".."), - .define("DISPLAY_VERSION", to: firebaseVersion), - .define("CLS_SDK_NAME", to: "Crashlytics iOS SDK", .when(platforms: [.iOS])), - .define( - "CLS_SDK_NAME", - to: "Crashlytics macOS SDK", - .when(platforms: [.macOS, .macCatalyst]) - ), - .define("CLS_SDK_NAME", to: "Crashlytics tvOS SDK", .when(platforms: [.tvOS])), - .define("CLS_SDK_NAME", to: "Crashlytics watchOS SDK", .when(platforms: [.watchOS])), - .define("PB_FIELD_32BIT", to: "1"), - .define("PB_NO_PACKED_STRUCTS", to: "1"), - .define("PB_ENABLE_MALLOC", to: "1"), - ] + Context.environment["FIREBASE_IS_NIGHTLY_TESTING"] != nil ? - [.define("FIREBASE_IS_NIGHTLY_TESTING", to: "1")] : [], - linkerSettings: [ - .linkedFramework("Security"), - .linkedFramework("SystemConfiguration", .when(platforms: [.iOS, .macOS, .tvOS])), - ] - ), + firebaseCrashlyticsTarget(), .target( name: "FirebaseCrashlyticsSwift", dependencies: ["FirebaseRemoteConfigInterop"], @@ -1403,6 +1348,69 @@ let package = Package( // MARK: - Helper Functions +func firebaseCrashlyticsTarget() -> Target { + var cSettings = [ + .headerSearchPath(".."), + .define("DISPLAY_VERSION", to: firebaseVersion), + .define("CLS_SDK_NAME", to: "Crashlytics iOS SDK", .when(platforms: [.iOS])), + .define( + "CLS_SDK_NAME", to: "Crashlytics macOS SDK", + .when(platforms: [.macOS, .macCatalyst]) + ), + .define("CLS_SDK_NAME", to: "Crashlytics tvOS SDK", .when(platforms: [.tvOS])), + .define("CLS_SDK_NAME", to: "Crashlytics watchOS SDK", .when(platforms: [.watchOS])), + .define("PB_FIELD_32BIT", to: "1"), + .define("PB_NO_PACKED_STRUCTS", to: "1"), + .define("PB_ENABLE_MALLOC", to: "1") + ] + + if Context.environment["FIREBASE_IS_NIGHTLY_TESTING"] != nil { + cSettings += [.define("FIREBASE_IS_NIGHTLY_TESTING", to: "1")] + } + + return .target( + name: "FirebaseCrashlytics", + dependencies: [ + "FirebaseCore", + "FirebaseInstallations", + "FirebaseSessions", + "FirebaseRemoteConfigInterop", + "FirebaseCrashlyticsSwift", + .product(name: "GoogleDataTransport", package: "GoogleDataTransport"), + .product(name: "GULEnvironment", package: "GoogleUtilities"), + .product(name: "FBLPromises", package: "Promises"), + .product(name: "nanopb", package: "nanopb"), + ], + path: "Crashlytics", + exclude: [ + "run", + "CHANGELOG.md", + "LICENSE", + "README.md", + "ProtoSupport/", + "UnitTests/", + "generate_project.sh", + "upload-symbols", + "CrashlyticsInputFiles.xcfilelist", + "third_party/libunwind/LICENSE", + "Crashlytics/Rollouts/", + ], + sources: [ + "Crashlytics/", + "Protogen/", + "Shared/", + "third_party/libunwind/dwarf.h", + ], + resources: [.process("Resources/PrivacyInfo.xcprivacy")], + publicHeadersPath: "Crashlytics/Public", + cSettings: cSettings, + linkerSettings: [ + .linkedFramework("Security"), + .linkedFramework("SystemConfiguration", .when(platforms: [.iOS, .macOS, .tvOS])), + ] + ) +} + func googleAppMeasurementDependency() -> Package.Dependency { let appMeasurementURL = "https://github.com/google/GoogleAppMeasurement.git" From 0d86275fb186d17836cabd676845c058c3cc195d Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 15 Dec 2025 21:36:39 -0500 Subject: [PATCH 31/36] fix?? --- Package.swift | 114 +++++++++++++++++++++++++------------------------- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git a/Package.swift b/Package.swift index 13399a18f95..de5871e591a 100644 --- a/Package.swift +++ b/Package.swift @@ -1349,66 +1349,66 @@ let package = Package( // MARK: - Helper Functions func firebaseCrashlyticsTarget() -> Target { - var cSettings = [ - .headerSearchPath(".."), - .define("DISPLAY_VERSION", to: firebaseVersion), - .define("CLS_SDK_NAME", to: "Crashlytics iOS SDK", .when(platforms: [.iOS])), - .define( - "CLS_SDK_NAME", to: "Crashlytics macOS SDK", - .when(platforms: [.macOS, .macCatalyst]) - ), - .define("CLS_SDK_NAME", to: "Crashlytics tvOS SDK", .when(platforms: [.tvOS])), - .define("CLS_SDK_NAME", to: "Crashlytics watchOS SDK", .when(platforms: [.watchOS])), - .define("PB_FIELD_32BIT", to: "1"), - .define("PB_NO_PACKED_STRUCTS", to: "1"), - .define("PB_ENABLE_MALLOC", to: "1") - ] + var cSettings: [CSetting] = [ + .headerSearchPath(".."), + .define("DISPLAY_VERSION", to: firebaseVersion), + .define("CLS_SDK_NAME", to: "Crashlytics iOS SDK", .when(platforms: [.iOS])), + .define( + "CLS_SDK_NAME", to: "Crashlytics macOS SDK", + .when(platforms: [.macOS, .macCatalyst]) + ), + .define("CLS_SDK_NAME", to: "Crashlytics tvOS SDK", .when(platforms: [.tvOS])), + .define("CLS_SDK_NAME", to: "Crashlytics watchOS SDK", .when(platforms: [.watchOS])), + .define("PB_FIELD_32BIT", to: "1"), + .define("PB_NO_PACKED_STRUCTS", to: "1"), + .define("PB_ENABLE_MALLOC", to: "1"), + ] - if Context.environment["FIREBASE_IS_NIGHTLY_TESTING"] != nil { - cSettings += [.define("FIREBASE_IS_NIGHTLY_TESTING", to: "1")] - } + if Context.environment["FIREBASE_IS_NIGHTLY_TESTING"] != nil { + cSettings += [.define("FIREBASE_IS_NIGHTLY_TESTING", to: "1")] + } return .target( - name: "FirebaseCrashlytics", - dependencies: [ - "FirebaseCore", - "FirebaseInstallations", - "FirebaseSessions", - "FirebaseRemoteConfigInterop", - "FirebaseCrashlyticsSwift", - .product(name: "GoogleDataTransport", package: "GoogleDataTransport"), - .product(name: "GULEnvironment", package: "GoogleUtilities"), - .product(name: "FBLPromises", package: "Promises"), - .product(name: "nanopb", package: "nanopb"), - ], - path: "Crashlytics", - exclude: [ - "run", - "CHANGELOG.md", - "LICENSE", - "README.md", - "ProtoSupport/", - "UnitTests/", - "generate_project.sh", - "upload-symbols", - "CrashlyticsInputFiles.xcfilelist", - "third_party/libunwind/LICENSE", - "Crashlytics/Rollouts/", - ], - sources: [ - "Crashlytics/", - "Protogen/", - "Shared/", - "third_party/libunwind/dwarf.h", - ], - resources: [.process("Resources/PrivacyInfo.xcprivacy")], - publicHeadersPath: "Crashlytics/Public", - cSettings: cSettings, - linkerSettings: [ - .linkedFramework("Security"), - .linkedFramework("SystemConfiguration", .when(platforms: [.iOS, .macOS, .tvOS])), - ] - ) + name: "FirebaseCrashlytics", + dependencies: [ + "FirebaseCore", + "FirebaseInstallations", + "FirebaseSessions", + "FirebaseRemoteConfigInterop", + "FirebaseCrashlyticsSwift", + .product(name: "GoogleDataTransport", package: "GoogleDataTransport"), + .product(name: "GULEnvironment", package: "GoogleUtilities"), + .product(name: "FBLPromises", package: "Promises"), + .product(name: "nanopb", package: "nanopb"), + ], + path: "Crashlytics", + exclude: [ + "run", + "CHANGELOG.md", + "LICENSE", + "README.md", + "ProtoSupport/", + "UnitTests/", + "generate_project.sh", + "upload-symbols", + "CrashlyticsInputFiles.xcfilelist", + "third_party/libunwind/LICENSE", + "Crashlytics/Rollouts/", + ], + sources: [ + "Crashlytics/", + "Protogen/", + "Shared/", + "third_party/libunwind/dwarf.h", + ], + resources: [.process("Resources/PrivacyInfo.xcprivacy")], + publicHeadersPath: "Crashlytics/Public", + cSettings: cSettings, + linkerSettings: [ + .linkedFramework("Security"), + .linkedFramework("SystemConfiguration", .when(platforms: [.iOS, .macOS, .tvOS])), + ] + ) } func googleAppMeasurementDependency() -> Package.Dependency { From 322e4afbb75ffa8198dff9916ee16065adb97759 Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 22:31:10 -0500 Subject: [PATCH 32/36] Update .github/workflows/crashlytics.yml --- .github/workflows/crashlytics.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index 8dccb040f03..c4867153e3f 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -30,8 +30,7 @@ jobs: uses: ./.github/workflows/common.yml with: target: FirebaseCrashlyticsUnit - # is_nightly: ${{ github.event_name == 'schedule' }} - is_nightly: ${{ github.event_name == 'pull_request' }} + is_nightly: ${{ github.event_name == 'schedule' }} catalyst: uses: ./.github/workflows/common_catalyst.yml From dafa9f5cfdfa5b5742c39bf45da81f2e01bfb954 Mon Sep 17 00:00:00 2001 From: Nick Cooke Date: Mon, 15 Dec 2025 22:35:11 -0500 Subject: [PATCH 33/36] re-enable --- .github/workflows/abtesting.yml | 4 ++-- .github/workflows/appdistribution.yml | 4 ++-- .github/workflows/auth.yml | 4 ++-- .github/workflows/core.yml | 4 ++-- .github/workflows/core_extension.yml | 4 ++-- .github/workflows/core_internal.yml | 4 ++-- .github/workflows/crashlytics.yml | 2 +- .github/workflows/database.yml | 4 ++-- .github/workflows/firebase_app_check.yml | 4 ++-- .github/workflows/firebaseai.yml | 4 ++-- .github/workflows/firestore.yml | 4 ++-- .github/workflows/functions.yml | 4 ++-- .github/workflows/inappmessaging.yml | 4 ++-- .github/workflows/installations.yml | 4 ++-- .github/workflows/messaging.yml | 4 ++-- .github/workflows/mlmodeldownloader.yml | 4 ++-- .github/workflows/performance.yml | 4 ++-- .github/workflows/remoteconfig.yml | 4 ++-- .github/workflows/sessions.yml | 4 ++-- .github/workflows/shared-swift.yml | 4 ++-- .github/workflows/spm.yml | 2 +- .github/workflows/storage.yml | 4 ++-- 22 files changed, 42 insertions(+), 42 deletions(-) diff --git a/.github/workflows/abtesting.yml b/.github/workflows/abtesting.yml index aa9787b90d3..ab2b77aa8d6 100644 --- a/.github/workflows/abtesting.yml +++ b/.github/workflows/abtesting.yml @@ -9,8 +9,8 @@ on: paths: - 'FirebaseABTesting**' - 'Interop/Analytics/Public/*.h' - # - '.github/workflows/abtesting.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/abtesting.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/appdistribution.yml b/.github/workflows/appdistribution.yml index 98b02a2ee49..d3a9d874d44 100644 --- a/.github/workflows/appdistribution.yml +++ b/.github/workflows/appdistribution.yml @@ -8,8 +8,8 @@ on: pull_request: paths: - 'FirebaseAppDistribution**' - # - '.github/workflows/appdistribution.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/appdistribution.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/auth.yml b/.github/workflows/auth.yml index e9c34172990..fd9cce9f5be 100644 --- a/.github/workflows/auth.yml +++ b/.github/workflows/auth.yml @@ -9,8 +9,8 @@ on: paths: - 'FirebaseAuth**' - 'FirebaseAuth/Interop/*.h' - # - '.github/workflows/auth.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/auth.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml index e1c4c5e045f..8107ba9f21f 100644 --- a/.github/workflows/core.yml +++ b/.github/workflows/core.yml @@ -8,8 +8,8 @@ on: pull_request: paths: - 'FirebaseCore**' - # - '.github/workflows/core.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/core.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/core_extension.yml b/.github/workflows/core_extension.yml index 098d36c75d4..e1dd78fcc21 100644 --- a/.github/workflows/core_extension.yml +++ b/.github/workflows/core_extension.yml @@ -9,8 +9,8 @@ on: paths: - 'FirebaseCoreExtension.podspec' - 'FirebaseCore/Extension/**' - # - '.github/workflows/core_extension.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/core_extension.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_cocoapods_cron.yml' - 'Gemfile*' diff --git a/.github/workflows/core_internal.yml b/.github/workflows/core_internal.yml index f37209f2121..5e186069e85 100644 --- a/.github/workflows/core_internal.yml +++ b/.github/workflows/core_internal.yml @@ -9,8 +9,8 @@ on: paths: - 'FirebaseCoreInternal.podspec' - 'FirebaseCore/Internal/**' - # - '.github/workflows/core_internal.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/core_internal.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/crashlytics.yml b/.github/workflows/crashlytics.yml index c4867153e3f..341da63a063 100644 --- a/.github/workflows/crashlytics.yml +++ b/.github/workflows/crashlytics.yml @@ -10,7 +10,7 @@ on: - 'Crashlytics**' - 'FirebaseCrashlytics.podspec' - '.github/workflows/crashlytics.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/database.yml b/.github/workflows/database.yml index cd54c5868dc..b75ecb9f8a3 100644 --- a/.github/workflows/database.yml +++ b/.github/workflows/database.yml @@ -12,8 +12,8 @@ on: - 'FirebaseSharedSwift**' - 'Example/Database/**' - 'FirebaseAuth/Interop/*.h' - # - '.github/workflows/database.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/database.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/firebase_app_check.yml b/.github/workflows/firebase_app_check.yml index cd36b96d1c3..6ecb238e4f0 100644 --- a/.github/workflows/firebase_app_check.yml +++ b/.github/workflows/firebase_app_check.yml @@ -8,8 +8,8 @@ on: pull_request: paths: - 'FirebaseAppCheck**' - # - '.github/workflows/firebase_app_check.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/firebase_app_check.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/firebaseai.yml b/.github/workflows/firebaseai.yml index faca2852a4d..1f3cde4a26a 100644 --- a/.github/workflows/firebaseai.yml +++ b/.github/workflows/firebaseai.yml @@ -4,8 +4,8 @@ on: pull_request: paths: - 'FirebaseAI**' - # - '.github/workflows/firebaseai.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/firebaseai.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - 'scripts/build.sh' - 'scripts/quickstart_build_spm.sh' diff --git a/.github/workflows/firestore.yml b/.github/workflows/firestore.yml index 86c9921c329..40f6edbb924 100644 --- a/.github/workflows/firestore.yml +++ b/.github/workflows/firestore.yml @@ -81,10 +81,10 @@ jobs: - 'scripts/xcresult_logs.py' # This workflow - # - '.github/workflows/firestore.yml' + - '.github/workflows/firestore.yml' # Workflows this one depends on. - # - '.github/workflows/common.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' # Rebuild on Ruby infrastructure changes. diff --git a/.github/workflows/functions.yml b/.github/workflows/functions.yml index 8e5d012be5d..07cafd50e4e 100644 --- a/.github/workflows/functions.yml +++ b/.github/workflows/functions.yml @@ -9,8 +9,8 @@ on: paths: - 'FirebaseFunctions**' - 'FirebaseSharedSwift**' - # - '.github/workflows/functions.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/functions.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_cocoapods_cron.yml' - 'FirebaseAuth/Interop/*.h' diff --git a/.github/workflows/inappmessaging.yml b/.github/workflows/inappmessaging.yml index a5a6826029d..b7ace6a847a 100644 --- a/.github/workflows/inappmessaging.yml +++ b/.github/workflows/inappmessaging.yml @@ -9,8 +9,8 @@ on: paths: - 'FirebaseInAppMessaging**' - 'Interop/Analytics/Public/*.h' - # - '.github/workflows/inappmessaging.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/inappmessaging.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_quickstart.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/installations.yml b/.github/workflows/installations.yml index 1d705dbf64a..6037a762d2c 100644 --- a/.github/workflows/installations.yml +++ b/.github/workflows/installations.yml @@ -8,8 +8,8 @@ on: pull_request: paths: - 'FirebaseInstallations**' - # - '.github/workflows/installations.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/installations.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/messaging.yml b/.github/workflows/messaging.yml index 1efbf6ee85a..596fcb80bf9 100644 --- a/.github/workflows/messaging.yml +++ b/.github/workflows/messaging.yml @@ -14,9 +14,9 @@ on: # Podspec - 'FirebaseMessaging.podspec' # This file - # - '.github/workflows/messaging.yml' + - '.github/workflows/messaging.yml' # Re-usable workflows being used by this file. - # - '.github/workflows/common.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/mlmodeldownloader.yml b/.github/workflows/mlmodeldownloader.yml index fc7d3a2fbd4..5859a02c47e 100644 --- a/.github/workflows/mlmodeldownloader.yml +++ b/.github/workflows/mlmodeldownloader.yml @@ -8,8 +8,8 @@ on: pull_request: paths: - 'FirebaseMLModelDownloader**' - # - '.github/workflows/mlmodeldownloader.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/mlmodeldownloader.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_cocoapods_cron.yml' diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml index 6cc8d6f05bf..d5b39b13b39 100644 --- a/.github/workflows/performance.yml +++ b/.github/workflows/performance.yml @@ -14,9 +14,9 @@ on: # Podspec - 'FirebasePerformance.podspec' # YML configuration file - # - '.github/workflows/performance.yml' + - '.github/workflows/performance.yml' # Re-usable workflows depended on by this file. - # - '.github/workflows/common.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/remoteconfig.yml b/.github/workflows/remoteconfig.yml index 2e57ec692c3..36ba73ed473 100644 --- a/.github/workflows/remoteconfig.yml +++ b/.github/workflows/remoteconfig.yml @@ -9,8 +9,8 @@ on: paths: - 'FirebaseRemoteConfig**' - 'Interop/Analytics/Public/*.h' - # - '.github/workflows/remoteconfig.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/remoteconfig.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' diff --git a/.github/workflows/sessions.yml b/.github/workflows/sessions.yml index 0766ff94487..f0df72c44c2 100644 --- a/.github/workflows/sessions.yml +++ b/.github/workflows/sessions.yml @@ -9,8 +9,8 @@ on: paths: - 'FirebaseSessions**' - 'FirebaseSessions.podspec' - # - '.github/workflows/sessions.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/sessions.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - 'Gemfile*' diff --git a/.github/workflows/shared-swift.yml b/.github/workflows/shared-swift.yml index 399b9e2f452..fa13d6e9a4c 100644 --- a/.github/workflows/shared-swift.yml +++ b/.github/workflows/shared-swift.yml @@ -8,8 +8,8 @@ on: pull_request: paths: - 'FirebaseSharedSwift**' - # - '.github/workflows/shared-swift.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/shared-swift.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - 'Gemfile*' diff --git a/.github/workflows/spm.yml b/.github/workflows/spm.yml index a023f275a04..660813ca83c 100644 --- a/.github/workflows/spm.yml +++ b/.github/workflows/spm.yml @@ -4,7 +4,7 @@ on: workflow_dispatch: pull_request: paths: - # - '.github/workflows/spm.yml' + - '.github/workflows/spm.yml' # - 'Package.swift' - '.swiftpm/*' - 'scripts/build.sh' diff --git a/.github/workflows/storage.yml b/.github/workflows/storage.yml index 981098a6885..9aae03de131 100644 --- a/.github/workflows/storage.yml +++ b/.github/workflows/storage.yml @@ -9,8 +9,8 @@ on: paths: - 'FirebaseStorage**' - 'FirebaseAuth/Interop/*.h' - # - '.github/workflows/storage.yml' - # - '.github/workflows/common.yml' + - '.github/workflows/storage.yml' + - '.github/workflows/common.yml' - '.github/workflows/common_cocoapods.yml' - '.github/workflows/common_catalyst.yml' - '.github/workflows/common_quickstart.yml' From 3c79b4e35ebb26dda3841abf6eacefc9e0dd450b Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 22:36:39 -0500 Subject: [PATCH 34/36] Update .github/workflows/spm.yml --- .github/workflows/spm.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/spm.yml b/.github/workflows/spm.yml index 660813ca83c..eb0dba8c438 100644 --- a/.github/workflows/spm.yml +++ b/.github/workflows/spm.yml @@ -5,7 +5,7 @@ on: pull_request: paths: - '.github/workflows/spm.yml' - # - 'Package.swift' + - 'Package.swift' - '.swiftpm/*' - 'scripts/build.sh' - 'SwiftPMTests/*' From 36a34059e67de869ee4f1f1c14c6e8bc7bc71d2a Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 22:36:49 -0500 Subject: [PATCH 35/36] Update .github/workflows/firestore.yml --- .github/workflows/firestore.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/firestore.yml b/.github/workflows/firestore.yml index 40f6edbb924..4c3e9726425 100644 --- a/.github/workflows/firestore.yml +++ b/.github/workflows/firestore.yml @@ -59,7 +59,7 @@ jobs: - 'FirebaseFirestore.podspec' # Package.swift - # - 'Package.swift' + - 'Package.swift' # CMake - '**CMakeLists.txt' From 5e79ff3490d3ec942d64910fd93c38e192ee9b4b Mon Sep 17 00:00:00 2001 From: Nick Cooke <36927374+ncooke3@users.noreply.github.com> Date: Mon, 15 Dec 2025 22:37:19 -0500 Subject: [PATCH 36/36] Apply suggestion from @ncooke3 --- Crashlytics/Crashlytics/Models/FIRCLSSettings.m | 2 -- 1 file changed, 2 deletions(-) diff --git a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m index 87beb3c744b..80c70a48953 100644 --- a/Crashlytics/Crashlytics/Models/FIRCLSSettings.m +++ b/Crashlytics/Crashlytics/Models/FIRCLSSettings.m @@ -192,8 +192,6 @@ - (void)deleteCachedSettings { __weak FIRCLSSettings *weakSelf = self; #ifndef FIREBASE_IS_NIGHTLY_TESTING dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{ -#else -#error "Mango" #endif __strong FIRCLSSettings *strongSelf = weakSelf; if ([strongSelf.fileManager fileExistsAtPath:strongSelf.fileManager.settingsFilePath]) {