fix: syntax in archiving.yml, more flexible triggering, add permissions (#15632)

Author: ncooke3

.github/workflows/archiving.yml

@@ -1,5 +1,8 @@
 name: archiving
 
+permissions:
+  contents: read
+
 on:
   workflow_dispatch:
   pull_request:
@@ -18,8 +21,7 @@ jobs:
   # Archive tests for pods that support iOS only.
   pods-ios-only-cron:
     # Don't run on private repo.
-    if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule')
-
+    if: github.repository == 'Firebase/firebase-ios-sdk'
     runs-on: macos-15
     strategy:
       matrix:
@@ -44,8 +46,7 @@ jobs:
   # Archive tests for pods that support iOS, tvOS, and macOS.
   pods-ios-tvos-macos-cron:
     # Don't run on private repo.
-    if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule')
-
+    if: github.repository == 'Firebase/firebase-ios-sdk'
     runs-on: macos-15
     strategy:
       matrix:
@@ -63,7 +64,7 @@ jobs:
       uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3
       with:
         # Firestore gets a 60 min. timeout, everything else gets 20 min.
-        timeout_minutes: ${{ matrix.pod == "FirebaseFirestore" && 60 || 20 }}
+        timeout_minutes: ${{ matrix.pod == 'FirebaseFirestore' && 60 || 20 }}
         max_attempts: 3
         retry_wait_seconds: 300
         command: scripts/test_archiving.sh ${{ matrix.pod }} ${{ matrix.target }} ArchiveOutputs/${{ matrix.target }}.xcarchive