diff --git a/.rubocop.yml b/.rubocop.yml index c8020d2..5380e6c 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -121,7 +121,7 @@ Layout/SpaceAroundOperators: Exclude: - "**/spec/actions_specs/xcodebuild_spec.rb" AllCops: - TargetRubyVersion: 2.0 + TargetRubyVersion: 2.3 Include: - "*/lib/assets/*Template" - "*/lib/assets/*TemplateAndroid" diff --git a/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb b/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb index 69b62fc..dcd2196 100644 --- a/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb +++ b/lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb @@ -162,7 +162,8 @@ def self.xcode_archive_path end def self.lane_platform - Actions.lane_context[Actions::SharedValues::PLATFORM_NAME] + # to_sym shouldn't be necessary, but possibly fixes #376 + Actions.lane_context[Actions::SharedValues::PLATFORM_NAME]&.to_sym end def self.platform_from_app_id(app_id) @@ -193,6 +194,9 @@ def self.get_binary_path(platform, params) Dir["*.apk"].last || Dir[File.join("app", "build", "outputs", "apk", "release", "app-release.apk")].last end + + UI.error("Unable to determine binary path for unsupported platform #{platform}.") + nil end def self.get_upload_timeout(params) @@ -586,11 +590,7 @@ def self.available_options end def self.is_supported?(platform) - # Adjust this if your plugin only works for a particular platform (iOS vs. Android, for example) - # See: https://docs.fastlane.tools/advanced/#control-configuration-by-lane-and-by-platform - # - # [:ios, :mac, :android].include?(platform) - true + [:ios, :android].include?(platform) end def self.example_code