-
Notifications
You must be signed in to change notification settings - Fork 46
Add extra programs #6
base: master
Are you sure you want to change the base?
Conversation
|
I won't merge it but will keep the PR open, in order to have a netlify preview link. |
fixed it, misplaced a file |
|
✔️ Deploy Preview for boring-visvesvaraya-dbefd4 ready! 🔨 Explore the source changes: f6d5f34 🔍 Inspect the deploy log: https://app.netlify.com/sites/boring-visvesvaraya-dbefd4/deploys/60e1704f59d435000727bc53 😎 Browse the preview: https://deploy-preview-6--boring-visvesvaraya-dbefd4.netlify.app/ |
|
Works for me! |
|
So why aren't we merging? I understand this is just a Proof of Concept but why aren't more services better? |
|
@darthnithin I'd prefer to keep the demo simple enough in order to provide fast identification. More apps would take more time to process. |
|
I guess that makes sense, but the pr build is not that much slower |
|
It depends on a browser actually. Currently Chromium browsers take about a second to check each application, so adding 24 new apps will increase the demo process time twice up to 1 minute. As for me, it is too long and boring. Also, we will need to make a new CAPTCHA for the Tor Browser with 58 symbols to type, which is also quite boring for the demo. |
|
Maybe a button: "Want a more accurate fingerprint?" that runs all of the tests instead of a smaller set of them? |
if anyone could test this for me to see if it works, that would be a huge help.
i did this pull request just because i realised that there are some commonly used apps with app launch things and i wanted to add it to the original
don't expect me to do much else to this project, though