Fix: Fixed PNG-based .ico files rendering with black backgrounds (#17924)

kalmix · web-flow · commit 4abd5f245cc2 · 2025-12-03T10:34:58.000-05:00
diff --git a/src/Files.App/Helpers/Win32/Win32Helper.Storage.cs b/src/Files.App/Helpers/Win32/Win32Helper.Storage.cs
@@ -488,7 +488,7 @@ private static bool IsAlphaBitmap(BitmapData bmpData)
 					Color pixelColor = Color.FromArgb(
 						Marshal.ReadInt32(bmpData.Scan0, (bmpData.Stride * y) + (4 * x)));
 
-					if (pixelColor.A > 0 & pixelColor.A < 255)
+					if (pixelColor.A < 255)
 						return true;
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -488,7 +488,7 @@ private static bool IsAlphaBitmap(BitmapData bmpData)`
`488`	`488`	`Color pixelColor = Color.FromArgb(`
`489`	`489`	`Marshal.ReadInt32(bmpData.Scan0, (bmpData.Stride * y) + (4 * x)));`
`490`	`490`
`491`		`- if (pixelColor.A > 0 & pixelColor.A < 255)`
	`491`	`+ if (pixelColor.A < 255)`
`492`	`492`	`return true;`
`493`	`493`	`}`
`494`	`494`	`}`