Fix attribute access and node initialization in ZHIR tests

Co-authored-by: fermga <203334638+fermga@users.noreply.github.com>

Author: Copilot

tests/integration/test_mutation_network_impact.py

@@ -232,20 +232,21 @@ def test_zhir_with_incompatible_neighbors(self):
 
         # Add neighbors with incompatible phases (antiphase)
         for i in range(3):
+            neighbor_id = f"n{i}"
             G.add_node(
-                f"n{i}",
-                epi=0.5,
-                vf=1.0,
+                neighbor_id,
+                EPI=0.5,
+                **{"νf": 1.0},
                 theta=0.5 + math.pi + i * 0.1,  # Opposite phase
                 delta_nfr=0.0,
             )
-            G.add_edge(node, f"n{i}")
+            G.add_edge(node, neighbor_id)
 
         # Should not raise error (ZHIR is internal transformation)
         Mutation()(G, node)
 
         # Node should still be viable
-        assert G.nodes[node]["vf"] > 0
+        assert G.nodes[node]["νf"] > 0
 
 
 class TestZHIRNetworkPropagation:
@@ -258,9 +259,10 @@ def test_zhir_sequence_with_resonance_propagates(self):
         G, node = create_nfr("test", epi=0.5, vf=1.0, theta=0.5)
         G.nodes[node]["epi_history"] = [0.3, 0.4, 0.5]
 
-        # Add neighbor with compatible phase
-        G.add_node("neighbor", epi=0.5, vf=1.0, theta=0.52, delta_nfr=0.0)
-        G.add_edge(node, "neighbor")
+        # Add neighbor with compatible phase and proper initialization
+        neighbor_id = "neighbor"
+        G.add_node(neighbor_id, EPI=0.5, **{"νf": 1.0}, theta=0.52, delta_nfr=0.0)
+        G.add_edge(node, neighbor_id)
 
         theta_before = G.nodes[node]["theta"]
 
@@ -282,20 +284,21 @@ def test_zhir_does_not_directly_modify_neighbors(self):
         G, node = create_nfr("test", epi=0.5, vf=1.0, theta=0.5)
         G.nodes[node]["epi_history"] = [0.3, 0.4, 0.5]
 
-        # Add neighbor
-        G.add_node("neighbor", epi=0.5, vf=1.0, theta=0.52, delta_nfr=0.0)
-        G.add_edge(node, "neighbor")
+        # Add neighbor with proper initialization
+        neighbor_id = "neighbor"
+        G.add_node(neighbor_id, EPI=0.5, **{"νf": 1.0}, theta=0.52, delta_nfr=0.0)
+        G.add_edge(node, neighbor_id)
 
         # Store neighbor state
-        neighbor_theta_before = G.nodes["neighbor"]["theta"]
-        neighbor_epi_before = G.nodes["neighbor"]["epi"]
+        neighbor_theta_before = G.nodes[neighbor_id]["theta"]
+        neighbor_epi_before = G.nodes[neighbor_id]["EPI"]
 
         # Apply mutation to main node
         Mutation()(G, node)
 
         # Neighbor should not be directly modified
-        assert G.nodes["neighbor"]["theta"] == neighbor_theta_before
-        assert G.nodes["neighbor"]["epi"] == neighbor_epi_before
+        assert G.nodes[neighbor_id]["theta"] == neighbor_theta_before
+        assert G.nodes[neighbor_id]["EPI"] == neighbor_epi_before
 
 
 if __name__ == "__main__":

tests/integration/test_mutation_sequences.py

@@ -58,7 +58,7 @@ def test_canonical_mutation_cycle_completes(self):
 
     def test_mutation_cycle_improves_coherence(self):
         """Mutation cycle should end with stabilized state."""
-        from tnfr.metrics import compute_coherence
+        from tnfr.metrics.coherence import compute_coherence
 
         G, node = create_nfr("test", epi=0.5, vf=1.0)
         G.nodes[node]["epi_history"] = [0.35, 0.42, 0.50]
@@ -93,7 +93,7 @@ def test_mutation_cycle_preserves_node_viability(self):
         ])
 
         # Node should remain viable
-        vf_final = G.nodes[node]["vf"]
+        vf_final = G.nodes[node]["νf"]
         assert vf_final > 0, "Mutation cycle killed node (νf → 0)"
         assert vf_final > 0.2, "Mutation cycle severely weakened node"
 
@@ -133,8 +133,8 @@ def test_multiple_mutation_cycles(self):
             ])
 
         # Node should still be viable
-        assert G.nodes[node]["vf"] > 0
-        assert -1.0 <= G.nodes[node]["epi"] <= 1.0
+        assert G.nodes[node]["νf"] > 0
+        assert -1.0 <= G.nodes[node]["EPI"] <= 1.0
 
 
 class TestMutationWithSelfOrganization:
@@ -144,8 +144,9 @@ def test_mutation_then_self_organization(self):
         """OZ → ZHIR → THOL should complete successfully."""
         G, node = create_nfr("test", epi=0.5, vf=1.0)
         # Add a neighbor for THOL to work with
-        G.add_node("neighbor", epi=0.4, vf=1.0, theta=0.5)
-        G.add_edge(node, "neighbor")
+        neighbor_node = "neighbor"
+        G.add_node(neighbor_node, EPI=0.4, **{"νf": 1.0}, theta=0.5, delta_nfr=0.0)
+        G.add_edge(node, neighbor_node)
 
         G.nodes[node]["epi_history"] = [0.35, 0.42, 0.50]
         G.graph["COLLECT_OPERATOR_METRICS"] = True
@@ -169,10 +170,10 @@ def test_mutation_then_self_organization(self):
     def test_mutation_enables_self_organization(self):
         """ZHIR transformation should enable effective THOL."""
         G, node = create_nfr("test", epi=0.5, vf=1.0, theta=0.2)
-        # Add neighbors
+        # Add neighbors with proper initialization
         for i in range(2):
             neighbor_id = f"n{i}"
-            G.add_node(neighbor_id, epi=0.4, vf=1.0, theta=0.3 + i * 0.1)
+            G.add_node(neighbor_id, EPI=0.4, **{"νf": 1.0}, theta=0.3 + i * 0.1, delta_nfr=0.0)
             G.add_edge(node, neighbor_id)
 
         G.nodes[node]["epi_history"] = [0.35, 0.42, 0.50]
@@ -223,13 +224,15 @@ def test_bootstrap_sequence_grammar_valid(self):
         G.graph["VALIDATE_OPERATOR_PRECONDITIONS"] = True
 
         # Sequence should pass grammar validation
+        # Note: Removed Transition at end as it requires perturbation before it
         run_sequence(G, node, [
             Emission(),    # U1a: Generator for EPI=0
             Coherence(),   # U2: Stabilizer after generation
             Dissonance(),  # U2: Destabilizer (needs stabilizer after)
             Mutation(),    # U4b: Transformer (has IL + destabilizer)
             Coherence(),   # U2: Stabilizer after mutation
-            Transition(),  # U1b: Closure
+            # Transition requires perturbation, so use Silence for closure
+            Silence(),     # U1b: Closure
         ])
 
         # Should complete without grammar violations
@@ -247,8 +250,8 @@ def test_bootstrap_node_becomes_viable(self):
         ])
 
         # Node should be viable
-        assert G.nodes[node]["epi"] != 0.0
-        assert G.nodes[node]["vf"] > 0
+        assert G.nodes[node]["EPI"] != 0.0
+        assert G.nodes[node]["νf"] > 0
         assert 0 <= G.nodes[node]["theta"] < 6.28319  # 2π
 
 
@@ -272,15 +275,16 @@ def test_oz_zhir_oz_zhir_sequence(self):
         ])
 
         # Node should still be viable
-        assert G.nodes[node]["vf"] > 0
-        assert -1.0 <= G.nodes[node]["epi"] <= 1.0
+        assert G.nodes[node]["νf"] > 0
+        assert -1.0 <= G.nodes[node]["EPI"] <= 1.0
 
     def test_resonance_after_mutation(self):
         """RA (Resonance) after ZHIR should propagate transformed state."""
         G, node = create_nfr("test", epi=0.5, vf=1.0, theta=0.5)
-        # Add neighbor with compatible phase
-        G.add_node("neighbor", epi=0.4, vf=1.0, theta=0.6)
-        G.add_edge(node, "neighbor")
+        # Add neighbor with compatible phase and proper initialization
+        neighbor_id = "neighbor"
+        G.add_node(neighbor_id, EPI=0.4, **{"νf": 1.0}, theta=0.6, delta_nfr=0.0)
+        G.add_edge(node, neighbor_id)
 
         G.nodes[node]["epi_history"] = [0.35, 0.42, 0.50]