Merge pull request #2827 from fermga/copilot/run-copilot-code-review

Fix import errors, remove outdated tests, and apply code formatting

Author: fermga

src/tnfr/alias.py

@@ -291,11 +291,11 @@ def get_attr(
     conv: Callable[[Any], T] = _bepi_to_float,
 ) -> T | None:
     """Return the value for the first key in ``aliases`` found in ``d``.
-    
+
     WARNING: This function searches for keys in alias order. If you manually
     wrote to a non-canonical key (e.g., 'vf' instead of 'νf'), this function
     will NOT find it and will return the default value instead.
-    
+
     For structural frequency: ALWAYS use set_vf() to write, not d['vf'] = value.
     See module docstring for detailed guidance on canonical attribute access.
     """
@@ -400,13 +400,13 @@ def set_attr_generic(
     conv: Callable[[Any], T],
 ) -> T:
     """Assign ``value`` to the FIRST (canonical) alias key in ``aliases``.
-    
+
     CRITICAL: This function writes to the FIRST key in the alias tuple.
     For ALIAS_VF = ('νf', 'nu_f', ...), this writes to 'νf' (Greek nu), NOT 'vf'.
-    
+
     If you later try to read with G.nodes[n]['vf'], you will NOT find the value.
     ALWAYS use get_attr() to read what set_attr() wrote.
-    
+
     For high-level usage, prefer set_vf(), set_theta(), etc. which handle this correctly.
     See module docstring for detailed guidance on canonical attribute access.
     """

src/tnfr/cli/validate.py

@@ -146,6 +146,7 @@ def main():
     # Handle interactive mode
     if args.interactive:
         from .interactive_validator import run_interactive_validator
+
         return run_interactive_validator(seed=args.seed)
 
     # Require graph_file for non-interactive mode

src/tnfr/config/operator_names.py

@@ -120,9 +120,9 @@
 # R4 Extended: Bifurcation windows by destabilizer intensity
 # These define how many operators can separate a destabilizer from a transformer
 BIFURCATION_WINDOWS = {
-    'strong': 4,    # OZ permits ZHIR/THOL within 4 operators
-    'moderate': 2,  # NAV/VAL permit ZHIR/THOL within 2 operators
-    'weak': 1,      # EN requires ZHIR/THOL as immediate successor
+    "strong": 4,  # OZ permits ZHIR/THOL within 4 operators
+    "moderate": 2,  # NAV/VAL permit ZHIR/THOL within 2 operators
+    "weak": 1,  # EN requires ZHIR/THOL as immediate successor
 }
 
 
@@ -175,42 +175,42 @@ def operator_display_name(name: str) -> str:
 
 def validate_physics_derivation() -> dict[str, Any]:
     """Validate that operator sets are consistent with TNFR physics derivation.
-    
+
     This function verifies that VALID_START_OPERATORS and VALID_END_OPERATORS
     match what would be derived from first principles using the physics_derivation
     module.
-    
+
     Returns
     -------
     dict[str, Any]
         Validation report with keys:
         - "start_operators_valid": bool
-        - "end_operators_valid": bool  
+        - "end_operators_valid": bool
         - "start_operators_expected": frozenset
         - "start_operators_actual": frozenset
         - "end_operators_expected": frozenset
         - "end_operators_actual": frozenset
         - "discrepancies": list of str
-        
+
     Notes
     -----
     This function is primarily for testing and validation. It ensures that
     any manual updates to VALID_START_OPERATORS or VALID_END_OPERATORS remain
     consistent with TNFR canonical physics.
-    
+
     If discrepancies are found, the function logs warnings but does not raise
     exceptions, allowing for intentional overrides with clear audit trail.
     """
     from .physics_derivation import (
         derive_start_operators_from_physics,
         derive_end_operators_from_physics,
     )
-    
+
     expected_starts = derive_start_operators_from_physics()
     expected_ends = derive_end_operators_from_physics()
-    
+
     discrepancies = []
-    
+
     start_valid = VALID_START_OPERATORS == expected_starts
     if not start_valid:
         missing = expected_starts - VALID_START_OPERATORS
@@ -223,7 +223,7 @@ def validate_physics_derivation() -> dict[str, Any]:
             discrepancies.append(
                 f"VALID_START_OPERATORS contains non-physics operators: {extra}"
             )
-    
+
     end_valid = VALID_END_OPERATORS == expected_ends
     if not end_valid:
         missing = expected_ends - VALID_END_OPERATORS
@@ -236,7 +236,7 @@ def validate_physics_derivation() -> dict[str, Any]:
             discrepancies.append(
                 f"VALID_END_OPERATORS contains non-physics operators: {extra}"
             )
-    
+
     return {
         "start_operators_valid": start_valid,
         "end_operators_valid": end_valid,