feat(pxtorem): add validation for number type and update tests for error handling

Author: felixicaza

packages/pxtorem/src/index.ts

@@ -1,5 +1,5 @@
 import { type LengthValue, type LengthUnit } from 'lightningcss'
-import { validatePositiveInteger } from './utils/errorHandler'
+import { validateIsNumber, validatePositiveInteger } from './utils/errorHandler'
 import type { Config } from './contracts/config.type'
 
 const defultConfig: Config = {
@@ -21,6 +21,9 @@ function pxtorem(config: Partial<Config> = {}) {
 
   validatePositiveInteger(rootValue, 'rootValue')
   validatePositiveInteger(unitPrecision, 'unitPrecision')
+  validateIsNumber(rootValue, 'rootValue')
+  validateIsNumber(unitPrecision, 'unitPrecision')
+  validateIsNumber(minValue, 'minValue')
 
   const toFixed = (value: number, precision: number): number => {
     const factor = Math.pow(10, precision)

packages/pxtorem/src/utils/errorHandler.ts

@@ -1,8 +1,10 @@
-export function validatePositiveInteger(value: number | undefined, name: string) {
+export function validateIsNumber(value: number | undefined, name: string) {
   if (typeof value !== 'number' || isNaN(value)) {
     throw new Error(`Invalid ${name}: must be a valid number.`)
   }
+}
 
+export function validatePositiveInteger(value: number, name: string) {
   if (value < 0) {
     throw new Error(`Invalid ${name}: must not be negative.`)
   }

packages/pxtorem/test/index.test.ts

@@ -1,7 +1,7 @@
 import { describe, expect, it } from 'vitest'
 import { composeVisitors, transform } from 'lightningcss'
 import pxtorem from '../src/index'
-import { validatePositiveInteger } from '../src/utils/errorHandler'
+import { validatePositiveInteger, validateIsNumber } from '../src/utils/errorHandler'
 
 describe('pxtorem plugin', () => {
   it('should convert pixel to rem using default configuration', () => {
@@ -251,24 +251,33 @@ describe('pxtorem plugin', () => {
   })
 })
 
-describe('validatePositiveInteger', () => {
-  it('should throw error for undefined value', () => {
-    expect(() => validatePositiveInteger(undefined, 'rootValue')).toThrowError('Invalid rootValue: must be a valid number.')
-  })
-
-  it('should throw error for NaN value', () => {
-    expect(() => validatePositiveInteger(NaN, 'rootValue')).toThrowError('Invalid rootValue: must be a valid number.')
-  })
-
+describe('validate errors', () => {
   it('should throw error for negative value', () => {
     expect(() => validatePositiveInteger(-1, 'rootValue')).toThrowError('Invalid rootValue: must not be negative.')
   })
 
   it('should throw error for decimal value', () => {
-    expect(() => validatePositiveInteger(1.5, 'rootValue')).toThrowError('Invalid rootValue: must not be a decimal.')
+    expect(() => validatePositiveInteger(1.5, 'unitPrecision')).toThrowError('Invalid unitPrecision: must not be a decimal.')
   })
 
   it('should pass for valid integer value', () => {
-    expect(() => validatePositiveInteger(1, 'rootValue')).not.toThrow()
+    expect(() => validatePositiveInteger(1, 'minValue')).not.toThrow()
+  })
+
+  it('should throw error for non-number value', () => {
+    // @ts-expect-error
+    expect(() => validateIsNumber('10', 'rootValue')).toThrowError('Invalid rootValue: must be a valid number.')
+  })
+
+  it('should pass for valid number value', () => {
+    expect(() => validateIsNumber(1, 'unitPrecision')).not.toThrow()
+  })
+
+  it('should pass for valid negative number value', () => {
+    expect(() => validateIsNumber(-10, 'rootValue')).not.toThrow()
+  })
+
+  it('should pass for valid float number value', () => {
+    expect(() => validateIsNumber(10.50, 'minValue')).not.toThrow()
   })
 })