Skip to content

Commit 5ff473f

Browse files
committed
appskeleton: fix some formatting and typos
1 parent 7ab413e commit 5ff473f

File tree

5 files changed

+63
-65
lines changed

5 files changed

+63
-65
lines changed

puremvc-haxe-demo-feathersui-appskeleton/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ This project includes an [_project.xml_](https://lime.software/docs/project-file
1414

1515
### Prerequisites
1616

17-
- [Install Haxe 4.0.0 or newer](https://haxe.org/download/).
17+
- [Install Haxe 4.0.0 or newer](https://haxe.org/download/)
1818
- [Install Feathers UI from Haxelib](https://feathersui.com/learn/haxe-openfl/installation/)
1919

2020
### Command Line

puremvc-haxe-demo-feathersui-appskeleton/src/org/puremvc/haxe/demos/feathersui/appskeleton/model/ConfigProxy.hx

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ class ConfigProxy extends Proxy implements IResourceProxy {
4343
setData({});
4444
}
4545

46-
/*
47-
* Load the xml file, this method is called by StartupMonitorProxy
48-
*/
46+
/**
47+
Load the xml file, this method is called by StartupMonitorProxy
48+
**/
4949
public function load():Void {
5050
// create a worker who will go get some data
5151
// pass it a reference to this proxy so the delegate knows where to return the data
@@ -54,11 +54,11 @@ class ConfigProxy extends Proxy implements IResourceProxy {
5454
delegate.load();
5555
}
5656

57-
/*
58-
* This is called when the delegate receives a result from the service
59-
*
60-
* @param rpcEvent
61-
*/
57+
/**
58+
This is called when the delegate receives a result from the service
59+
60+
@param rpcEvent
61+
**/
6262
public function result(result:Xml):Void {
6363
// call the helper class for parse the XML data
6464
XmlResource.parse(data, result);
@@ -70,52 +70,52 @@ class ConfigProxy extends Proxy implements IResourceProxy {
7070
sendNotification(ConfigProxy.LOAD_SUCCESSFUL);
7171
}
7272

73-
/*
74-
* This is called when the delegate receives a fault from the service
75-
*
76-
* @param rpcEvent
77-
*/
73+
/**
74+
This is called when the delegate receives a fault from the service
75+
76+
@param rpcEvent
77+
**/
7878
public function fault(rpcEvent:Dynamic):Void {
7979
// send the failed notification
8080
sendNotification(ConfigProxy.LOAD_FAILED, ConfigProxy.ERROR_LOAD_FILE);
8181
}
8282

8383
/**
84-
* Get the config value
85-
*
86-
* @param key the key to read
87-
* @return String the key value stored in internal object
88-
*/
84+
Get the config value
85+
86+
@param key the key to read
87+
@return String the key value stored in internal object
88+
**/
8989
public function getValue(key:String):String {
9090
return Reflect.field(data, key.toLowerCase());
9191
}
9292

9393
/**
94-
* Get the config numeric value
95-
*
96-
* @param key the key to read
97-
* @return Number the key value stored in internal object
98-
*/
94+
Get the config numeric value
95+
96+
@param key the key to read
97+
@return Number the key value stored in internal object
98+
**/
9999
public function getNumber(key:String):Float {
100100
return Std.parseFloat(Reflect.field(data, key.toLowerCase()));
101101
}
102102

103103
/**
104-
* Get the config boolean value
105-
*
106-
* @param key the key to read
107-
* @return Boolean the key value stored in internal object
108-
*/
104+
Get the config boolean value
105+
106+
@param key the key to read
107+
@return Boolean the key value stored in internal object
108+
**/
109109
public function getBoolean(key:String):Bool {
110110
return Reflect.field(data, key.toLowerCase()) != null ? Reflect.field(data, key.toLowerCase()).toLowerCase() == "true" : false;
111111
}
112112

113113
/**
114-
* Set the config value if isn't defined
115-
*
116-
* @param key the key to set
117-
* @param value the value
118-
*/
114+
Set the config value if isn't defined
115+
116+
@param key the key to set
117+
@param value the value
118+
**/
119119
public function setDefaultValue(key:String, value:Any):Void {
120120
if (Reflect.field(data, key.toLowerCase()) == null) {
121121
Reflect.setField(data, key.toLowerCase(), value);

puremvc-haxe-demo-feathersui-appskeleton/src/org/puremvc/haxe/demos/feathersui/appskeleton/view/ApplicationMediator.hx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ class ApplicationMediator extends Mediator implements IMediator {
4444
The `ApplicationMediator` constructor also registers the
4545
Mediators for the view components created by the application.
4646
47-
@param object the viewComponent (the ApplicationSkeleton instance in this case)
47+
@param object the viewComponent (the AppSkeleton instance in this case)
4848
**/
4949
public function new(viewComponent:AppSkeleton) {
5050
// pass the viewComponent to the superclass where
@@ -60,13 +60,13 @@ class ApplicationMediator extends Mediator implements IMediator {
6060
}
6161

6262
/**
63-
* List all notifications this Mediator is interested in.
64-
* <P>
65-
* Automatically called by the framework when the mediator
66-
* is registered with the view.</P>
67-
*
68-
* @return Array the list of Nofitication names
69-
*/
63+
List all notifications this Mediator is interested in.
64+
65+
Automatically called by the framework when the mediator
66+
is registered with the view.
67+
68+
@return Array the list of Notification names
69+
**/
7070
override public function listNotificationInterests():Array<String> {
7171
return [ApplicationFacade.VIEW_SPLASH_SCREEN, ApplicationFacade.VIEW_MAIN_SCREEN];
7272
}
@@ -76,7 +76,7 @@ class ApplicationMediator extends Mediator implements IMediator {
7676
7777
Called by the framework when a notification is sent that
7878
this mediator expressed an interest in when registered
79-
(see `listNotificationInterests`.
79+
(see `listNotificationInterests`).
8080
8181
@param INotification a notification
8282
**/

puremvc-haxe-demo-feathersui-appskeleton/src/org/puremvc/haxe/demos/feathersui/appskeleton/view/MainScreenMediator.hx

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ class MainScreenMediator extends Mediator implements IMediator {
2828
private var localeProxy:LocaleProxy;
2929

3030
/**
31-
* Constructor.
32-
*/
31+
Constructor.
32+
**/
3333
public function new(viewComponent:MainScreen) {
3434
// pass the viewComponent to the superclass where
3535
// it will be stored in the inherited viewComponent property
@@ -45,23 +45,21 @@ class MainScreenMediator extends Mediator implements IMediator {
4545
}
4646

4747
/**
48-
* Cast the viewComponent to its actual type.
49-
*
50-
* <P>
51-
* This is a useful idiom for mediators. The
52-
* PureMVC Mediator class defines a viewComponent
53-
* property of type Object. </P>
54-
*
55-
* <P>
56-
* Here, we cast the generic viewComponent to
57-
* its actual type in a protected mode. This
58-
* retains encapsulation, while allowing the instance
59-
* (and subclassed instance) access to a
60-
* strongly typed reference with a meaningful
61-
* name.</P>
62-
*
63-
* @return MainScreen the viewComponent cast to org.puremvc.as3.demos.flex.appskeleton.view.components.MainScreen
64-
*/
48+
Cast the viewComponent to its actual type.
49+
50+
This is a useful idiom for mediators. The
51+
PureMVC Mediator class defines a viewComponent
52+
property of type Object.
53+
54+
Here, we cast the generic viewComponent to
55+
its actual type in a protected mode. This
56+
retains encapsulation, while allowing the instance
57+
(and subclassed instance) access to a
58+
strongly typed reference with a meaningful
59+
name.
60+
61+
@return MainScreen the viewComponent cast to org.puremvc.as3.demos.flex.appskeleton.view.components.MainScreen
62+
**/
6563
private var mainScreen(get, never):MainScreen;
6664

6765
private function get_mainScreen():MainScreen {

puremvc-haxe-demo-feathersui-appskeleton/src/org/puremvc/haxe/demos/feathersui/appskeleton/view/SplashScreenMediator.hx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class SplashScreenMediator extends Mediator implements IMediator {
4141
Automatically called by the framework when the mediator
4242
is registered with the view.
4343
44-
@return Array the list of Nofitication names
44+
@return Array the list of Notification names
4545
**/
4646
override public function listNotificationInterests():Array<String> {
4747
return [
@@ -57,7 +57,7 @@ class SplashScreenMediator extends Mediator implements IMediator {
5757
5858
Called by the framework when a notification is sent that
5959
this mediator expressed an interest in when registered
60-
(see `listNotificationInterests`.</P>
60+
(see `listNotificationInterests`).
6161
6262
@param INotification a notification
6363
**/
@@ -95,7 +95,7 @@ class SplashScreenMediator extends Mediator implements IMediator {
9595
strongly typed reference with a meaningful
9696
name.
9797
98-
@return SplashScreen the viewComponent cast to org.puremvc.as3.demos.flex.appskeleton.view.components.SplashScreen
98+
@return SplashScreen the viewComponent cast to org.puremvc.haxe.demos.feathersui.appskeleton.view.components.SplashScreen
9999
**/
100100
private var splashScreen(get, never):SplashScreen;
101101

0 commit comments

Comments
 (0)