increase test coverage to 100% (#189)

* increase test coverage to 100%

* always test for coverage

Author: Uzlopak

.github/workflows/ci.yml

@@ -53,7 +53,7 @@ jobs:
       - run: |
           npm install --ignore-scripts
           npm run build --if-present
-          npm run test:coverage
+          npm run test
       - name: Coveralls Parallel
         uses: coverallsapp/github-action@1.1.3
         with:

jest.config.json

@@ -0,0 +1,19 @@
+{
+  "collectCoverageFrom": [
+    "src/**/*.js",
+    "!src/example.js",
+    "!src/types/*.js"
+  ],
+  "coverageReporters": [
+    "text",
+    "lcovonly"
+  ],
+  "coverageThreshold": {
+    "global": {
+      "branches": 100,
+      "functions": 100,
+      "lines": 100,
+      "statements": 100
+    }
+  }
+}

package.json

@@ -26,17 +26,6 @@
     "type": "git",
     "url": "https://github.com/fastify/fluent-json-schema.git"
   },
-  "jest": {
-    "collectCoverageFrom": [
-      "src/**/*.js",
-      "!src/example.js",
-      "!src/types/*.js"
-    ],
-    "coverageReporters": [
-      "text",
-      "lcovonly"
-    ]
-  },
   "lint-staged": {
     "*.{json,md,js,ts,yml}": [
       "prettier --write",
@@ -45,8 +34,7 @@
   },
   "scripts": {
     "test": "npm run test:unit && npm run test:typescript",
-    "test:unit": "jest src/*.test.js --verbose",
-    "test:coverage": "jest --coverage && npm run test:typescript",
+    "test:unit": "jest --coverage",
     "test:watch": "jest src/*.test.js --verbose --watch",
     "test:typescript": "tsd",
     "prepare": "husky install",

src/utils.js

@@ -131,8 +131,7 @@ const patchIdsWithParentId = ({ schema, generateIds, parentId }) => {
   return {
     ...schema,
     properties: properties.reduce((memo, [key, props]) => {
-      const target = props.def ? 'definitions' : 'properties'
-      const $id = props.$id || (generateIds ? `#${target}/${key}` : undefined)
+      const $id = props.$id || (generateIds ? `#properties/${key}` : undefined)
       return {
         ...memo,
         [key]: {