Skip to content

Commit ea4cc58

Browse files
authored
pythongh-139817: Fix refleak in TypeAliasType(qualname=non_string) (pythonGH-140197)
1 parent 4641925 commit ea4cc58

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

Objects/typevarobject.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2123,11 +2123,6 @@ typealias_new_impl(PyTypeObject *type, PyObject *name, PyObject *value,
21232123
return NULL;
21242124
}
21252125

2126-
PyObject *module = caller();
2127-
if (module == NULL) {
2128-
return NULL;
2129-
}
2130-
21312126
if (qualname == NULL || qualname == Py_None) {
21322127
// If qualname was not set directly, we use name instead.
21332128
qualname = name;
@@ -2138,6 +2133,11 @@ typealias_new_impl(PyTypeObject *type, PyObject *name, PyObject *value,
21382133
}
21392134
}
21402135

2136+
PyObject *module = caller();
2137+
if (module == NULL) {
2138+
return NULL;
2139+
}
2140+
21412141
PyObject *ta = (PyObject *)typealias_alloc(
21422142
name, qualname, checked_params, NULL, value, module);
21432143
Py_DECREF(module);

0 commit comments

Comments
 (0)