Skip to content

Commit a0a31ab

Browse files
committed
OutputStorage -> OutputStorageConfig
1 parent bc7cb77 commit a0a31ab

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

src/omnipy/api/protocols/public/config.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class IsPrefectEngineConfig(IsEngineConfig, Protocol):
2323

2424
class IsJobConfig(Protocol):
2525
""""""
26-
output_storage: 'IsOutputStorage'
26+
output_storage: 'IsOutputStorageConfig'
2727

2828

2929
class IsDataConfig(Protocol):
@@ -49,24 +49,24 @@ class IsRootLogConfig(Protocol):
4949
file_log_path: str
5050

5151

52-
class IsOutputStorageBase(Protocol):
52+
class IsOutputStorageConfigBase(Protocol):
5353
persist_data_dir_path: str
5454

5555

56-
class IsLocalOutputStorage(IsOutputStorageBase, Protocol):
56+
class IsLocalOutputStorageConfig(IsOutputStorageConfigBase, Protocol):
5757
...
5858

5959

60-
class IsS3OutputStorage(IsOutputStorageBase, Protocol):
60+
class IsS3OutputStorageConfig(IsOutputStorageConfigBase, Protocol):
6161
endpoint_url: str
6262
access_key: str
6363
secret_key: str
6464
bucket_name: str
6565

6666

67-
class IsOutputStorage(Protocol):
67+
class IsOutputStorageConfig(Protocol):
6868
persist_outputs: ConfigPersistOutputsOptions
6969
restore_outputs: ConfigRestoreOutputsOptions
7070
protocol: ConfigOutputStorageProtocolOptions
71-
local: IsLocalOutputStorage
72-
s3: IsS3OutputStorage
71+
local: IsLocalOutputStorageConfig
72+
s3: IsS3OutputStorageConfig

src/omnipy/config/job.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,22 @@
55
from omnipy.api.enums import (ConfigOutputStorageProtocolOptions,
66
ConfigPersistOutputsOptions,
77
ConfigRestoreOutputsOptions)
8-
from omnipy.api.protocols.public.config import (IsLocalOutputStorage,
9-
IsOutputStorage,
10-
IsS3OutputStorage)
8+
from omnipy.api.protocols.public.config import (IsLocalOutputStorageConfig,
9+
IsOutputStorageConfig,
10+
IsS3OutputStorageConfig)
1111

1212

1313
def _get_persist_data_dir_path() -> str:
1414
return str(Path.cwd().joinpath(Path('outputs')))
1515

1616

1717
@dataclass
18-
class LocalOutputStorage:
18+
class LocalOutputStorageConfig:
1919
persist_data_dir_path: str = field(default_factory=_get_persist_data_dir_path)
2020

2121

2222
@dataclass
23-
class S3OutputStorage:
23+
class S3OutputStorageConfig:
2424
persist_data_dir_path: str = os.path.join('omnipy', 'outputs')
2525
endpoint_url: str = ''
2626
bucket_name: str = ''
@@ -29,16 +29,16 @@ class S3OutputStorage:
2929

3030

3131
@dataclass
32-
class OutputStorage:
32+
class OutputStorageConfig:
3333
persist_outputs: ConfigPersistOutputsOptions = \
3434
ConfigPersistOutputsOptions.ENABLE_FLOW_AND_TASK_OUTPUTS
3535
restore_outputs: ConfigRestoreOutputsOptions = \
3636
ConfigRestoreOutputsOptions.DISABLED
3737
protocol: ConfigOutputStorageProtocolOptions = ConfigOutputStorageProtocolOptions.LOCAL
38-
local: IsLocalOutputStorage = field(default_factory=LocalOutputStorage)
39-
s3: IsS3OutputStorage = field(default_factory=S3OutputStorage)
38+
local: IsLocalOutputStorageConfig = field(default_factory=LocalOutputStorageConfig)
39+
s3: IsS3OutputStorageConfig = field(default_factory=S3OutputStorageConfig)
4040

4141

4242
@dataclass
4343
class JobConfig:
44-
output_storage: IsOutputStorage = field(default_factory=OutputStorage)
44+
output_storage: IsOutputStorageConfig = field(default_factory=OutputStorageConfig)

0 commit comments

Comments
 (0)