TO_BOOL optimizations

Summary:
There's a number of optimizations that can be applied to `TO_BOOL`.

If we're doing a `LOAD_CONST` and then `TO_BOOL` it can be calculated statically.

If we're doing a compare then there's a special form that ensures a bool is pushed instead of doing the conversion in the byte code.

Reviewed By: alexmalyshev

Differential Revision: D80763700

fbshipit-source-id: 4ad34ff26055b4ddb1ec7c3c9184d3bb2d9112dc

Author: DinoV

cinderx/PythonLib/cinderx/compiler/flow_graph_optimizer.py

@@ -761,7 +761,17 @@ def opt_load_const(
             instr.ioparg = instr.oparg
             instr.opname = "LOAD_SMALL_INT"
 
-        if next_instr is not None and next_instr.opname == "IS_OP":
+        if next_instr is None:
+            return
+
+        if next_instr.opname == "TO_BOOL":
+            val = bool(instr.oparg)
+            index = self.graph.convertArg("LOAD_CONST", val)
+            instr.set_to_nop_no_loc()
+            next_instr.opname = "LOAD_CONST"
+            next_instr.oparg = val
+            next_instr.ioparg = index
+        elif next_instr.opname == "IS_OP":
             return self.opt_load_const_is(instr_index, instr, next_instr, target, block)
         else:
             # The rest of the optimizations are common to 3.10 and 3.12
@@ -887,11 +897,24 @@ def fold_tuple_on_constants(
         instr.oparg = newconst
         instr.ioparg = self.graph.convertArg("LOAD_CONST", newconst)
 
+    def optimize_compare_op(
+        self: FlowGraphOptimizer,
+        instr_index: int,
+        instr: Instruction,
+        next_instr: Instruction | None,
+        target: Instruction | None,
+        block: Block,
+    ) -> int | None:
+        if next_instr and next_instr.opname == "TO_BOOL":
+            instr.ioparg |= 16
+            next_instr.set_to_nop()
+
     handlers: dict[str, Handler] = {
         **FlowGraphOptimizer312.handlers,
         "LOAD_CONST": opt_load_const,
         "JUMP_IF_FALSE": opt_jump_if,
         "JUMP_IF_TRUE": opt_jump_if,
         "BUILD_LIST": optimize_lists_and_sets,
         "BUILD_SET": optimize_lists_and_sets,
+        "COMPARE_OP": optimize_compare_op,
     }