Remove redundant dereferences

Summary: Clippy said that were redundant.

Reviewed By: JakobDegen

Differential Revision: D47226541

fbshipit-source-id: 5e1cdc0badc8f4d027942660e2a26a58cc08ba52

Author: ndmitchell

starlark/src/eval/compiler/def.rs

@@ -417,7 +417,7 @@ impl Compiler<'_, '_, '_> {
 
         self.enter_scope(scope_id);
 
-        let docstring = DocString::extract_raw_starlark_docstring(&suite);
+        let docstring = DocString::extract_raw_starlark_docstring(suite);
         let body = self.stmt(suite, false);
         let scope_id = self.exit_scope();
         let scope_names = self.scope_data.get_scope(scope_id);

starlark/src/eval/compiler/module.rs

@@ -68,11 +68,11 @@ impl<'v> Compiler<'v, '_, '_> {
                     self.eval,
                 ));
             }
-            Some(loader) => expr_throw(loader.load(&name), span, self.eval)?,
+            Some(loader) => expr_throw(loader.load(name), span, self.eval)?,
         };
 
         for (our_name, their_name) in &load.node.args {
-            let (slot, _captured) = self.scope_data.get_assign_ident_slot(&our_name);
+            let (slot, _captured) = self.scope_data.get_assign_ident_slot(our_name);
             let slot = match slot {
                 Slot::Local(..) => unreachable!("symbol need to be resolved to module"),
                 Slot::Module(slot) => slot,

starlark/src/eval/compiler/stmt.rs

@@ -471,7 +471,7 @@ impl Compiler<'_, '_, '_> {
                 })
             }
             AssignP::Identifier(ident) => {
-                let (slot, captured) = self.scope_data.get_assign_ident_slot(&ident);
+                let (slot, captured) = self.scope_data.get_assign_ident_slot(ident);
                 match (slot, captured) {
                     (Slot::Local(slot), Captured::No) => {
                         let lhs = IrSpanned {