Invalidate displayLink & deallocate RCTAnimatedModuleProvider before ReactHost teardown (#54712)

zeyap · meta-codesync[bot] · commit 7c603ee261c3 · 2025-11-26T15:45:07.000-08:00
Summary: Pull Request resolved: #54712 ## Changelog: [iOS] [Added] - Allow invalidateDisplayLink on RCTAnimatedModuleProvider Reviewed By: sammy-SC Differential Revision: D87929762 fbshipit-source-id: 116661a96154cdf108e7c1a6e7f09f49275529b7
diff --git a/packages/react-native/ReactApple/RCTAnimatedModuleProvider/RCTAnimatedModuleProvider.h b/packages/react-native/ReactApple/RCTAnimatedModuleProvider/RCTAnimatedModuleProvider.h
@@ -19,6 +19,8 @@ class TurboModule;
 
 @interface RCTAnimatedModuleProvider : NSObject
 
+- (void)invalidate;
+
 - (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const std::string &)name
                                                       jsInvoker:
                                                           (std::shared_ptr<facebook::react::CallInvoker>)jsInvoker;
diff --git a/packages/react-native/ReactApple/RCTAnimatedModuleProvider/RCTAnimatedModuleProvider.mm b/packages/react-native/ReactApple/RCTAnimatedModuleProvider/RCTAnimatedModuleProvider.mm
@@ -29,6 +29,11 @@ @implementation RCTAnimatedModuleProvider {
 }
 
 - (void)dealloc
+{
+  [self invalidate];
+}
+
+- (void)invalidate
 {
   if (_displayLink != nil) {
 #if TARGET_OS_OSX

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,11 @@ @implementation RCTAnimatedModuleProvider {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`- (void)dealloc`
	`32`	`+{`
	`33`	`+ [self invalidate];`
	`34`	`+}`
	`35`	`+`
	`36`	`+- (void)invalidate`
`32`	`37`	`{`
`33`	`38`	`if (_displayLink != nil) {`
`34`	`39`	`#if TARGET_OS_OSX`