From c70f5d547d4812898682b5e69cf127d9af852c5f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Evaldas=20Lavrinovi=C4=8Dius?= Date: Tue, 23 Jan 2024 15:51:48 +0200 Subject: [PATCH 1/2] Fix #712 by removing FixColdStart() Due to Unity trampoline changes this is now misbehaving and modifying one function below (`isBackgroundLaunchOptions`) which causes a crash - see #712 --- Facebook.Unity.Editor/iOS/FixupFiles.cs | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/Facebook.Unity.Editor/iOS/FixupFiles.cs b/Facebook.Unity.Editor/iOS/FixupFiles.cs index 9bb77c20..42469952 100644 --- a/Facebook.Unity.Editor/iOS/FixupFiles.cs +++ b/Facebook.Unity.Editor/iOS/FixupFiles.cs @@ -28,26 +28,6 @@ namespace Facebook.Unity.Editor public class FixupFiles { - private static string didFinishLaunchingWithOptions = -@"(?x) # Verbose mode - (didFinishLaunchingWithOptions.+ # Find this function... - (?:.*\n)+? # Match as few lines as possible until... - \s*return\ )NO(\;\n # return NO; - \}) # }"; - - public static void FixColdStart(string path) - { - string fullPath = Path.Combine(path, Path.Combine("Classes", "UnityAppController.mm")); - string data = Load(fullPath); - - data = Regex.Replace( - data, - didFinishLaunchingWithOptions, - "$1YES$2"); - - Save(fullPath, data); - } - public static void AddBuildFlag(string path) { string projPath = Path.Combine(path, Path.Combine("Unity-iPhone.xcodeproj", "project.pbxproj")); From 830e09ce42f24c7ad6575e67c5d982427e29851b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Evaldas=20Lavrinovi=C4=8Dius?= Date: Tue, 23 Jan 2024 17:59:57 +0200 Subject: [PATCH 2/2] Remove FixColdStart() call from FacebookPostprocess.cs --- Facebook.Unity.Editor/FacebookPostprocess.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/Facebook.Unity.Editor/FacebookPostprocess.cs b/Facebook.Unity.Editor/FacebookPostprocess.cs index 80ca6f51..54995246 100644 --- a/Facebook.Unity.Editor/FacebookPostprocess.cs +++ b/Facebook.Unity.Editor/FacebookPostprocess.cs @@ -68,7 +68,6 @@ public static void OnPostProcessBuild(BuildTarget target, string path) if (target.ToString() == "iOS" || target.ToString() == "iPhone") { UpdatePlist(path); - FixupFiles.FixColdStart(path); FixupFiles.AddBuildFlag(path); }