Fix/sysview commands (VSC-1712) (#1580)

* Update SystemView tracing commands to use mcore and add ELF file path (#1573)

* Create gdbinit file in build directory for GDB heap tracing (#1573)

* Improve GDB heap trace process cleanup (#1573)

- Add graceful GDB shutdown with quit command
- Add delay before force kill to allow GDB to exit cleanly
- Disable GDB confirmation prompts with 'set confirm off'
- Fix typo in error message ("stoping" -> "stopping")

Author: erhankur

src/espIdf/tracing/gdbHeapTraceManager.ts

@@ -62,7 +62,15 @@ export class GdbHeapTraceManager {
           /\\/g,
           "/"
         )}/htrace_${new Date().getTime()}.svdat`;
-        await this.createGdbinitFile(fileName, workspace.fsPath);
+        const buildDirPath = readParameter(
+          "idf.buildPath",
+          workspace
+        ) as string;
+        const buildExists = await pathExists(buildDirPath);
+        if (!buildExists) {
+          throw new Error(`${buildDirPath} doesn't exist. Build first.`);
+        }
+        await this.createGdbinitFile(fileName, buildDirPath);
         const modifiedEnv = await appendIdfAndToolsToPath(workspace);
         const idfTarget = modifiedEnv.IDF_TARGET || "esp32";
         const gdbTool = getToolchainToolName(idfTarget, "gdb");
@@ -73,14 +81,6 @@ export class GdbHeapTraceManager {
         if (!isGdbToolInPath) {
           throw new Error(`${gdbTool} is not available in PATH.`);
         }
-        const buildDirPath = readParameter(
-          "idf.buildPath",
-          workspace
-        ) as string;
-        const buildExists = await pathExists(buildDirPath);
-        if (!buildExists) {
-          throw new Error(`${buildDirPath} doesn't exist. Build first.`);
-        }
         const projectName = await getProjectName(buildDirPath);
         const elfFilePath = join(buildDirPath, `${projectName}.elf`);
         const elfFileExists = await pathExists(elfFilePath);
@@ -132,16 +132,20 @@ export class GdbHeapTraceManager {
   public async stop() {
     try {
       if (this.childProcess) {
-        this.childProcess.stdin.end();
-        this.childProcess.kill("SIGKILL");
+        this.childProcess.stdin.write("quit\n");
+        // Give GDB some time to process the quit command
+        await new Promise(resolve => setTimeout(resolve, 1000));
+        if (!this.childProcess.killed) {
+          this.childProcess.kill("SIGKILL");
+        }
         this.childProcess = null;
       }
       this.archiveDataProvider.populateArchiveTree();
       this.showStartButton();
     } catch (error) {
       const msg = error.message
         ? error.message
-        : "Error stoping GDB Heap Tracing";
+        : "Error stopping GDB Heap Tracing";
       Logger.errorNotify(msg, error, "GdbHeapTraceManager stop");
     }
   }
@@ -170,9 +174,9 @@ export class GdbHeapTraceManager {
     traceFilePath: string,
     workspaceFolder: string
   ) {
-    let content = `set pagination off\ntarget remote :3333\n\nmon reset halt\nflushregs\n\n`;
-    content += `tb heap_trace_start\ncommands\nmon esp sysview start ${traceFilePath}\n`;
-    content += `c\nend\n\ntb heap_trace_stop\ncommands\nmon esp sysview stop\nend\n\nc`;
+    let content = `set pagination off\nset confirm off\ntarget remote :3333\n\nmon reset halt\nflushregs\n\n`;
+    content += `tb heap_trace_start\ncommands\nmon esp sysview_mcore start ${traceFilePath}\n`;
+    content += `c\nend\n\ntb heap_trace_stop\ncommands\nmon esp sysview_mcore stop\nend\n\nc`;
     const filePath = join(workspaceFolder, this.gdbinitFileName);
     await writeFile(filePath, content);
   }

src/espIdf/tracing/tools/sysviewTraceProc.ts

@@ -43,7 +43,7 @@ export class SysviewTraceProc extends AbstractTracingToolManager {
     }
     return await this.parseInternal(
       "python",
-      ["sysviewtrace_proc.py", "-j", `file://${this.traceFilePath}`],
+      ["sysviewtrace_proc.py", "-j", "-b", `file://${this.elfFilePath}`, `file://${this.traceFilePath}`],
       {
         cwd: this.appTraceToolsPath(),
       }