Skip to content

Commit 1577ff5

Browse files
authored
fix: cloning dev branches (#1584)
For cloning I've also added tags containing "-dev" at the end From testing it seems that version retrieve the name without the file extension (e.g. it will retrieve "v5.5-dev" instead of "v5.5-dev.zip").
1 parent 18f47c7 commit 1577ff5

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/setup/espIdfDownload.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,16 +78,17 @@ export async function downloadInstallIdfVersion(
7878
pkgProgress.Progress = `0.00%`;
7979

8080
if (
81-
idfVersion.filename === "master" ||
82-
idfVersion.filename.startsWith("release")
81+
idfVersion.version === "master" ||
82+
idfVersion.version.startsWith("release")
83+
|| idfVersion.version.endsWith("-dev")
8384
) {
84-
const downloadByCloneMsg = `Downloading ESP-IDF ${idfVersion.filename} using git clone...\n`;
85+
const downloadByCloneMsg = `Downloading ESP-IDF ${idfVersion.version} using git clone...\n`;
8586
OutputChannel.appendLine(downloadByCloneMsg);
8687
Logger.info(downloadByCloneMsg);
8788
if (progress) {
8889
progress.report({ message: downloadByCloneMsg });
8990
}
90-
const espIdfCloning = new EspIdfCloning(idfVersion.filename, gitPath);
91+
const espIdfCloning = new EspIdfCloning(idfVersion.version, gitPath);
9192
let cancelDisposable: Disposable;
9293
if (cancelToken) {
9394
cancelDisposable = cancelToken.onCancellationRequested(() => {

0 commit comments

Comments
 (0)