fix(xclk): Zero init ledc_channel_config_t for forward compatibility

tore-espressif · web-flow · commit d9ee2114c92e · 2024-11-15T08:43:49.000+01:00
LEDC driver was extended in espressif/esp-idf@4a90deb with new config structure members. We must zero init the config struct to get default behavior.
diff --git a/target/xclk.c b/target/xclk.c
@@ -47,7 +47,7 @@ esp_err_t camera_enable_out_clock(const camera_config_t* config)
     }
 
     g_ledc_channel = config->ledc_channel;
-    ledc_channel_config_t ch_conf;
+    ledc_channel_config_t ch_conf = {0};
     ch_conf.gpio_num = config->pin_xclk;
     ch_conf.speed_mode = LEDC_LOW_SPEED_MODE;
     ch_conf.channel = config->ledc_channel;

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ esp_err_t camera_enable_out_clock(const camera_config_t* config)`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`g_ledc_channel = config->ledc_channel;`
`50`		`- ledc_channel_config_t ch_conf;`
	`50`	`+ ledc_channel_config_t ch_conf = {0};`
`51`	`51`	`ch_conf.gpio_num = config->pin_xclk;`
`52`	`52`	`ch_conf.speed_mode = LEDC_LOW_SPEED_MODE;`
`53`	`53`	`ch_conf.channel = config->ledc_channel;`