feat(uart): Refactor uartPinSignalInversion for mutex locking

SuGlider · web-flow · commit c2f54ac8463a · 2025-11-03T06:38:06.000-03:00
diff --git a/cores/esp32/esp32-hal-uart.c b/cores/esp32/esp32-hal-uart.c
@@ -994,18 +994,18 @@ bool uartPinSignalInversion(uart_t *uart, uint32_t invMask, bool inverted) {
   if (uart == NULL) {
     return;
   }
-  bool retCode = true;
+  UART_MUTEX_LOCK();
   uint32_t _inv_mask = inv_mask;
   if (inverted) {
     _inv_mask |= invMask;    
-    retCode = ESP_OK == uart_set_line_inverse(uart->num, _inv_mask);
   } else {
     _inv_mask &= ~invMask;    
-    retCode = ESP_OK == uart_set_line_inverse(uart->num, _inv_mask);
   }
+  bool retCode = ESP_OK == uart_set_line_inverse(uart->num, _inv_mask);
   if (retCode) {
     inv_mask = _inv_mask;
   }
+  UART_MUTEX_UNLOCK();
   return retCode;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -994,18 +994,18 @@ bool uartPinSignalInversion(uart_t *uart, uint32_t invMask, bool inverted) {`
`994`	`994`	`if (uart == NULL) {`
`995`	`995`	`return;`
`996`	`996`	`}`
`997`		`- bool retCode = true;`
	`997`	`+ UART_MUTEX_LOCK();`
`998`	`998`	`uint32_t _inv_mask = inv_mask;`
`999`	`999`	`if (inverted) {`
`1000`	`1000`	`_inv_mask \|= invMask;`
`1001`		`- retCode = ESP_OK == uart_set_line_inverse(uart->num, _inv_mask);`
`1002`	`1001`	`} else {`
`1003`	`1002`	`_inv_mask &= ~invMask;`
`1004`		`- retCode = ESP_OK == uart_set_line_inverse(uart->num, _inv_mask);`
`1005`	`1003`	`}`
	`1004`	`+ bool retCode = ESP_OK == uart_set_line_inverse(uart->num, _inv_mask);`
`1006`	`1005`	`if (retCode) {`
`1007`	`1006`	`inv_mask = _inv_mask;`
`1008`	`1007`	`}`
	`1008`	`+ UART_MUTEX_UNLOCK();`
`1009`	`1009`	`return retCode;`
`1010`	`1010`	`}`
`1011`	`1011`