Skip to content

Commit 16bda39

Browse files
committed
Update readme with note about using the template in private repositories
1 parent 223e28a commit 16bda39

File tree

2 files changed

+35
-10
lines changed

2 files changed

+35
-10
lines changed

.github/workflows/static_analysis.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,5 @@ jobs:
2121
# Do not build the project and do not use cmake to generate compile_commands.json
2222
use_cmake: false
2323

24-
# Use the 5.4 release version since it's what we build with
25-
esp_idf_version: release/v5.4
26-
2724
# (Optional) cppcheck args
2825
cppcheck_args: --check-level=exhaustive --force --enable=all --inline-suppr --inconclusive --platform=mips32 --std=c++17 --suppressions-list=$GITHUB_WORKSPACE/suppressions.txt

README.md

Lines changed: 35 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,18 @@ ESP-IDF components.
77
**Table of Contents**
88

99
- [ESP++ Template](#esp-template)
10+
- [Template](#template)
11+
- [Use within a Private Repository](#use-within-a-private-repository)
1012
- [Development](#development)
11-
- [Build and Flash](#build-and-flash)
13+
- [Environment](#environment)
14+
- [Build and Flash](#build-and-flash)
1215
- [Output](#output)
13-
- [Developing](#developing)
16+
- [Contributing](#contributing)
1417
- [Code style](#code-style)
1518

1619
<!-- markdown-toc end -->
1720

18-
## Development
21+
## Template
1922

2023
This repository is designed to be used as a template repository - so you can
2124
sepcify this as the template repository type when creating a new repository on
@@ -49,7 +52,32 @@ After setting this as the template, make sure to update the following:
4952
analysis tool to put its results into a comment on any pull requests in your
5053
repository.
5154

52-
## Build and Flash
55+
### Use within a Private Repository
56+
57+
If you are using this template in a private repository, there are a couple of
58+
additional steps you will need to take:
59+
60+
- Update the
61+
[./.github/workflows/static_analysis.yml](./.github/workflows/static_analysis.yml).
62+
If you are using this in a private repository, you'll need to update the `on:
63+
pull_request_target: ...` section to instead just be `on: [pull_request]`, otherwise
64+
the action won't be able to properly run.
65+
66+
## Development
67+
68+
If you wish to modify / recompile the code, you will need to set up your
69+
development environment to be able to build and flash your target hardware.
70+
71+
### Environment
72+
73+
This project is an ESP-IDF project, currently [ESP-IDF
74+
v.5.5](https://github.com/espressif/esp-idf).
75+
76+
For information about setting up `ESP-IDF v5.5`, please see [the official
77+
ESP-IDF getting started
78+
documentation](https://docs.espressif.com/projects/esp-idf/en/v5.5/esp32s3/get-started/index.html).
79+
80+
### Build and Flash
5381

5482
Build the project and flash it to the board, then run monitor tool to view serial output:
5583

@@ -69,10 +97,10 @@ Example screenshot of the console output from this app:
6997
7098
![CleanShot 2023-07-12 at 14 01 21](https://github.com/esp-cpp/template/assets/213467/7f8abeae-121b-4679-86d8-7214a76f1b75)
7199
72-
## Developing
100+
## Contributing
73101
74-
If you're developing code for this repository, it's recommended to configure
75-
your development environment:
102+
If you're developing code to contribute to this repository, it's recommended to
103+
configure your development environment:
76104
77105
### Code style
78106

0 commit comments

Comments
 (0)