fix sa

Author: finger563

components/doom/src/doom.cpp

@@ -279,7 +279,7 @@ extern "C" {
 
         if (haveSFX) {
             int16_t *audioBuffer = (int16_t *)mixbuffer;
-            int16_t *audioBufferEnd = audioBuffer + AUDIO_BUFFER_LENGTH;
+            const int16_t *audioBufferEnd = audioBuffer + AUDIO_BUFFER_LENGTH;
             while (audioBuffer < audioBufferEnd) {
                 int totalSample = 0;
                 int totalSources = 0;

components/msx/src/msx.cpp

@@ -274,8 +274,6 @@ void TrashMachine(void)
 void SetColor(byte N, byte R, byte G, byte B)
 {
     uint16_t color = make_color(R, G, B);
-    // color = (color >> 8) | (color << 8);
-    color = color;
     if (N)
         XPal[N] = color;
     else

components/pool_allocator/include/pool_allocator.h

@@ -16,7 +16,7 @@ extern "C" {
 
 void pool_create(void* region, size_t size);
 void pool_destroy();
-int pool_contains(void* ptr);
+int pool_contains(const void* ptr);
 void* pool_alloc(size_t size);
 void pool_free(void* ptr);
 

components/pool_allocator/src/pool_allocator.c

@@ -28,7 +28,7 @@ void pool_create(void* mem, size_t size) {
     free_list->next = NULL;
 }
 
-int pool_contains(void* ptr) {
+int pool_contains(const void* ptr) {
     return (ptr >= memory_pool && ptr < memory_pool + memory_pool_size);
 }
 

components/shared_memory/src/shared_memory.c

@@ -69,7 +69,7 @@ void* shared_mem_allocate(const shared_mem_request_t* request) {
 }
 
 void shared_mem_clear(void) {
-    printf("Num bytes allocated: %d\n", current_offset_);
+    printf("Num bytes allocated: %d\n", (int)current_offset_);
     // TODO: Use SIMD-accelerated memset from ESP32s3 vector instructions
     memset(memory_pool_, 0, TOTAL_MEMORY_SIZE);
     current_offset_ = 0;

main/cart.hpp

@@ -284,7 +284,7 @@ class Cart {
     return menu_->get_selected_slot();
   }
 
-  virtual std::string get_save_path(bool bypass_exist_check=false) const {
+  std::string get_save_path(bool bypass_exist_check=false) const {
     namespace fs = std::filesystem;
     auto save_path =
       savedir_ + "/" +
@@ -297,15 +297,15 @@ class Cart {
     return "";
   }
 
-  virtual std::string get_paused_image_path() const {
+  std::string get_paused_image_path() const {
     namespace fs = std::filesystem;
     auto save_path =
       savedir_ + "/paused" +
       get_screenshot_extension();
     return save_path;
   }
 
-  virtual std::string get_screenshot_path(bool bypass_exist_check=false) const {
+  std::string get_screenshot_path(bool bypass_exist_check=false) const {
     auto save_path = get_save_path(bypass_exist_check);
     if (!save_path.empty()) {
       return save_path + get_screenshot_extension();