Minor improvements to e2e tests (#258)

Author: rajeshg

tests/e2e/2fa.test.ts

@@ -38,6 +38,7 @@ test('Users can add 2FA to their account and use it when logging in', async ({
 	await dialog.getByRole('link', { name: /close/i }).click()
 	await page.getByRole('link', { name: user.name ?? user.username }).click()
 	await page.getByRole('menuitem', { name: /logout/i }).click()
+	await expect(page).toHaveURL(`/`)
 
 	await page.goto('/login')
 	await expect(page).toHaveURL(`/login`)

tests/e2e/notes.test.ts

@@ -20,6 +20,7 @@ test('Users can create notes', async ({ login, page }) => {
 	await page.getByRole('textbox', { name: /content/i }).fill(newNote.content)
 
 	await page.getByRole('button', { name: /submit/i }).click()
+	await expect(page.getByText('Note created', { exact: true })).toBeVisible()
 	await expect(page).toHaveURL(new RegExp(`/users/${user.username}/notes/.*`))
 })
 
@@ -37,13 +38,14 @@ test('Users can edit notes', async ({ login, page }) => {
 	await expect(page).toHaveURL(new RegExp(`/users/${user.username}/notes/.*`))
 
 	// edit the note
-	await page.getByRole('link', { name: 'Edit' }).click()
+	await page.getByRole('link', { name: 'Edit', exact: true }).click()
 	const updatedNote = createNewNote()
 	await page.getByRole('textbox', { name: /title/i }).fill(updatedNote.title)
 	await page
 		.getByRole('textbox', { name: /content/i })
 		.fill(updatedNote.content)
 	await page.getByRole('button', { name: /submit/i }).click()
+	await expect(page.getByText('Note updated', { exact: true })).toBeVisible()
 
 	await expect(page).toHaveURL(new RegExp(`/users/${user.username}/notes/.*`))
 	await expect(
@@ -68,6 +70,7 @@ test('Users can delete notes', async ({ login, page }) => {
 	// find links with  href prefix
 	let countBefore = await page.locator('ul>li>a').count()
 	await page.getByRole('button', { name: /delete/i }).click()
+	await expect(page.getByText('Note deleted', { exact: true })).toBeVisible()
 	await expect(page).toHaveURL(`/users/${user.username}/notes`)
 	let countAfter = await page.locator('ul>li>a').count()
 	expect(countAfter).toEqual(countBefore - 1)

tests/e2e/settings-profile.test.ts

@@ -56,7 +56,7 @@ test('Users can update their profile photo', async ({ login, page }) => {
 	await page.goto('/settings/profile')
 
 	const beforeSrc = await page
-		.getByAltText(user.name ?? user.username)
+		.getByRole('img', { name: user.name ?? user.username })
 		.getAttribute('src')
 
 	await page.getByRole('link', { name: /change profile photo/i }).click()
@@ -79,7 +79,7 @@ test('Users can update their profile photo', async ({ login, page }) => {
 	).toHaveURL(`/settings/profile`)
 
 	const afterSrc = await page
-		.getByAltText(user.name ?? user.username)
+		.getByRole('img', { name: user.name ?? user.username })
 		.getAttribute('src')
 
 	expect(beforeSrc).not.toEqual(afterSrc)