Skip to content

Commit 83382d1

Browse files
authored
Remove references to dart:_js_annotations (flutter#176698)
This library is now unused in Flutter and will shortly no longer build with dart2wasm anyway. cc @srujzs
1 parent 894f27e commit 83382d1

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

engine/src/flutter/sky/packages/sky_engine/BUILD.gn

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import("$dart_src/sdk/lib/html/html_sources.gni")
2222
import("$dart_src/sdk/lib/internal/internal_sources.gni")
2323
import("$dart_src/sdk/lib/io/io_sources.gni")
2424
import("$dart_src/sdk/lib/isolate/isolate_sources.gni")
25-
import("$dart_src/sdk/lib/js/js_annotations_sources.gni")
2625
import("$dart_src/sdk/lib/js/js_sources.gni")
2726
import("$dart_src/sdk/lib/js_interop/js_interop_sources.gni")
2827
import("$dart_src/sdk/lib/js_interop_unsafe/js_interop_unsafe_sources.gni")
@@ -103,12 +102,6 @@ copy("_interceptors") {
103102
]
104103
}
105104

106-
copy("_js_annotations") {
107-
lib_path = rebase_path("js", "", dart_sdk_lib_path)
108-
sources = rebase_path(js_annotations_sdk_sources, "", lib_path)
109-
outputs = [ "$root_gen_dir/dart-pkg/sky_engine/lib/_js_annotations/{{source_file_part}}" ]
110-
}
111-
112105
copy("_js_types") {
113106
lib_path = rebase_path("_internal/js_shared", "", dart_sdk_lib_path)
114107
sources = rebase_path(js_types_sdk_sources, "", lib_path)
@@ -224,7 +217,6 @@ group("copy_dart_sdk") {
224217
deps = [
225218
":_http",
226219
":_interceptors",
227-
":_js_annotations",
228220
":_js_types",
229221
":async",
230222
":collection",
@@ -280,8 +272,6 @@ generated_file("_embedder_yaml") {
280272
" # public API, e.g. List being Iterable by virtue of implementing",
281273
" # EfficientLengthIterable. Not including this library yields analysis errors.",
282274
" \"dart:_internal\": \"internal/internal.dart\"",
283-
" # The _js_annotations library is also needed for the same reasons as _internal.",
284-
" \"dart:_js_annotations\": \"_js_annotations/_js_annotations.dart\"",
285275
" # The _js_types library is also needed for the same reasons as _internal.",
286276
" \"dart:_js_types\": \"_js_types/js_types.dart\"",
287277
" \"dart:nativewrappers\": \"_empty.dart\"",

engine/src/flutter/sky/packages/sky_engine/lib/_embedder.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ embedded_libs:
2525
# public API, e.g. List being Iterable by virtue of implementing
2626
# EfficientLengthIterable. Not including this library yields analysis errors.
2727
"dart:_internal": "../../../../third_party/dart/sdk/lib/internal/internal.dart"
28-
# The _js_annotations library is also needed for the same reasons as _internal.
29-
"dart:_js_annotations": "../../../../third_party/dart/sdk/lib/js/_js_annotations.dart"
3028
# The _js_types library is also needed for the same reasons as _internal.
3129
"dart:_js_types": "../../../../third_party/dart/sdk/lib/_internal/js_shared/lib/js_types.dart"
3230
"dart:nativewrappers": "../../../../third_party/dart/sdk/lib/html/dartium/nativewrappers.dart"

0 commit comments

Comments
 (0)