fix tests

Author: brzep

lib/ex_webrtc/rtp/h264/nal_header.ex

@@ -93,6 +93,7 @@ defmodule ExWebRTC.RTP.H264.NAL.Header do
   defp do_decode_type(28), do: :fu_a
   defp do_decode_type(29), do: :fu_b
   defp do_decode_type(number) when number in [30, 31], do: :reserved
+  defp do_decode_type(_), do: :invalid
 
   @doc """
   Encodes given NAL type

test/ex_webrtc/rtp/depayloader_test.exs

@@ -75,9 +75,12 @@ defmodule ExWebRTC.RTP.DepayloaderTest do
              Depayloader.DTMF.depayload(depayloader, @packet)
   end
 
-  test "returns error if no depayloader exists for given codec" do
-    assert {:error, :no_depayloader_for_codec} =
+  test "creates a H264 depayloader and dispatches calls to its module" do
+    assert {:ok, depayloader} =
              %RTPCodecParameters{payload_type: 97, mime_type: "video/H264", clock_rate: 90_000}
              |> Depayloader.new()
+
+    assert Depayloader.depayload(depayloader, @packet) ==
+             Depayloader.H264.depayload(depayloader, @packet)
   end
 end

test/ex_webrtc/rtp/h264/depayloader_test.exs

@@ -3,38 +3,36 @@ defmodule ExWebRTC.RTP.H264.DepayloaderTest do
 
   alias ExWebRTC.RTP.Depayloader
 
-  test "depayload/2" do
-    payload_stapa = <<56, 0, 1, 128, 0, 1, 129>>
-    payload_stapa_out = <<0, 0, 0, 1, 128, 0, 0, 0, 1, 129>>
-
-    payload_fuas = <<60, 133, 128>>
-    payload_fua = <<60, 5, 129>>
-    payload_fuae = <<60, 69, 130>>
-    payload_fua_out = <<0, 0, 0, 1, 37, 128, 129, 130>>
-
+  test "Check valid Single NAL Unit" do
     payload_single = <<53, 131>>
     payload_single_out = <<0, 0, 0, 1, 131>>
 
-    # reserved NALu types (22, 23, 30, 31)
-    payloads_nalu_reserved = [<<55, 131>>, <<56, 131>>, <<62, 131>>, <<63, 131>>]
-    # malformed STAP-A payload. First NAL should be 1-byte long, but is 2-bytes long
-    payload_invalid = <<56, 0, 1, 128, 12, 0, 1, 129>>
-
     depayloader = Depayloader.H264.new()
-
-    # Single NAL Unit 
     packet = ExRTP.Packet.new(payload_single, timestamp: 123)
 
     assert {^payload_single_out, %{current_timestamp: 123, fu_parser_acc: nil}} =
              Depayloader.H264.depayload(depayloader, packet)
+  end
 
-    # STAP-A NAL
+  test "Check valid STAP-A NAL" do
+    payload_stapa = <<56, 0, 1, 128, 0, 1, 129>>
+    payload_stapa_out = <<0, 0, 0, 1, 128, 0, 0, 0, 1, 129>>
+
+    depayloader = Depayloader.H264.new()
     packet = ExRTP.Packet.new(payload_stapa, timestamp: 123)
 
     assert {^payload_stapa_out, %{current_timestamp: 123, fu_parser_acc: nil}} =
              Depayloader.H264.depayload(depayloader, packet)
+  end
+
+  test "Check valid FU-A NAL" do
+    payload_fuas = <<60, 133, 128>>
+    payload_fua = <<60, 5, 129>>
+    payload_fuae = <<60, 69, 130>>
+    payload_fua_out = <<0, 0, 0, 1, 37, 128, 129, 130>>
+
+    depayloader = Depayloader.H264.new()
 
-    # FU-A NAL
     packet1 = ExRTP.Packet.new(payload_fuas, timestamp: 10)
     packet2 = ExRTP.Packet.new(payload_fua, timestamp: 10)
     packet3 = ExRTP.Packet.new(payload_fuae, timestamp: 10)
@@ -51,8 +49,14 @@ defmodule ExWebRTC.RTP.H264.DepayloaderTest do
 
     assert {^payload_fua_out, %{current_timestamp: 10, fu_parser_acc: nil}} =
              Depayloader.H264.depayload(depayloader, packet3)
+  end
+
+  test "Check colliding timestamps in one FU-A" do
+    payload_fuas = <<60, 133, 128>>
+    payload_fua = <<60, 5, 129>>
+
+    depayloader = Depayloader.H264.new()
 
-    # Colliding timestamps in one FU-A
     packet1 = ExRTP.Packet.new(payload_fuas, timestamp: 10)
     packet2 = ExRTP.Packet.new(payload_fua, timestamp: 11)
 
@@ -65,16 +69,27 @@ defmodule ExWebRTC.RTP.H264.DepayloaderTest do
 
     assert {nil, %{current_timestamp: nil, fu_parser_acc: nil}} =
              {bin, depayloader}
+  end
+
+  test "Check all reserved NAL types" do
+    # reserved NALu types (22, 23, 30, 31)
+    payloads_nalu_reserved = [<<55, 131>>, <<56, 131>>, <<62, 131>>, <<63, 131>>]
+
+    depayloader = Depayloader.H264.new()
 
-    # Check all reserved NAL types
     Enum.map(payloads_nalu_reserved, fn payload ->
       packet = ExRTP.Packet.new(payload, timestamp: 123)
 
       assert {nil, %{current_timestamp: nil, fu_parser_acc: nil}} =
                Depayloader.H264.depayload(depayloader, packet)
     end)
+  end
 
-    # Check malformed NAL
+  test "Check malformed NAL" do
+    # malformed STAP-A payload. First NAL should be 1-byte long, but is 2-bytes long
+    payload_invalid = <<56, 0, 1, 128, 12, 0, 1, 129>>
+
+    depayloader = Depayloader.H264.new()
     packet = ExRTP.Packet.new(payload_invalid, timestamp: 123)
 
     assert {nil, %{current_timestamp: nil, fu_parser_acc: nil}} =