test coverage

Author: brzep

lib/ex_webrtc/rtp/h264/nal_formats/fu/header.ex

@@ -55,11 +55,4 @@ defmodule ExWebRTC.RTP.H264.FU.Header do
   end
 
   def parse(_binary), do: {:error, :packet_malformed}
-
-  @doc """
-  Adds FU header
-  """
-  @spec add_header(binary(), 0 | 1, 0 | 1, NAL.Header.rbsp_type()) :: binary()
-  def add_header(payload, start_bit, end_bit, type),
-    do: <<start_bit::1, end_bit::1, 0::1, type::5>> <> payload
 end

test/ex_webrtc/rtp/h264/depayloader_test.exs

@@ -72,13 +72,13 @@ defmodule ExWebRTC.RTP.H264.DepayloaderTest do
   end
 
   test "starting new without ending previous FU-A" do
-    payload_fuas = <<60, 133, 128>>
-    payload_fua = <<60, 133, 129>>
+    payload_fuas1 = <<60, 133, 128>>
+    payload_fuas2 = <<60, 133, 129>>
 
     depayloader = Depayloader.H264.new()
 
-    packet1 = ExRTP.Packet.new(payload_fuas, timestamp: 10)
-    packet2 = ExRTP.Packet.new(payload_fua, timestamp: 10)
+    packet1 = ExRTP.Packet.new(payload_fuas1, timestamp: 10)
+    packet2 = ExRTP.Packet.new(payload_fuas2, timestamp: 10)
 
     {bin, depayloader} = Depayloader.H264.depayload(depayloader, packet1)
 
@@ -91,6 +91,28 @@ defmodule ExWebRTC.RTP.H264.DepayloaderTest do
              {bin, depayloader}
   end
 
+  test "non-start packet without starting FU-A beforehand" do
+    payload_fua = <<60, 5, 128>>
+
+    depayloader = Depayloader.H264.new()
+
+    packet = ExRTP.Packet.new(payload_fua, timestamp: 10)
+
+    assert {nil, %{current_timestamp: nil, fu_parser_acc: []}} =
+             Depayloader.H264.depayload(depayloader, packet)
+  end
+
+  test "non-fragmented FU-A (start and end bits set to 1)" do
+    payload_fua = <<60, 197, 129>>
+
+    depayloader = Depayloader.H264.new()
+
+    packet = ExRTP.Packet.new(payload_fua, timestamp: 10)
+
+    assert {nil, %{current_timestamp: nil, fu_parser_acc: []}} =
+             Depayloader.H264.depayload(depayloader, packet)
+  end
+
   test "all unsupported NAL types" do
     # reserved (22, 23, 30, 31) and unsupported NALu types (STAP-B: 25, MTAP-16: 26, MTAP-24: 27, FU-B: 29)
     payloads_nalu_unsupported = [
@@ -114,7 +136,28 @@ defmodule ExWebRTC.RTP.H264.DepayloaderTest do
     end)
   end
 
+  test "empty RTP payload" do
+    payload_empty = <<>>
+
+    depayloader = Depayloader.H264.new()
+    packet = ExRTP.Packet.new(payload_empty, timestamp: 123)
+
+    assert {nil, %{current_timestamp: nil, fu_parser_acc: []}} =
+             Depayloader.H264.depayload(depayloader, packet)
+  end
+
   test "malformed NAL" do
+    # forbidden zero bit set to 1
+    payload_invalid = <<181, 0>>
+
+    depayloader = Depayloader.H264.new()
+    packet = ExRTP.Packet.new(payload_invalid, timestamp: 123)
+
+    assert {nil, %{current_timestamp: nil, fu_parser_acc: []}} =
+             Depayloader.H264.depayload(depayloader, packet)
+  end
+
+  test "malformed STAP-A" do
     # malformed STAP-A payload. First NAL should be 1-byte long, but is 2-bytes long
     payload_invalid = <<56, 0, 1, 128, 12, 0, 1, 129>>