Requested changes

Author: Karolk99

lib/ex_ice/priv/ice_agent.ex

@@ -1744,6 +1744,7 @@ defmodule ExICE.Priv.ICEAgent do
       conn_check_pair = %CandidatePair{
         conn_check_pair
         | state: :failed,
+          valid?: false,
           non_symmetric_responses_received: conn_check_pair.non_symmetric_responses_received + 1
       }
 
@@ -1817,6 +1818,7 @@ defmodule ExICE.Priv.ICEAgent do
         conn_check_pair = %CandidatePair{
           conn_check_pair
           | state: :failed,
+            valid?: false,
             responses_received: conn_check_pair.responses_received + 1
         }
 
@@ -3014,7 +3016,8 @@ defmodule ExICE.Priv.ICEAgent do
           pair
           | packets_discarded_on_send: pair.packets_discarded_on_send + 1,
             bytes_discarded_on_send: pair.bytes_discarded_on_send + byte_size(raw_req),
-            state: :failed
+            state: :failed,
+            valid?: false
         }
 
         put_in(ice_agent.checklist[pair.id], pair)

test/priv/ice_agent_test.exs

@@ -1566,9 +1566,9 @@ defmodule ExICE.Priv.ICEAgentTest do
       assert ice_agent.state == :completed
     end
 
-    test "candidate fails to send conn check" do
+    test "failure on send" do
       # 1. replace candidate with the mock one that always fails to send data
-      # 2. assert that after unsuccessful conn check sending, ice_agent move conn pair to the failed state
+      # 2. assert that after unsuccessful conn check sending, ice_agent moves conn pair to the failed state
 
       ice_agent =
         ICEAgent.new(