Update the connection state after all actions that may affect it

Author: Karolk99

lib/ex_ice/priv/ice_agent.ex

@@ -485,7 +485,9 @@ defmodule ExICE.Priv.ICEAgent do
     Logger.debug("Setting end-of-candidates flag.")
     ice_agent = %{ice_agent | eoc: true}
     # check whether it's time to nominate and if yes, try noimnate
-    maybe_nominate(ice_agent)
+    ice_agent
+    |> maybe_nominate()
+    |> update_connection_state()
   end
 
   @spec send_data(t(), binary()) :: t()
@@ -580,6 +582,7 @@ defmodule ExICE.Priv.ICEAgent do
       |> update_gathering_state()
       |> update_connection_state()
       |> maybe_nominate()
+      |> update_connection_state()
 
     if ice_agent.state in [:completed, :failed] do
       update_ta_timer(ice_agent)
@@ -591,7 +594,9 @@ defmodule ExICE.Priv.ICEAgent do
             ice_agent
 
           {type, tr} ->
-            execute_transaction(ice_agent, type, tr)
+            ice_agent
+            |> execute_transaction(type, tr)
+            |> update_connection_state()
         end
 
       # schedule next check and call update_ta_timer

test/priv/ice_agent_test.exs

@@ -1592,8 +1592,6 @@ defmodule ExICE.Priv.ICEAgentTest do
       # try to send conn check
       ice_agent = ICEAgent.handle_ta_timeout(ice_agent)
 
-      assert ice_agent.state == :checking
-
       # assert that the candidate pair has moved to a failed state
       # and that the state was updated after the packet was discarded
       assert [
@@ -1605,8 +1603,6 @@ defmodule ExICE.Priv.ICEAgentTest do
                }
              ] = Map.values(ice_agent.checklist)
 
-      ice_agent = ICEAgent.handle_ta_timeout(ice_agent)
-
       assert ice_agent.state == :failed
     end
 
@@ -1650,10 +1646,6 @@ defmodule ExICE.Priv.ICEAgentTest do
                }
              ] = Map.values(ice_agent.checklist)
 
-      assert ice_agent.state == :connected
-
-      ice_agent = ICEAgent.handle_ta_timeout(ice_agent)
-
       assert ice_agent.state == :failed
     end
   end