Skip to content

Conversation

@cocoa-xu
Copy link
Contributor

@cocoa-xu cocoa-xu commented Oct 10, 2024

Just noticed that current CI will upload the same precompiled binary for x86_64 a few times, for example, https://github.com/elixir-sqlite/exqlite/actions/runs/11237432761/job/31239865968

Run softprops/action-gh-release@v1
⬆️ Uploading exqlite-nif-2.17-aarch64-linux-gnu-0.25.0.tar.gz...
⬆️ Uploading exqlite-nif-2.17-aarch64-linux-musl-0.25.0.tar.gz...
♻️ Deleting previously uploaded asset exqlite-nif-2.17-x86_64-linux-gnu-0.25.0.tar.gz...
⬆️ Uploading exqlite-nif-2.17-x86_64-linux-gnu-0.25.0.tar.gz...
🎉 Release ready at https://github.com/elixir-sqlite/exqlite/releases/tag/v0.25.0

And sometimes it might cause trouble in this way.

I'd like to address this issue in elixir_make and/or cc_precompiler, but sadly I haven't got enough bandwidth at the moment to add one more option/flag and test it properly and thoroughly. This PR should be good enough to do the job until then!

Signed-off-by: Cocoa <i@uwucocoa.moe>
Signed-off-by: Cocoa <i@uwucocoa.moe>
@warmwaffles
Copy link
Member

@cocoa-xu do you know by any chance what this means or how to shut it up?

warning: key "exqlite-nif-2.16-aarch64-linux-gnu-0.25.0.tar.gz" will be overridden in map
  nofile:1

warning: key "exqlite-nif-2.16-riscv64-linux-gnu-0.25.0.tar.gz" will be overridden in map
  nofile:1

warning: key "exqlite-nif-2.16-x86_64-linux-gnu-0.25.0.tar.gz" will be overridden in map
  nofile:1

warning: key "exqlite-nif-2.17-aarch64-linux-gnu-0.25.0.tar.gz" will be overridden in map
  nofile:1

warning: key "exqlite-nif-2.17-riscv64-linux-gnu-0.25.0.tar.gz" will be overridden in map
  nofile:1

warning: key "exqlite-nif-2.17-x86_64-linux-gnu-0.25.0.tar.gz" will be overridden in map
  nofile:1

@cocoa-xu
Copy link
Contributor Author

@cocoa-xu do you know by any chance what this means or how to shut it up?

warning: key "exqlite-nif-2.16-aarch64-linux-gnu-0.25.0.tar.gz" will be overridden in map
  nofile:1

warning: key "exqlite-nif-2.16-riscv64-linux-gnu-0.25.0.tar.gz" will be overridden in map
  nofile:1

warning: key "exqlite-nif-2.16-x86_64-linux-gnu-0.25.0.tar.gz" will be overridden in map
  nofile:1

warning: key "exqlite-nif-2.17-aarch64-linux-gnu-0.25.0.tar.gz" will be overridden in map
  nofile:1

warning: key "exqlite-nif-2.17-riscv64-linux-gnu-0.25.0.tar.gz" will be overridden in map
  nofile:1

warning: key "exqlite-nif-2.17-x86_64-linux-gnu-0.25.0.tar.gz" will be overridden in map
  nofile:1

I probably have some idea about where this comes from. I'll look into this later today or tomorrow!

@warmwaffles warmwaffles merged commit 0c6395c into elixir-sqlite:main Oct 10, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants