Skip to content

refactor(torchx): migrate to Fine #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2025
Merged

refactor(torchx): migrate to Fine #1641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34fc037
refactor(torchx): migrate to Fine
polvalente Nov 1, 2025
4b8c5e1
simplify deallocation
polvalente Nov 1, 2025
802d6e5
refactor: simplify NIF overloads
polvalente Nov 2, 2025
23fc882
chore: add the missing assert
polvalente Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion torchx/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ message(STATUS "C_SRC: ${C_SRC}")
message(STATUS "PRIV_DIR: $ENV{PRIV_DIR}")
message(STATUS "LIBTORCH_DIR: $ENV{LIBTORCH_DIR}")
message(STATUS "ERTS_INCLUDE_DIR: $ENV{ERTS_INCLUDE_DIR}")
message(STATUS "FINE_INCLUDE_DIR: $ENV{FINE_INCLUDE_DIR}")
message(STATUS "LIBTORCH_BASE: $ENV{LIBTORCH_BASE}")
message(STATUS "MIX_BUILD_EMBEDDED $ENV{MIX_BUILD_EMBEDDED}")
message(STATUS "LIBTORCH_LINK $ENV{LIBTORCH_LINK}")
Expand All @@ -43,7 +44,7 @@ add_library(torchx SHARED ${torchx_sources})
target_link_libraries(torchx "${TORCH_LIBRARIES}")
set_property(TARGET torchx PROPERTY CXX_STANDARD 17)

target_include_directories(torchx PUBLIC $ENV{ERTS_INCLUDE_DIR})
target_include_directories(torchx PUBLIC $ENV{ERTS_INCLUDE_DIR} $ENV{FINE_INCLUDE_DIR})

install(
TARGETS torchx
Expand Down
304 changes: 0 additions & 304 deletions torchx/c_src/nx_nif_utils.hpp
View file
Open in desktop

This file was deleted.

Loading