Skip to content

Commit ffeee2f

Browse files
Use Macro.camelize/1 (#36)
* Use Macro.camelize/1 * Remove upcase_first
1 parent 0302c64 commit ffeee2f

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

lib/grpc_reflection/service/builder/util.ex

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ defmodule GrpcReflection.Service.Builder.Util do
2424
end
2525
end
2626

27-
def upcase_first(<<first::utf8, rest::binary>>), do: String.upcase(<<first::utf8>>) <> rest
28-
2927
def downcase_first(<<first::utf8, rest::binary>>),
3028
do: String.downcase(<<first::utf8>>) <> rest
3129

@@ -103,7 +101,7 @@ defmodule GrpcReflection.Service.Builder.Util do
103101
name -> name
104102
end)
105103
|> String.split(".")
106-
|> Enum.map(&upcase_first/1)
104+
|> Enum.map(&Macro.camelize/1)
107105
|> Module.safe_concat()
108106
end
109107

test/builder/util_test.exs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@ defmodule GrpcReflection.Service.Builder.UtilTest do
2121
Util.get_package("testserviceV3.TestService")
2222
end
2323

24-
test "upcase_first" do
25-
assert "Hello" == Util.upcase_first("hello")
26-
end
27-
2824
test "downcase_first" do
2925
assert "hello" == Util.downcase_first("Hello")
3026
end

0 commit comments

Comments
 (0)