Skip to content

Commit 1e7b132

Browse files
committed
Fix transmission angle or coordinate jam problem
1 parent 1b920ab commit 1e7b132

File tree

3 files changed

+15
-16
lines changed

3 files changed

+15
-16
lines changed

pymycobot/common.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,4 +187,3 @@ def read(self):
187187
self.log.debug("_read: no data can be read")
188188
data = None
189189
return data
190-

pymycobot/generate.py

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
class MyCobotCommandGenerator(DataProcessor):
1212
"""MyCobot Python API
13-
1413
Annotations:
1514
* = Chain operation
1615
x = ???
@@ -185,7 +184,7 @@ def send_angle(self, id, degree, speed):
185184
degree (float): angle value.
186185
speed (int): 0 ~ 100
187186
"""
188-
calibration_parameters(id=id, degree=degree, speed=speed)
187+
self.calibration_parameters(id=id, degree=degree, speed=speed)
189188
return self._mesg(ProtocolCode.SEND_ANGLE, id, [self._angle2int(degree)], speed)
190189

191190
# @check_parameters(Command.SEND_ANGLES)
@@ -198,7 +197,7 @@ def send_angles(self, degrees, speed):
198197
example for mypalletizer [0.0, 0.0, 0.0, 0.0]
199198
speed (int): 0 ~ 100
200199
"""
201-
calibration_parameters(degrees=degrees, speed=speed)
200+
self.calibration_parameters(degrees=degrees, speed=speed)
202201
degrees = [self._angle2int(degree) for degree in degrees]
203202
return self._mesg(ProtocolCode.SEND_ANGLES, degrees, speed)
204203

@@ -220,7 +219,7 @@ def send_coord(self, id, coord, speed):
220219
coord(float): mm
221220
speed(int): 0 ~ 100
222221
"""
223-
calibration_parameters(id=id, speed=speed)
222+
self.calibration_parameters(id=id, speed=speed)
224223
value = self._coord2int(coord) if id <= 3 else self._angle2int(coord)
225224
return self._mesg(ProtocolCode.SEND_COORD, id, [value], speed)
226225

@@ -234,7 +233,7 @@ def send_coords(self, coords, speed, mode):
234233
speed(int);
235234
mode(int): 0 - angluar, 1 - linear
236235
"""
237-
calibration_parameters(coords=coords, speed=speed)
236+
self.calibration_parameters(coords=coords, speed=speed)
238237
coord_list = []
239238
for idx in range(3):
240239
coord_list.append(self._coord2int(coords[idx]))
@@ -255,14 +254,14 @@ def is_in_position(self, data, id=0):
255254
-1: error data
256255
"""
257256
if id == 1:
258-
calibration_parameters(coords=data)
257+
self.calibration_parameters(coords=data)
259258
data_list = []
260259
for idx in range(3):
261260
data_list.append(self._coord2int(data[idx]))
262261
for idx in range(3, 6):
263262
data_list.append(self._angle2int(data[idx]))
264263
elif id == 0:
265-
calibration_parameters(degrees=data)
264+
self.calibration_parameters(degrees=data)
266265
data_list = [self._angle2int(i) for i in data]
267266
else:
268267
raise Exception("id is not right, please input 0 or 1")
@@ -363,7 +362,7 @@ def set_speed(self, speed):
363362
Args:
364363
speed (int): 0 - 100
365364
"""
366-
calibration_parameters(speed=speed)
365+
self.calibration_parameters(speed=speed)
367366
return self._mesg(ProtocolCode.SET_SPEED, speed)
368367

369368
"""
@@ -379,11 +378,11 @@ def get_acceleration(self):
379378
"""
380379

381380
def get_joint_min_angle(self, joint_id):
382-
calibration_parameters(id=joint_id)
381+
self.calibration_parameters(id=joint_id)
383382
return self._mesg(ProtocolCode.GET_JOINT_MIN_ANGLE, joint_id, has_reply=True)
384383

385384
def get_joint_max_angle(self, joint_id):
386-
calibration_parameters(id=joint_id)
385+
self.calibration_parameters(id=joint_id)
387386
return self._mesg(ProtocolCode.GET_JOINT_MAX_ANGLE, joint_id, has_reply=True)
388387

389388
# Servo control
@@ -437,7 +436,7 @@ def set_color(self, r=0, g=0, b=0):
437436
b (int): 0 ~ 255
438437
439438
"""
440-
calibration_parameters(rgb=[r, g, b])
439+
self.calibration_parameters(rgb=[r, g, b])
441440
return self._mesg(ProtocolCode.SET_COLOR, r, g, b)
442441

443442
def set_pin_mode(self, pin_no, pin_mode):
@@ -489,7 +488,7 @@ def set_gripper_value(self, value, speed):
489488
value (int): 0 ~ 100
490489
speed (int): 0 ~ 100
491490
"""
492-
calibration_parameters(speed=speed)
491+
self.calibration_parameters(speed=speed)
493492
return self._mesg(ProtocolCode.SET_GRIPPER_VALUE, value, speed)
494493

495494
def set_gripper_ini(self):

pymycobot/mypalletizer.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import logging
44
import math
5+
import time
56

67
from .log import setup_logging
78
from .generate import MyCobotCommandGenerator
@@ -183,8 +184,8 @@ def sync_send_angles(self, degrees, speed, timeout=7):
183184
t = time.time()
184185
self.send_angles(degrees, speed)
185186
while time.time() - t < timeout:
186-
f = self.is_in_position(degrees, 0)
187-
if f:
187+
f = self.is_moving()
188+
if not f:
188189
break
189190
time.sleep(0.1)
190191
return self
@@ -193,7 +194,7 @@ def sync_send_coords(self, coords, speed, mode, timeout=7):
193194
t = time.time()
194195
self.send_coords(coords, speed, mode)
195196
while time.time() - t < timeout:
196-
if self.is_in_position(coords, 1):
197+
if not self.is_moving():
197198
break
198199
time.sleep(0.1)
199200
return self

0 commit comments

Comments
 (0)