The server starts up in a new thread. Some fixes.

Author: elementallyXD

main_server.cpp

@@ -3,90 +3,96 @@
 #include <cli/cli.h>
 #include <cli/clifilesession.h>
 
+#include <boost/thread.hpp>
+
 using namespace cli;
 
 int main(void)
 {
-        boost::asio::io_service io_service;
-        unsigned int port;
-        bool set_port = false;
-        
-        auto rootMenu = std::make_unique< Menu >("SERVER");
-        rootMenu->Insert(
-            "start",
-            [&](std::ostream& out) 
-            { 
-                if (set_port) 
+    boost::asio::io_service io_service;
+    unsigned int port;
+    bool set_port = false;
+
+    auto rootMenu = std::make_unique< Menu >("SERVER");
+    rootMenu->Insert(
+        "start",
+        [&](std::ostream& out)
+        {
+            if (set_port)
+            {
+                try
                 {
-                    try
-                    {
-                        server s(io_service, port);
-                        std::cout << "\tSERVER STARTED ON " << port << std::endl;
-                        if(io_service.stopped())
-                            io_service.restart();
-                        io_service.run();
-                    }
-                    catch (const std::exception& e)
-                    {
-                        std::cerr << "SERVER> Exception: " << e.what() << "\n";
-                    }
-                }
-                else {
-                    out << "You must set port for server. Use: \"setPort <int>\"" << "\n";
+                    server s(std::move(io_service), port);
+                    std::cout << "\tSERVER STARTED ON " << port << std::endl;
+
+                    if (io_service.stopped())
+                        io_service.restart();
+                        
+                    std::thread run_service([&] { io_service.run(); });
+                    run_service.join();
+
                 }
-            },
-            "Start server");
-        
-        rootMenu->Insert(
-            "setPort",
-            [&port, &set_port](std::ostream& out, int x) 
-            { 
-                if (x > 0 && x < 65536)
+                catch (const std::exception& e)
                 {
-                    port = x;
-                    out << "\tSERVER ON PORT: " << port << std::endl;
-                    set_port = true;
+                    std::cerr << "SERVER> Exception: " << e.what() << "\n";
                 }
-                else 
+            }
+            else {
+                out << "You must set port for server. Use: \"setPort <int>\"" << "\n";
+            }
+        },
+        "Start server");
+
+    rootMenu->Insert(
+        "setPort",
+        [&port, &set_port](std::ostream& out, const int& x)
+        {
+            if (x > 0 && x < 65536)
+            {
+                port = x;
+                out << "\tSERVER ON PORT: " << port << std::endl;
+                set_port = true;
+            }
+            else
+            {
+                out << "\tPort must be greter than 0 and less than 65536" << std::endl;
+            }
+        },
+        "Set port for server");
+
+    rootMenu->Insert(
+        "stop",
+        [&](std::ostream& out)
+        {
+            if (set_port) {
+                try
                 {
-                    out << "\tPort must be greter than 0 and less than 65536" << std::endl;
-                }
-            },
-            "Set port for server");
-        
-        rootMenu->Insert(
-            "stop",
-            [&](std::ostream& out) 
-            { 
-                if (set_port){
-                    try
-                    {
-                        if (!io_service.stopped())
-                            io_service.stop();
-                        out << "\tSTOPED ON PORT " << port << std::endl;
-                    }
-                    catch (const std::exception& e)
-                    {
-                        std::cerr << "SERVER> Exception: " << e.what() << "\n";
-                    }
+                    if (!io_service.stopped())
+                        io_service.stop();
+                    out << "\tSTOPED ON PORT " << port << std::endl;
                 }
-                else {
-                    out << "You don't specify the port or don't start the server." << "\n";
+                catch (const std::exception& e)
+                {
+                    std::cerr << "SERVER> Exception: " << e.what() << "\n";
                 }
-            },
-            "Stop server");
+            }
+            else {
+                out << "You don't specify the port or don't start the server." << "\n";
+            }
+        },
+        "Stop server");
 
-        Cli cli(std::move(rootMenu));
-        cli.ExitAction([&io_service](auto& out)
-        { 
+    Cli cli(std::move(rootMenu));
+    cli.ExitAction([&io_service](auto& out)
+        {
             if (!io_service.stopped())
                 io_service.stop();
-               
-            out << "\tEXIT. Goodbye!\n"; 
+
+            out << "\tEXIT. Goodbye!\n";
         });
 
-        CliFileSession input(cli);
-        input.Start();
+    CliFileSession input(cli);
+    input.Start();
 
     return 0;
 }

server.h

@@ -39,14 +39,14 @@ class session : public std::enable_shared_from_this<session>
 
     tcp::socket socket_;
     enum { max_length = 1024 };
-    char data_[max_length];
-    unsigned int session_id;
+    char data_[max_length] = {0};
+    unsigned int session_id = 0 ;
 };
 
 class server
 {
 public:
-    server(boost::asio::io_service& io_service, const unsigned int port) :
+    server(boost::asio::io_service&& io_service, const unsigned int& port) :
         ep(tcp::v4(), port),
         acceptor_(io_service, ep),
         session_id(0)
@@ -60,5 +60,5 @@ class server
     const tcp::endpoint ep;
     tcp::acceptor acceptor_;
 
-    unsigned int session_id;
+    unsigned int session_id = 0;
 };