Merge pull request #61 from eldimious/feature/NAS-0_eslint

NAS-0: lint files

Author: eldimious

.gitignore

@@ -30,3 +30,4 @@ coverage
 .nyc_output
 # Compiled binary addons (http://nodejs.org/api/addons.html)
 build/Release
+dist/

src/common/constants/index.js

@@ -12,6 +12,9 @@ const MAX_CONSECUTIVE_FAILS_BY_USERNAME = 10;
 const PRODUCTION_ENV = 'production';
 const VERBOSE_LOGGING_LVL = 'verbose';
 const INFO_LOGGING_LVL = 'info';
+const DEFAULT_PAGINATION_LIMIT = 25;
+const MAX_PAGINATION_LIMIT = 100;
+const DEFAULT_PAGINATION_PAGE = 1;
 
 module.exports = {
   USER_TOKEN_EXPIRATION,
@@ -21,4 +24,7 @@ module.exports = {
   PRODUCTION_ENV,
   VERBOSE_LOGGING_LVL,
   INFO_LOGGING_LVL,
+  DEFAULT_PAGINATION_LIMIT,
+  MAX_PAGINATION_LIMIT,
+  DEFAULT_PAGINATION_PAGE,
 };

src/common/logging/index.js

@@ -40,6 +40,7 @@ const logger = winston.createLogger({
 module.exports = {
   requestLogger,
   errorLogger,
+  raw: logger,
   error: logger.error.bind(logger),
   warn: logger.warn.bind(logger),
   info: logger.info.bind(logger),

src/common/utils/helper/index.js

@@ -1,118 +1,7 @@
-const isObject = obj => (typeof obj === 'object' && obj !== null) || typeof obj === 'function';
-
-
-const getConstructorName = function getConstructorName(obj) {
-  return (obj.constructor && obj.constructor.name) ? obj.constructor.name : '';
-};
-
-
-const isDate = d => d instanceof Date;
-
-
-const isEmpty = o => Object.keys(o).length === 0;
-
-
-const properObject = o => isObject(o) && !o.hasOwnProperty ? { ...o } : o;
-
-
-const AsyncFunction = (async () => {}).constructor;
-
-
-const isFunctionConstructor = (f) => {
-  if (f.constructor === Function || f.constructor === AsyncFunction) {
-    return true;
-  }
-  return false;
-};
-
-const isArgumentFunction = (f) => {
-  if (!f || typeof f !== 'function' || !isFunctionConstructor(f)) {
-    return false;
-  }
-  return true;
-};
-
-
-const isFunction = (obj) => {
-  return !!(obj && obj.constructor && obj.call && obj.apply);
-};
-
-
-const getDiffValuesFromObjects = (lhs, rhs) => {
-  if (lhs === rhs) return {};
-  if (!isObject(lhs) || !isObject(rhs)) return rhs;
-  const l = properObject(lhs);
-  const r = properObject(rhs);
-  const deletedValues = Object.keys(l).reduce((acc, key) => {
-    return r.hasOwnProperty(key) ? acc : { ...acc, [key]: undefined };
-  }, {});
-  if (isDate(l) || isDate(r)) {
-    if (l.valueOf() == r.valueOf()) return {};
-    return r;
-  }
-  return Object.keys(r).reduce((acc, key) => {
-    if (!l.hasOwnProperty(key)) return { ...acc, [key]: r[key] };
-    const difference = getDiffValuesFromObjects(l[key], r[key]);
-    if (isObject(difference) && isEmpty(difference) && !isDate(difference)) return acc;
-    return { ...acc, [key]: difference };
-  }, deletedValues);
-};
-
-
-const compareObjects = function compareObjects(obj1, obj2) {
-  return Object.keys(obj1).every(k1 =>
-    Object.keys(obj2).some(k2 =>
-      obj1[k1] === obj2[k2],
-    ),
-  );
-};
-
-
-const getElementsToSort = (a, b, prop, type) => {
-  if (type === 'date') {
-    return {
-      keyA: new Date(a[prop]),
-      keyB: new Date(b[prop]),
-    };
-  }
-  return {
-    keyA: a[prop],
-    keyB: b[prop],
-  };
-};
-
-
-const sortArrayDescBy = (prop, type) => (a, b) => {
-  const { keyA, keyB } = getElementsToSort(a, b, prop, type);
-  if (keyA > keyB) return -1;
-  if (keyA < keyB) return 1;
-  return 0;
-};
-
-
-const sortArrayAscBy = (prop, type) => (a, b) => {
-  const { keyA, keyB } = getElementsToSort(a, b, prop, type);
-  if (keyA < keyB) return -1;
-  if (keyA > keyB) return 1;
-  return 0;
-};
-
-
-const removeDuplicateFromArray = arr => Array.from(new Set(arr));
-
 function getRetryAfterSeconds(msBeforeNext) {
   return Math.round(msBeforeNext / 1000) || 1;
 }
 
 module.exports = {
-  isObject,
-  isArgumentFunction,
-  isFunction,
-  getConstructorName,
-  getDiffValuesFromObjects,
-  compareObjects,
-  sortArrayDescBy,
-  sortArrayAscBy,
-  removeDuplicateFromArray,
   getRetryAfterSeconds,
 };

src/common/utils/workerProcesses/index.js

@@ -17,11 +17,11 @@ const setupWorkerProcesses = () => {
     // these references can be used to receive messages from workers
     workers.push(cluster.fork());
     // to receive messages from worker process
-    workers[i].on('message', message => logging.info(`worker message: ${message}`));
+    workers[i].on('message', (message) => logging.info(`worker message: ${message}`));
   }
   // process is clustered on a core and process id is assigned
-  cluster.on('online', worker => logging.info(`Worker ${worker.process.pid} is online`));
-  cluster.on('listening', worker => logging.info(`Worker ${worker.process.pid} is listening`));
+  cluster.on('online', (worker) => logging.info(`Worker ${worker.process.pid} is online`));
+  cluster.on('listening', (worker) => logging.info(`Worker ${worker.process.pid} is listening`));
   // if any of the worker process dies then start a new one by simply forking another one
   cluster.on('exit', (worker, code, signal) => {
     logging.info(`Worker ${worker.process.pid} died with code: ${code} and signal: ${signal}`);
@@ -31,7 +31,7 @@ const setupWorkerProcesses = () => {
       const newWorker = cluster.fork();
       workers.push(newWorker);
       // to receive messages from new worker process
-      workers[workers.length - 1].on('message', message => logging.info(`worker message: ${message}`));
+      workers[workers.length - 1].on('message', (message) => logging.info(`worker message: ${message}`));
     }
   });
 };

src/data/infrastructure/db/schemas/index.js

@@ -1,8 +1,7 @@
 const postSchema = require('./Post');
 const userSchema = require('./User');
 
-
-module.exports.create = mongoose => ({
+module.exports.create = (mongoose) => ({
   Post: postSchema(mongoose),
   User: userSchema(mongoose),
 });

src/data/repositories/posts/index.js

@@ -17,13 +17,12 @@ const DEFAULT_PAGINATION_CONTENT = {
   data: [],
 };
 
-
 const handleUsersPaginationResponse = (response) => {
   if (!response.docs || response.docs.length <= 0) {
     return DEFAULT_PAGINATION_CONTENT;
   }
   const postsList = {
-    data: response.docs.map(doc => mapper.toDomainModel(doc, PostDomainModel)),
+    data: response.docs.map((doc) => mapper.toDomainModel(doc, PostDomainModel)),
     pagination: {
       total: response.total,
       limit: response.limit,
@@ -34,14 +33,13 @@ const handleUsersPaginationResponse = (response) => {
   return postsList;
 };
 
-const getPaginationOptions = options => ({
+const getPaginationOptions = (options) => ({
   lean: true,
   page: options.page || 1,
   limit: options.limit || 25,
   sort: { created: -1 },
 });
 
-
 const getQueryObject = (options) => {
   const queries = {
     userId: options.userId,
@@ -55,52 +53,37 @@ const getQueryObject = (options) => {
   return queries;
 };
 
-
 const postStore = {
   async listUserPosts(options) {
-    try {
-      const { Post: postSchema } = this.getSchemas();
-      const docs = await postSchema.paginate(getQueryObject(options), getPaginationOptions(options));
-      return handleUsersPaginationResponse(docs);
-    } catch (error) {
-      throw error;
-    }
+    const { Post: postSchema } = this.getSchemas();
+    const docs = await postSchema.paginate(getQueryObject(options), getPaginationOptions(options));
+    return handleUsersPaginationResponse(docs);
   },
   async createUserPost(options) {
-    try {
-      const { Post: postSchema } = this.getSchemas();
-      const newPost = new postSchema({
-        userId: options.userId,
-        imageUrl: options.imageUrl,
-        description: options.description,
-        publisher: options.publisher,
-      });
-      const doc = await newPost.save();
-      return mapper.toDomainModel(doc, PostDomainModel);
-    } catch (error) {
-      throw error;
-    }
+    const { Post: postSchema } = this.getSchemas();
+    const newPost = new postSchema({
+      userId: options.userId,
+      imageUrl: options.imageUrl,
+      description: options.description,
+      publisher: options.publisher,
+    });
+    const doc = await newPost.save();
+    return mapper.toDomainModel(doc, PostDomainModel);
   },
   async getUserPost(options) {
-    try {
-      const { Post: postSchema } = this.getSchemas();
-      const doc = await postSchema.findOne({ userId: options.userId, _id: options.postId }).lean().exec();
-      if (!doc) {
-        throw new errors.NotFound(`Post with id ${options.postId} not found.`);
-      }
-      return mapper.toDomainModel(doc, PostDomainModel);
-    } catch (error) {
-      throw error;
+    const { Post: postSchema } = this.getSchemas();
+    const doc = await postSchema.findOne({ userId: options.userId, _id: options.postId }).lean().exec();
+    if (!doc) {
+      throw new errors.NotFound(`Post with id ${options.postId} not found.`);
     }
+    return mapper.toDomainModel(doc, PostDomainModel);
   },
 };
 
-
 module.exports.init = ({ Post }) => Object.assign(Object.create(postStore), {
   getSchemas() {
     return {
       Post,
     };
   },
 });
-

src/data/repositories/recourceLimiterRepository/index.js

@@ -23,8 +23,8 @@ module.exports.init = function init() {
 
   return {
     maxConsecutiveFailsByUsername: MAX_CONSECUTIVE_FAILS_BY_USERNAME,
-    getUserKeyForFailedLogin: async usernameKey => limiterUserConsecutiveFailsByUsername.get(usernameKey),
-    consumeUserPointsForFailedLogin: async usernameKey => limiterUserConsecutiveFailsByUsername.consume(usernameKey),
-    deleteUserKeyForFailedLogin: async usernameKey => limiterUserConsecutiveFailsByUsername.delete(usernameKey),
+    getUserKeyForFailedLogin: async (usernameKey) => limiterUserConsecutiveFailsByUsername.get(usernameKey),
+    consumeUserPointsForFailedLogin: async (usernameKey) => limiterUserConsecutiveFailsByUsername.consume(usernameKey),
+    deleteUserKeyForFailedLogin: async (usernameKey) => limiterUserConsecutiveFailsByUsername.delete(usernameKey),
   };
 };

src/data/repositories/users/index.js

@@ -21,43 +21,35 @@ const userStore = {
     email,
     password,
   }) {
-    try {
-      const {
-        User: userSchema,
-      } = this.getSchemas();
-      const newUser = new userSchema({
-        name,
-        surname,
-        username,
-        email,
-        password,
-      });
-      const userDoc = await newUser.save();
-      return mapper.toDomainModel(userDoc, UserDomainModel);
-    } catch (error) {
-      throw error;
-    }
+    const {
+      User: userSchema,
+    } = this.getSchemas();
+    const newUser = new userSchema({
+      name,
+      surname,
+      username,
+      email,
+      password,
+    });
+    const userDoc = await newUser.save();
+    return mapper.toDomainModel(userDoc, UserDomainModel);
   },
 
   async getUser({
     email,
     userId,
   }) {
-    try {
-      const { User: userSchema } = this.getSchemas();
-      const userDoc = await userSchema.findOne(queryForGetUser({
-        email,
-        userId,
-      }))
-        .lean()
-        .exec();
-      if (!userDoc) {
-        throw new errors.NotFound('User not found.');
-      }
-      return mapper.toDomainModel(userDoc, UserDomainModel);
-    } catch (error) {
-      throw error;
+    const { User: userSchema } = this.getSchemas();
+    const userDoc = await userSchema.findOne(queryForGetUser({
+      email,
+      userId,
+    }))
+      .lean()
+      .exec();
+    if (!userDoc) {
+      throw new errors.NotFound('User not found.');
     }
+    return mapper.toDomainModel(userDoc, UserDomainModel);
   },
 };