Extract agent policy test config (#1439)

tobio · web-flow · commit 81760e2743b0 · 2025-11-13T14:28:38.000+11:00
* Extract agent policy test config

* make lint
diff --git a/internal/fleet/agent_policy/acc_test.go b/internal/fleet/agent_policy/acc_test.go
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/create/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/create/main.tf
@@ -0,0 +1,17 @@
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name            = var.policy_name
+  namespace       = "default"
+  description     = "Test Agent Policy"
+  monitor_logs    = true
+  monitor_metrics = false
+  skip_destroy    = var.skip_destroy
+}
+
+data "elasticstack_fleet_enrollment_tokens" "test_policy" {
+  policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/create/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/create/variables.tf
@@ -0,0 +1,10 @@
+variable "policy_name" {
+  type        = string
+  description = "Name for the agent policy"
+}
+
+variable "skip_destroy" {
+  type        = bool
+  description = "Whether to skip destruction of the policy"
+  default     = false
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/create_with_global_data_tags/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/create_with_global_data_tags/main.tf
@@ -0,0 +1,25 @@
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name            = var.policy_name
+  namespace       = "default"
+  description     = "Test Agent Policy"
+  monitor_logs    = true
+  monitor_metrics = false
+  skip_destroy    = var.skip_destroy
+  global_data_tags = {
+    tag1 = {
+      string_value = "value1"
+    }
+    tag2 = {
+      number_value = 1.1
+    }
+  }
+}
+
+data "elasticstack_fleet_enrollment_tokens" "test_policy" {
+  policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/create_with_global_data_tags/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/create_with_global_data_tags/variables.tf
@@ -0,0 +1,10 @@
+variable "policy_name" {
+  type        = string
+  description = "Name for the agent policy"
+}
+
+variable "skip_destroy" {
+  type        = bool
+  description = "Whether to skip destruction of the policy"
+  default     = false
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update/main.tf
@@ -0,0 +1,17 @@
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name            = var.policy_name
+  namespace       = "default"
+  description     = "This policy was updated"
+  monitor_logs    = false
+  monitor_metrics = true
+  skip_destroy    = var.skip_destroy
+}
+
+data "elasticstack_fleet_enrollment_tokens" "test_policy" {
+  policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update/variables.tf
@@ -0,0 +1,10 @@
+variable "policy_name" {
+  type        = string
+  description = "Name for the agent policy"
+}
+
+variable "skip_destroy" {
+  type        = bool
+  description = "Whether to skip destruction of the policy"
+  default     = false
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_global_data_tags/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_global_data_tags/main.tf
@@ -0,0 +1,22 @@
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name            = var.policy_name
+  namespace       = "default"
+  description     = "This policy was updated"
+  monitor_logs    = false
+  monitor_metrics = true
+  skip_destroy    = var.skip_destroy
+  global_data_tags = {
+    tag1 = {
+      string_value = "value1a"
+    }
+  }
+}
+
+data "elasticstack_fleet_enrollment_tokens" "test_policy" {
+  policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_global_data_tags/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_global_data_tags/variables.tf
@@ -0,0 +1,10 @@
+variable "policy_name" {
+  type        = string
+  description = "Name for the agent policy"
+}
+
+variable "skip_destroy" {
+  type        = bool
+  description = "Whether to skip destruction of the policy"
+  default     = false
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_no_global_data_tags/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_no_global_data_tags/main.tf
@@ -0,0 +1,17 @@
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name            = var.policy_name
+  namespace       = "default"
+  description     = "This policy was updated without global data tags"
+  monitor_logs    = false
+  monitor_metrics = true
+  skip_destroy    = var.skip_destroy
+}
+
+data "elasticstack_fleet_enrollment_tokens" "test_policy" {
+  policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_no_global_data_tags/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_no_global_data_tags/variables.tf
@@ -0,0 +1,10 @@
+variable "policy_name" {
+  type        = string
+  description = "Name for the agent policy"
+}
+
+variable "skip_destroy" {
+  type        = bool
+  description = "Whether to skip destruction of the policy"
+  default     = false
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_supports_agentless/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_supports_agentless/main.tf
@@ -0,0 +1,18 @@
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name               = var.policy_name
+  namespace          = "default"
+  description        = "This policy was updated with supports_agentless"
+  monitor_logs       = false
+  monitor_metrics    = true
+  skip_destroy       = var.skip_destroy
+  supports_agentless = true
+}
+
+data "elasticstack_fleet_enrollment_tokens" "test_policy" {
+  policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_supports_agentless/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_supports_agentless/variables.tf
@@ -0,0 +1,10 @@
+variable "policy_name" {
+  type        = string
+  description = "Name for the agent policy"
+}
+
+variable "skip_destroy" {
+  type        = bool
+  description = "Whether to skip destruction of the policy"
+  default     = false
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_timeouts/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_timeouts/main.tf
@@ -0,0 +1,19 @@
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name                 = var.policy_name
+  namespace            = "default"
+  description          = "Test Agent Policy with Both Timeouts"
+  monitor_logs         = false
+  monitor_metrics      = true
+  skip_destroy         = false
+  inactivity_timeout   = "120s"
+  unenrollment_timeout = "900s"
+}
+
+data "elasticstack_fleet_enrollment_tokens" "test_policy" {
+  policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_timeouts/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/update_with_timeouts/variables.tf
@@ -0,0 +1,4 @@
+variable "policy_name" {
+  type        = string
+  description = "Name for the agent policy"
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/with_inactivity_timeout/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/with_inactivity_timeout/main.tf
@@ -0,0 +1,18 @@
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name               = var.policy_name
+  namespace          = "default"
+  description        = "Test Agent Policy with Inactivity Timeout"
+  monitor_logs       = true
+  monitor_metrics    = false
+  skip_destroy       = false
+  inactivity_timeout = "2m"
+}
+
+data "elasticstack_fleet_enrollment_tokens" "test_policy" {
+  policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/with_inactivity_timeout/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/with_inactivity_timeout/variables.tf
@@ -0,0 +1,4 @@
+variable "policy_name" {
+  type        = string
+  description = "Name for the agent policy"
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/with_unenrollment_timeout/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/with_unenrollment_timeout/main.tf
@@ -0,0 +1,18 @@
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name                 = var.policy_name
+  namespace            = "default"
+  description          = "Test Agent Policy with Unenrollment Timeout"
+  monitor_logs         = true
+  monitor_metrics      = false
+  skip_destroy         = false
+  unenrollment_timeout = "300s"
+}
+
+data "elasticstack_fleet_enrollment_tokens" "test_policy" {
+  policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/with_unenrollment_timeout/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicy/with_unenrollment_timeout/variables.tf
@@ -0,0 +1,4 @@
+variable "policy_name" {
+  type        = string
+  description = "Name for the agent policy"
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicyFromSDK/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicyFromSDK/main.tf
@@ -0,0 +1,28 @@
+variable "policy_name" {
+  type        = string
+  description = "Name for the agent policy"
+}
+
+variable "skip_destroy" {
+  type        = bool
+  description = "Whether to skip destruction of the policy"
+  default     = false
+}
+
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name            = var.policy_name
+  namespace       = "default"
+  description     = "Test Agent Policy"
+  monitor_logs    = true
+  monitor_metrics = false
+  skip_destroy    = var.skip_destroy
+}
+
+data "elasticstack_fleet_enrollment_tokens" "test_policy" {
+  policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySkipDestroy/create/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySkipDestroy/create/main.tf
@@ -0,0 +1,17 @@
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name            = var.policy_name
+  namespace       = "default"
+  description     = "Test Agent Policy"
+  monitor_logs    = true
+  monitor_metrics = false
+  skip_destroy    = var.skip_destroy
+}
+
+data "elasticstack_fleet_enrollment_tokens" "test_policy" {
+  policy_id = elasticstack_fleet_agent_policy.test_policy.policy_id
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySkipDestroy/create/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySkipDestroy/create/variables.tf
@@ -0,0 +1,10 @@
+variable "policy_name" {
+  type        = string
+  description = "Name for the agent policy"
+}
+
+variable "skip_destroy" {
+  type        = bool
+  description = "Whether to skip destruction of the policy"
+  default     = false
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySpaceReordering/step1/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySpaceReordering/step1/main.tf
@@ -0,0 +1,22 @@
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_kibana_space" "test_space" {
+  space_id    = "space-test-a"
+  name        = "Test Space A"
+  description = "Test space for Fleet agent policy space reordering test"
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name            = var.policy_name
+  namespace       = "default"
+  description     = "Test space reordering - step 1"
+  monitor_logs    = true
+  monitor_metrics = false
+  skip_destroy    = false
+  space_ids       = ["default"]
+
+  depends_on = [elasticstack_kibana_space.test_space]
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySpaceReordering/step1/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySpaceReordering/step1/variables.tf
@@ -0,0 +1,4 @@
+variable "policy_name" {
+  type        = string
+  description = "Name for the agent policy"
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySpaceReordering/step2/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySpaceReordering/step2/main.tf
@@ -0,0 +1,25 @@
+provider "elasticstack" {
+  elasticsearch {}
+  kibana {}
+}
+
+resource "elasticstack_kibana_space" "test_space" {
+  space_id    = "space-test-a"
+  name        = "Test Space A"
+  description = "Test space for Fleet agent policy space reordering test"
+}
+
+resource "elasticstack_fleet_agent_policy" "test_policy" {
+  name            = var.policy_name
+  namespace       = "default"
+  description     = "Test space reordering - step 2: prepend new space"
+  monitor_logs    = true
+  monitor_metrics = false
+  skip_destroy    = false
+  # CRITICAL TEST: Prepending "space-test-a" before "default"
+  # Without the fix: Terraform queries using space-test-a, gets 404, recreates resource
+  # With the fix: Terraform uses "default" (position-independent), finds resource, updates in-place
+  space_ids = ["space-test-a", "default"]
+
+  depends_on = [elasticstack_kibana_space.test_space]
+}
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySpaceReordering/step2/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySpaceReordering/step2/variables.tf
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySpaceReordering/step3/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySpaceReordering/step3/main.tf
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySpaceReordering/step3/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicySpaceReordering/step3/variables.tf
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicyWithBadGlobalDataTags/create_with_bad_tags/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicyWithBadGlobalDataTags/create_with_bad_tags/main.tf
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicyWithBadGlobalDataTags/create_with_bad_tags/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicyWithBadGlobalDataTags/create_with_bad_tags/variables.tf
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicyWithSpaceIds/create_with_space_ids/main.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicyWithSpaceIds/create_with_space_ids/main.tf
diff --git a/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicyWithSpaceIds/create_with_space_ids/variables.tf b/internal/fleet/agent_policy/testdata/TestAccResourceAgentPolicyWithSpaceIds/create_with_space_ids/variables.tf
