Skip to content

Commit f503387

Browse files
committed
Remove trace logger in Transformer on default path when a class doesn't need to be transformed. (#136152)
This trace log badly interfered with entitlements in tests. When a class (eg Regex, used by the test mock logger in the case of JULBridgeTests) is loaded as a result of logging, tracing logging that in the Transformer causes a recursive call to the logging appender. Fixes #132280 (cherry picked from commit 2858d6a) # Conflicts: # muted-tests.yml
1 parent 84a31a9 commit f503387

File tree

1 file changed

+1
-3
lines changed
  • libs/entitlement/src/main/java/org/elasticsearch/entitlement/instrumentation

1 file changed

+1
-3
lines changed

libs/entitlement/src/main/java/org/elasticsearch/entitlement/instrumentation/Transformer.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,7 @@ public byte[] transform(
6262
// effectively the same as returning null anyways, so we instead log it here completely
6363
return null;
6464
}
65-
} else {
66-
logger.trace("Not transforming " + className);
67-
return null;
6865
}
66+
return null;
6967
}
7068
}

0 commit comments

Comments
 (0)